jramos/cve-dashboard
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve CARD action error messages and default loader columns

Browse Source 
Show actual CARD API error messages (e.g., 'Cannot redirect asset
because Team is neither confirmed nor pending owner') instead of
generic 'Redirect failed.' or 'confirm failed.' messages.

Also auto-select IPV4_ADDRESS, EQUIP_NAME, and RESPONSIBLE_TEAM
columns by default in the Loader Modal for better initial UX.
This commit is contained in:
Jordan Ramos
2026-05-28 14:25:37 -06:00
parent 93811eda10
commit a6e455311e
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/components/LoaderModal.js
View File

@@ -94,12 +94,16 @@ export default function LoaderModal({ isOpen, onClose, initialDevices }) {
setValidationWarnings([]); setValidationWarnings([]);
}, [isOpen, initialDevices]); }, [isOpen, initialDevices]);
// Auto-select required columns when operation type changes // Auto-select required columns + useful defaults when operation type changes
useEffect(() => { useEffect(() => {
const required = getRequiredColumns(operationType); const required = getRequiredColumns(operationType);
setSelectedColumns(prev => { setSelectedColumns(prev => {
const next = new Set(prev); const next = new Set(prev);
required.forEach(id => next.add(id)); required.forEach(id => next.add(id));
// Always include these useful columns by default
next.add('IPV4_ADDRESS');
next.add('EQUIP_NAME');
next.add('RESPONSIBLE_TEAM');
return next; return next;
}); });
}, [operationType]); }, [operationType]);

6
frontend/src/components/pages/ReportingPage.js
View File

@@ -1669,7 +1669,8 @@ function QueuePanel({ open, items, onClose, onUpdate, onDelete, onDeleteMany, on
}); });
const data = await res.json(); const data = await res.json();
if (!res.ok) { if (!res.ok) {
setCardActionError(data.error || `${actionType} failed.`); const errorMsg = data.error || data.message || (typeof data === 'string' ? data : `${actionType} failed.`);
setCardActionError(errorMsg);
setCardActionLoading(false); setCardActionLoading(false);
return; return;
} }
@@ -1703,7 +1704,8 @@ function QueuePanel({ open, items, onClose, onUpdate, onDelete, onDeleteMany, on
}); });
const data = await res.json(); const data = await res.json();
if (!res.ok) { if (!res.ok) {
setCardActionError(data.error || 'Redirect failed.'); const errorMsg = data.error || data.message || (typeof data === 'string' ? data : JSON.stringify(data));
setCardActionError(errorMsg);
setCardActionLoading(false); setCardActionLoading(false);
return; return;
} }