Compare commits
19 Commits
feature/co
...
7302ece958
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
7302ece958 | ||
|
|
80d80c099f | ||
|
|
a2a43a8685 | ||
|
|
a711972054 | ||
|
|
8a6a3485e9 | ||
|
|
169a0d2337 | ||
|
|
c50fc5d8a8 | ||
|
|
e9e2c0961d | ||
|
|
d910af847e | ||
|
|
73fd747576 | ||
| 1ef57b0504 | |||
|
|
d1fe0bf455 | ||
|
|
3f7887eba6 | ||
|
|
9bd5a52661 | ||
|
|
2b4ec5d8e2 | ||
|
|
62592e9821 | ||
| 2fead2cfef | |||
| 7c0ba41514 | |||
| 9c6c03a518 |
16
.kiro/hooks/check-component-conventions.kiro.hook
Normal file
16
.kiro/hooks/check-component-conventions.kiro.hook
Normal file
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"enabled": true,
|
||||
"name": "Check Component Conventions",
|
||||
"description": "On save of files in frontend/src/components/, verifies the component follows project conventions and flags deviations as inline comments.",
|
||||
"version": "1",
|
||||
"when": {
|
||||
"type": "fileEdited",
|
||||
"patterns": [
|
||||
"frontend/src/components/**/*.js"
|
||||
]
|
||||
},
|
||||
"then": {
|
||||
"type": "askAgent",
|
||||
"prompt": "Review the saved component file and verify it follows these project conventions:\n\n1. Functional component with hooks (no class components)\n2. Uses Lucide icons for iconography (not raw SVGs or other icon libraries)\n3. Uses inline styles or existing CSS classes from App.css (no CSS modules, no styled-components)\n4. Fetches data with fetch() using relative API paths and credentials: 'include' (no axios, no absolute URLs)\n5. Handles loading and error states when fetching data\n\nFor any deviations found, add inline comments in the code flagging the issue, e.g. // ⚠️ CONVENTION: Use lucide-react icons instead of raw SVGs\n\nOnly flag actual deviations. Do not modify working logic or refactor the component."
|
||||
}
|
||||
}
|
||||
16
.kiro/hooks/jsdoc-route-docs.kiro.hook
Normal file
16
.kiro/hooks/jsdoc-route-docs.kiro.hook
Normal file
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"enabled": true,
|
||||
"name": "JSDoc Route Documentation",
|
||||
"description": "On save of files in backend/routes/, ensures every exported route handler has a JSDoc comment documenting the HTTP method, path, query parameters, request body shape, and response shape. Uses the existing documentation style in the file. Does not add comments to internal helper functions.",
|
||||
"version": "1",
|
||||
"when": {
|
||||
"type": "fileEdited",
|
||||
"patterns": [
|
||||
"backend/routes/*.js"
|
||||
]
|
||||
},
|
||||
"then": {
|
||||
"type": "askAgent",
|
||||
"prompt": "Review the saved route file and ensure every exported route handler (e.g., router.get, router.post, router.put, router.patch, router.delete) has a JSDoc comment directly above it documenting: the HTTP method, the route path, any query parameters, the request body shape (if applicable), and the response shape. Match the existing documentation style already used in the file. Do NOT add JSDoc comments to internal helper functions that are not route handlers. Only add missing documentation — do not modify or remove existing JSDoc comments that are already correct."
|
||||
}
|
||||
}
|
||||
16
.kiro/hooks/sqlite3-safety-check.kiro.hook
Normal file
16
.kiro/hooks/sqlite3-safety-check.kiro.hook
Normal file
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"enabled": true,
|
||||
"name": "SQLite3 Safety Check",
|
||||
"description": "On save of files containing db.run, db.get, or db.all, verifies all sqlite3 calls use parameterized queries (? placeholders) instead of string concatenation, handle the error parameter first in every callback, and use hardcoded table/column names. Flags violations as inline comments prefixed with \"// FIXME:\".",
|
||||
"version": "1",
|
||||
"when": {
|
||||
"type": "fileEdited",
|
||||
"patterns": [
|
||||
"backend/**/*.js"
|
||||
]
|
||||
},
|
||||
"then": {
|
||||
"type": "askAgent",
|
||||
"prompt": "The saved file may contain sqlite3 calls (db.run, db.get, or db.all). Scan the file and verify all sqlite3 calls follow these rules:\n\n1. Parameterized queries only: All SQL queries must use ? placeholders for dynamic values. Never use string concatenation or template literals to inject values into SQL strings.\n2. Error-first callbacks: Every callback passed to db.run, db.get, or db.all must handle the error parameter first (e.g., `if (err) { ... }`).\n3. Hardcoded table/column names: All table and column names in SQL strings must be hardcoded string literals, never sourced from variables or parameters.\n\nIf the file does not contain any db.run, db.get, or db.all calls, skip the check silently.\n\nFor any violations found, add an inline comment on the offending line prefixed with \"// FIXME:\" describing the specific issue. Do not modify any other code."
|
||||
}
|
||||
}
|
||||
16
.kiro/hooks/verify-migration-pattern.kiro.hook
Normal file
16
.kiro/hooks/verify-migration-pattern.kiro.hook
Normal file
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"enabled": true,
|
||||
"name": "Verify Migration Pattern",
|
||||
"description": "On save or create of migration files (migrate*.js), verifies the migration follows existing project patterns: uses CREATE TABLE IF NOT EXISTS, includes explicit column types, adds appropriate indexes, and wraps multiple statements in transactions. Compares against existing migrations for style consistency.",
|
||||
"version": "1",
|
||||
"when": {
|
||||
"type": "fileEdited",
|
||||
"patterns": [
|
||||
"**/migrate*.js"
|
||||
]
|
||||
},
|
||||
"then": {
|
||||
"type": "askAgent",
|
||||
"prompt": "A migration file was just saved. Review the edited file and verify it follows the existing migration pattern used in this project. Check the existing migrations in backend/migrations/ for reference, then verify the edited file:\n\n1. Uses CREATE TABLE IF NOT EXISTS (not just CREATE TABLE)\n2. Includes all columns with explicit SQLite types (TEXT, INTEGER, REAL, etc.)\n3. Adds appropriate indexes for foreign keys and frequently queried columns\n4. Wraps operations in a serialized transaction (db.serialize + db.run(\"BEGIN TRANSACTION\") / COMMIT) if there are multiple statements\n5. Follows the same callback-based db.run() style as existing migrations\n6. Includes proper error handling\n\nCompare the file against the existing migrations in backend/migrations/ for style consistency. Report any deviations or issues found."
|
||||
}
|
||||
}
|
||||
16
.kiro/hooks/verify-new-migration.kiro.hook
Normal file
16
.kiro/hooks/verify-new-migration.kiro.hook
Normal file
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"enabled": true,
|
||||
"name": "Verify New Migration",
|
||||
"description": "On creation of new migration files in backend/migrations/, verifies the migration follows existing project patterns: uses CREATE TABLE IF NOT EXISTS, includes explicit column types, adds appropriate indexes, and wraps multiple statements in transactions.",
|
||||
"version": "1",
|
||||
"when": {
|
||||
"type": "fileCreated",
|
||||
"patterns": [
|
||||
"**/migrations/*.js"
|
||||
]
|
||||
},
|
||||
"then": {
|
||||
"type": "askAgent",
|
||||
"prompt": "A new migration file was just created. Review the file and verify it follows the existing migration pattern used in this project. Check the existing migrations in backend/migrations/ for reference, then verify the new file:\n\n1. Uses CREATE TABLE IF NOT EXISTS (not just CREATE TABLE)\n2. Includes all columns with explicit SQLite types (TEXT, INTEGER, REAL, etc.)\n3. Adds appropriate indexes for foreign keys and frequently queried columns\n4. Wraps operations in a serialized transaction (db.serialize + db.run(\"BEGIN TRANSACTION\") / COMMIT) if there are multiple statements\n5. Follows the same callback-based db.run() style as existing migrations\n6. Includes proper error handling\n\nCompare the file against the existing migrations in backend/migrations/ for style consistency. Report any deviations or issues found."
|
||||
}
|
||||
}
|
||||
293
.kiro/specs/finding-archive-tracking/design.md
Normal file
293
.kiro/specs/finding-archive-tracking/design.md
Normal file
@@ -0,0 +1,293 @@
|
||||
# Design Document: Finding Archive Tracking
|
||||
|
||||
## Overview
|
||||
|
||||
The Finding Archive Tracking system adds a detection layer to the existing Ivanti sync pipeline that identifies findings which disappear from sync results due to severity score drift. It tracks these findings through a four-state lifecycle (ACTIVE → ARCHIVED → RETURNED → CLOSED) with full transition history stored in two new SQLite tables. Three new API endpoints expose archive data, and an Archive Summary Bar UI component provides at-a-glance state counts on the Ivanti dashboard.
|
||||
|
||||
The system integrates directly into the existing `syncFindings()` function in `ivantiFindings.js`, comparing current sync results against the previous set to detect disappearances and reappearances. This approach requires no additional API calls to Ivanti and leverages the already-cached findings data.
|
||||
|
||||
## Architecture
|
||||
|
||||
```mermaid
|
||||
flowchart TD
|
||||
subgraph Ivanti Sync Pipeline
|
||||
A[syncFindings] --> B[Fetch all pages from Ivanti API]
|
||||
B --> C[Store findings in ivanti_findings_cache]
|
||||
C --> D[Archive Detection]
|
||||
end
|
||||
|
||||
subgraph Archive Detection
|
||||
D --> E{Compare previous vs current finding IDs}
|
||||
E -->|Missing from current| F[Create/Update Archive Record → ARCHIVED]
|
||||
E -->|Returned in current| G[Update Archive Record → RETURNED]
|
||||
E -->|Closed in Ivanti| H[Update Archive Record → CLOSED]
|
||||
F --> I[Insert Transition History]
|
||||
G --> I
|
||||
H --> I
|
||||
end
|
||||
|
||||
subgraph Archive API
|
||||
J[GET /api/ivanti/archive] --> K[(ivanti_finding_archives)]
|
||||
L[GET /api/ivanti/archive/:findingId/history] --> M[(ivanti_archive_transitions)]
|
||||
N[GET /api/ivanti/archive/stats] --> K
|
||||
end
|
||||
|
||||
subgraph Frontend
|
||||
O[Archive Summary Bar] -->|fetch stats| N
|
||||
O -->|click state| J
|
||||
P[Transition History Panel] -->|fetch history| L
|
||||
end
|
||||
```
|
||||
|
||||
### Integration Points
|
||||
|
||||
1. **Sync Pipeline Hook**: Archive detection runs after `syncFindings()` successfully stores new findings in the cache. It reads the previous findings from the cache before the update, then compares against the new set.
|
||||
2. **Route Registration**: The archive router is mounted at `/api/ivanti/archive` in `server.js`, following the same factory pattern as existing Ivanti routes.
|
||||
3. **Frontend Integration**: The Archive Summary Bar is rendered on the existing Ivanti findings page, above the findings table.
|
||||
|
||||
## Components and Interfaces
|
||||
|
||||
### 1. Archive Detection Module (`detectArchiveChanges`)
|
||||
|
||||
Located within `backend/routes/ivantiFindings.js`, this async function runs after a successful sync.
|
||||
|
||||
```javascript
|
||||
/**
|
||||
* Compare previous and current finding sets to detect archive state changes.
|
||||
* @param {sqlite3.Database} db - SQLite database instance
|
||||
* @param {Array} previousFindings - Findings from before the sync update
|
||||
* @param {Array} currentFindings - Findings from the latest sync
|
||||
*/
|
||||
async function detectArchiveChanges(db, previousFindings, currentFindings) {
|
||||
// 1. Build ID sets from previous and current
|
||||
// 2. Disappeared = in previous but not in current → ARCHIVED
|
||||
// 3. Returned = in current AND has existing ARCHIVED record → RETURNED
|
||||
// 4. For each state change, upsert archive record + insert transition
|
||||
}
|
||||
```
|
||||
|
||||
### 2. Closed Finding Detection (`detectClosedFindings`)
|
||||
|
||||
Runs during the closed count sync to detect findings that transitioned to CLOSED in Ivanti.
|
||||
|
||||
```javascript
|
||||
/**
|
||||
* Check archived findings against Ivanti closed findings to detect remediation.
|
||||
* @param {sqlite3.Database} db - SQLite database instance
|
||||
* @param {Array} closedFindingIds - IDs of findings confirmed closed in Ivanti
|
||||
*/
|
||||
async function detectClosedFindings(db, closedFindingIds) {
|
||||
// For each archived/returned finding, if it appears in closed set → CLOSED
|
||||
}
|
||||
```
|
||||
|
||||
### 3. Archive API Router (`createIvantiArchiveRouter`)
|
||||
|
||||
Located at `backend/routes/ivantiArchive.js`, follows the existing factory pattern.
|
||||
|
||||
```javascript
|
||||
/**
|
||||
* @param {sqlite3.Database} db - SQLite database instance
|
||||
* @param {Function} requireAuth - Auth middleware factory
|
||||
* @returns {express.Router}
|
||||
*/
|
||||
function createIvantiArchiveRouter(db, requireAuth) {
|
||||
const router = express.Router();
|
||||
router.use(requireAuth(db));
|
||||
|
||||
// GET / - List archive records, optional ?state= filter
|
||||
// GET /stats - Summary counts by state
|
||||
// GET /:findingId/history - Transition history for a finding
|
||||
|
||||
return router;
|
||||
}
|
||||
```
|
||||
|
||||
### 4. Archive Summary Bar Component (`ArchiveSummaryBar`)
|
||||
|
||||
Located at `frontend/src/components/pages/ArchiveSummaryBar.js`.
|
||||
|
||||
```javascript
|
||||
/**
|
||||
* Displays four stat cards for ACTIVE, ARCHIVED, RETURNED, CLOSED counts.
|
||||
* @param {Object} props
|
||||
* @param {Function} props.onStateClick - Callback when a state card is clicked
|
||||
* @param {string|null} props.activeFilter - Currently selected state filter
|
||||
*/
|
||||
function ArchiveSummaryBar({ onStateClick, activeFilter }) { ... }
|
||||
```
|
||||
|
||||
### API Endpoint Specifications
|
||||
|
||||
| Endpoint | Method | Auth | Query Params | Response |
|
||||
|----------|--------|------|-------------|----------|
|
||||
| `/api/ivanti/archive` | GET | Required | `state` (optional: ACTIVE, ARCHIVED, RETURNED, CLOSED) | `{ archives: [...], total: N }` |
|
||||
| `/api/ivanti/archive/stats` | GET | Required | None | `{ ARCHIVED: N, RETURNED: N, CLOSED: N, total: N }` |
|
||||
| `/api/ivanti/archive/:findingId/history` | GET | Required | None | `{ finding_id: "...", transitions: [...] }` |
|
||||
|
||||
## Data Models
|
||||
|
||||
### `ivanti_finding_archives` Table
|
||||
|
||||
| Column | Type | Constraints | Description |
|
||||
|--------|------|-------------|-------------|
|
||||
| `id` | INTEGER | PRIMARY KEY AUTOINCREMENT | Row ID |
|
||||
| `finding_id` | TEXT | NOT NULL UNIQUE | Ivanti finding identifier |
|
||||
| `finding_title` | TEXT | NOT NULL DEFAULT '' | Finding title at time of archival |
|
||||
| `host_name` | TEXT | NOT NULL DEFAULT '' | Host name at time of archival |
|
||||
| `ip_address` | TEXT | NOT NULL DEFAULT '' | IP address at time of archival |
|
||||
| `current_state` | TEXT | NOT NULL CHECK(IN ('ARCHIVED','RETURNED','CLOSED')) | Current lifecycle state |
|
||||
| `last_severity` | REAL | NOT NULL DEFAULT 0 | Last known severity score |
|
||||
| `first_archived_at` | DATETIME | NOT NULL DEFAULT CURRENT_TIMESTAMP | When first archived |
|
||||
| `last_transition_at` | DATETIME | NOT NULL DEFAULT CURRENT_TIMESTAMP | When last state change occurred |
|
||||
| `created_at` | DATETIME | DEFAULT CURRENT_TIMESTAMP | Row creation time |
|
||||
|
||||
**Indexes:**
|
||||
- `idx_archive_finding_id` on `finding_id`
|
||||
- `idx_archive_current_state` on `current_state`
|
||||
|
||||
### `ivanti_archive_transitions` Table
|
||||
|
||||
| Column | Type | Constraints | Description |
|
||||
|--------|------|-------------|-------------|
|
||||
| `id` | INTEGER | PRIMARY KEY AUTOINCREMENT | Row ID |
|
||||
| `archive_id` | INTEGER | NOT NULL, FK → ivanti_finding_archives(id) | Parent archive record |
|
||||
| `from_state` | TEXT | NOT NULL | Previous state (or 'NONE' for initial) |
|
||||
| `to_state` | TEXT | NOT NULL | New state |
|
||||
| `severity_at_transition` | REAL | NOT NULL DEFAULT 0 | Severity score at time of transition |
|
||||
| `reason` | TEXT | NOT NULL DEFAULT '' | Human-readable reason |
|
||||
| `transitioned_at` | DATETIME | NOT NULL DEFAULT CURRENT_TIMESTAMP | When transition occurred |
|
||||
|
||||
**Indexes:**
|
||||
- `idx_transition_archive_id` on `archive_id`
|
||||
|
||||
### State Transition Diagram
|
||||
|
||||
Archive records are only created when a finding first disappears from sync results. Findings that remain present in sync results do not get archive records — they are simply "active" in the findings cache. The three database states are ARCHIVED, RETURNED, and CLOSED.
|
||||
|
||||
```mermaid
|
||||
stateDiagram-v2
|
||||
[*] --> ARCHIVED : Finding disappears from sync (score drift)
|
||||
ARCHIVED --> RETURNED : Reappeared in sync
|
||||
ARCHIVED --> CLOSED : Confirmed remediated in Ivanti
|
||||
RETURNED --> ARCHIVED : Disappeared again
|
||||
RETURNED --> CLOSED : Confirmed remediated in Ivanti
|
||||
```
|
||||
|
||||
### Valid State Transitions
|
||||
|
||||
| From State | To State | Reason |
|
||||
|-----------|----------|--------|
|
||||
| NONE → | ARCHIVED | `severity_score_drift` (first disappearance) |
|
||||
| ARCHIVED → | RETURNED | `reappeared_in_sync` |
|
||||
| ARCHIVED → | CLOSED | `remediated_in_ivanti` |
|
||||
| RETURNED → | ARCHIVED | `severity_score_drift` |
|
||||
| RETURNED → | CLOSED | `remediated_in_ivanti` |
|
||||
|
||||
|
||||
## Correctness Properties
|
||||
|
||||
*A property is a characteristic or behavior that should hold true across all valid executions of a system — essentially, a formal statement about what the system should do. Properties serve as the bridge between human-readable specifications and machine-verifiable correctness guarantees.*
|
||||
|
||||
### Property 1: Disappeared findings are archived with complete metadata
|
||||
|
||||
*For any* set of previous findings and current findings, every finding present in the previous set but absent from the current set should have an Archive_Record with state ARCHIVED, and that record should contain the correct finding_id, finding_title, host_name, ip_address, and last_severity matching the original finding's data.
|
||||
|
||||
**Validates: Requirements 1.1, 1.2, 2.2**
|
||||
|
||||
### Property 2: Returned findings transition from ARCHIVED to RETURNED
|
||||
|
||||
*For any* finding that has an Archive_Record with state ARCHIVED, if that finding reappears in the current sync results, the Archive_Record state should be updated to RETURNED and the last_severity should reflect the finding's current severity score.
|
||||
|
||||
**Validates: Requirements 1.3**
|
||||
|
||||
### Property 3: Re-disappeared findings transition from RETURNED to ARCHIVED
|
||||
|
||||
*For any* finding that has an Archive_Record with state RETURNED, if that finding disappears from the current sync results, the Archive_Record state should be updated back to ARCHIVED.
|
||||
|
||||
**Validates: Requirements 1.4**
|
||||
|
||||
### Property 4: Every state transition produces a history record with all required fields
|
||||
|
||||
*For any* state transition on an Archive_Record, a Transition_History row should be inserted containing a valid archive_id, the correct from_state and to_state, a severity_at_transition value, a non-empty reason string, and a transitioned_at timestamp.
|
||||
|
||||
**Validates: Requirements 2.1**
|
||||
|
||||
### Property 5: Closed findings transition to CLOSED state
|
||||
|
||||
*For any* finding that has an Archive_Record with state ARCHIVED or RETURNED, if that finding appears in the Ivanti closed findings set, the Archive_Record state should be updated to CLOSED and the transition reason should be "remediated_in_ivanti".
|
||||
|
||||
**Validates: Requirements 2.3**
|
||||
|
||||
### Property 6: State filter returns only matching records
|
||||
|
||||
*For any* set of Archive_Records with various states, querying the archive list endpoint with a state filter should return only records whose current_state matches the filter, and the count should equal the number of records in that state.
|
||||
|
||||
**Validates: Requirements 4.1**
|
||||
|
||||
### Property 7: Transition history is ordered by timestamp descending
|
||||
|
||||
*For any* finding with multiple Transition_History entries, the history endpoint should return entries ordered by transitioned_at descending, such that each entry's timestamp is greater than or equal to the next entry's timestamp.
|
||||
|
||||
**Validates: Requirements 4.2**
|
||||
|
||||
### Property 8: Stats counts match actual record distribution
|
||||
|
||||
*For any* set of Archive_Records, the stats endpoint should return counts where the sum of all state counts equals the total number of Archive_Records, and each individual state count matches the actual number of records in that state.
|
||||
|
||||
**Validates: Requirements 4.3**
|
||||
|
||||
### Property 9: Migration idempotency
|
||||
|
||||
*For any* number of consecutive executions of the migration script, the resulting database schema should be identical and no errors should occur on subsequent runs.
|
||||
|
||||
**Validates: Requirements 6.2**
|
||||
|
||||
## Error Handling
|
||||
|
||||
| Scenario | Handling |
|
||||
|----------|----------|
|
||||
| Sync fails (API error, timeout) | Archive detection is skipped entirely for that cycle. No archive records are created or modified. The sync error is logged as usual. |
|
||||
| Database error during archive upsert | Log the error, continue processing remaining findings. Do not abort the entire archive detection pass. |
|
||||
| Database error during transition insert | Log the error. The archive record state may have been updated but the transition history may be incomplete. This is acceptable as the current state is the source of truth. |
|
||||
| Invalid state transition attempted | The detection logic only performs valid transitions per the state diagram. Invalid transitions (e.g., CLOSED → ARCHIVED) are not possible by design since closed findings are excluded from the sync pipeline. |
|
||||
| Missing finding metadata | Use empty string defaults for finding_title, host_name, ip_address if the finding object lacks these fields. Severity defaults to 0. |
|
||||
| Archive API query with invalid state parameter | Return a 400 status code with message "Invalid state parameter. Valid values: ACTIVE, ARCHIVED, RETURNED, CLOSED". Explicit errors surface frontend bugs faster than silent fallbacks. |
|
||||
| History query for non-existent finding | Return 200 with empty transitions array (not 404), per requirement 4.5. |
|
||||
|
||||
## Testing Strategy
|
||||
|
||||
### Unit Tests
|
||||
|
||||
Unit tests cover specific examples and edge cases:
|
||||
|
||||
- Migration script creates both tables and all indexes (example, Req 3.1–3.4)
|
||||
- Archive detection skips when sync errors occur (example, Req 1.5)
|
||||
- Unauthenticated requests return 401 (example, Req 4.4)
|
||||
- History endpoint returns empty array for unknown finding (edge case, Req 4.5)
|
||||
- Archive Summary Bar renders four stat cards (example, Req 5.1)
|
||||
- Archive Summary Bar fetches stats on mount (example, Req 5.2)
|
||||
- Clicking a state card triggers filter callback (example, Req 5.3)
|
||||
|
||||
### Property-Based Tests
|
||||
|
||||
Property-based tests use a PBT library (e.g., `fast-check`) to verify universal properties across generated inputs. Each test runs a minimum of 100 iterations.
|
||||
|
||||
| Property | Test Description | Tag |
|
||||
|----------|-----------------|-----|
|
||||
| Property 1 | Generate random previous/current finding sets, run detection, verify all disappeared findings have correct ARCHIVED records | **Feature: finding-archive-tracking, Property 1: Disappeared findings are archived with complete metadata** |
|
||||
| Property 2 | Generate archived findings, add some back to current set, verify RETURNED state | **Feature: finding-archive-tracking, Property 2: Returned findings transition from ARCHIVED to RETURNED** |
|
||||
| Property 3 | Generate returned findings, remove some from current set, verify ARCHIVED state | **Feature: finding-archive-tracking, Property 3: Re-disappeared findings transition from RETURNED to ARCHIVED** |
|
||||
| Property 4 | Generate random state transitions, verify each produces a complete history row | **Feature: finding-archive-tracking, Property 4: Every state transition produces a history record** |
|
||||
| Property 5 | Generate archived/returned findings, mark some as closed, verify CLOSED state and reason | **Feature: finding-archive-tracking, Property 5: Closed findings transition to CLOSED state** |
|
||||
| Property 6 | Generate archive records with random states, query with filter, verify only matching records returned | **Feature: finding-archive-tracking, Property 6: State filter returns only matching records** |
|
||||
| Property 7 | Generate multiple transitions for a finding, query history, verify descending order | **Feature: finding-archive-tracking, Property 7: Transition history is ordered by timestamp descending** |
|
||||
| Property 8 | Generate archive records with random states, query stats, verify counts match | **Feature: finding-archive-tracking, Property 8: Stats counts match actual record distribution** |
|
||||
| Property 9 | Run migration N times, verify no errors and schema is consistent | **Feature: finding-archive-tracking, Property 9: Migration idempotency** |
|
||||
|
||||
### Testing Tools
|
||||
|
||||
- **Test runner**: Jest (via react-scripts for frontend, direct for backend)
|
||||
- **Property-based testing**: `fast-check` library
|
||||
- **Database**: In-memory SQLite (`:memory:`) for isolated test runs
|
||||
- **HTTP testing**: `supertest` for API endpoint tests
|
||||
86
.kiro/specs/finding-archive-tracking/requirements.md
Normal file
86
.kiro/specs/finding-archive-tracking/requirements.md
Normal file
@@ -0,0 +1,86 @@
|
||||
# Requirements Document
|
||||
|
||||
## Introduction
|
||||
|
||||
The Finding Archive Tracking system extends the Ivanti sync pipeline in the STEAM Security Dashboard to detect and track findings that disappear from sync results due to severity score drift (not remediation). Findings follow a four-state lifecycle (ACTIVE → ARCHIVED → RETURNED → CLOSED) with full transition history, enabling the security team to maintain visibility into findings that fall below the severity threshold and may reappear.
|
||||
|
||||
## Glossary
|
||||
|
||||
- **Sync_Pipeline**: The existing Ivanti/RiskSense host finding sync process that fetches open findings matching BU and severity filters on a daily schedule.
|
||||
- **Finding**: A single host-level vulnerability record identified by a unique `finding_id` from Ivanti/RiskSense.
|
||||
- **Archive_Record**: A database row in the `ivanti_finding_archives` table tracking a finding's current lifecycle state and metadata.
|
||||
- **Transition_History**: A database row in the `ivanti_archive_transitions` table recording a single state change event with timestamps, severity scores, and reason.
|
||||
- **Archive_Detector**: The logic within the sync pipeline that compares previous sync results against current results to identify disappeared and returned findings.
|
||||
- **Archive_Summary_Bar**: A React UI component displaying counts for each lifecycle state (ACTIVE, ARCHIVED, RETURNED, CLOSED) with click-through navigation.
|
||||
- **Archive_API**: The set of three Express route endpoints serving archived finding data, transition history, and summary statistics.
|
||||
- **Lifecycle_State**: One of three database states an archive record can occupy: ARCHIVED (disappeared from sync results due to score drift), RETURNED (reappeared after being archived), CLOSED (remediated in Ivanti). Findings that remain present in sync results have no archive record.
|
||||
|
||||
## Requirements
|
||||
|
||||
### Requirement 1: Archive Detection During Sync
|
||||
|
||||
**User Story:** As a security analyst, I want the system to automatically detect findings that disappear from sync results, so that I can track findings lost due to severity score drift rather than actual remediation.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN the Sync_Pipeline completes a sync, THE Archive_Detector SHALL compare the current sync result finding IDs against the previous sync result finding IDs to identify findings that are no longer present.
|
||||
2. WHEN a finding is present in the previous sync but absent from the current sync, THE Archive_Detector SHALL create an Archive_Record with state ARCHIVED, recording the finding metadata, last known severity score, and a timestamp.
|
||||
3. WHEN a finding already has an Archive_Record with state ARCHIVED and the finding reappears in the current sync results, THE Archive_Detector SHALL update the Archive_Record state to RETURNED and record the new severity score.
|
||||
4. WHEN a finding has an Archive_Record with state RETURNED and the finding disappears again from sync results, THE Archive_Detector SHALL update the Archive_Record state to ARCHIVED and record the severity score at time of disappearance.
|
||||
5. IF the Sync_Pipeline encounters a sync error, THEN THE Archive_Detector SHALL skip archive detection for that sync cycle to avoid false positives from incomplete data.
|
||||
|
||||
### Requirement 2: Lifecycle State Transitions
|
||||
|
||||
**User Story:** As a security analyst, I want every state change to be recorded with context, so that I can audit the full history of a finding's lifecycle.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN an Archive_Record changes state, THE Sync_Pipeline SHALL insert a Transition_History row containing the previous state, new state, timestamp, severity score at time of transition, and a reason string.
|
||||
2. THE Archive_Record SHALL store the finding_id, finding_title, host_name, ip_address, current state, last known severity score, initial archive timestamp, and last transition timestamp.
|
||||
3. WHEN a finding is confirmed as remediated (closed) in Ivanti, THE Sync_Pipeline SHALL update the Archive_Record state to CLOSED and record a Transition_History entry with reason "remediated_in_ivanti".
|
||||
4. THE Transition_History SHALL store the archive_record_id, from_state, to_state, transition timestamp, severity_at_transition, and reason.
|
||||
|
||||
### Requirement 3: Database Schema
|
||||
|
||||
**User Story:** As a developer, I want the archive data stored in two normalized SQLite tables, so that the data model supports efficient queries and maintains referential integrity.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Sync_Pipeline SHALL create an `ivanti_finding_archives` table with columns for id, finding_id (unique), finding_title, host_name, ip_address, current_state, last_severity, first_archived_at, last_transition_at, and created_at.
|
||||
2. THE Sync_Pipeline SHALL create an `ivanti_archive_transitions` table with columns for id, archive_id (foreign key to ivanti_finding_archives), from_state, to_state, severity_at_transition, reason, and transitioned_at.
|
||||
3. THE Sync_Pipeline SHALL create indexes on ivanti_finding_archives(finding_id) and ivanti_finding_archives(current_state) for query performance.
|
||||
4. THE Sync_Pipeline SHALL create an index on ivanti_archive_transitions(archive_id) for efficient history lookups.
|
||||
|
||||
### Requirement 4: Archive API Endpoints
|
||||
|
||||
**User Story:** As a frontend developer, I want REST API endpoints to query archived findings, transition history, and summary statistics, so that I can build the archive tracking UI.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN a GET request is made to `/api/ivanti/archive`, THE Archive_API SHALL return a list of all Archive_Records with optional filtering by current_state query parameter.
|
||||
2. WHEN a GET request is made to `/api/ivanti/archive/:findingId/history`, THE Archive_API SHALL return the Transition_History entries for the specified finding ordered by transitioned_at descending.
|
||||
3. WHEN a GET request is made to `/api/ivanti/archive/stats`, THE Archive_API SHALL return an object containing the count of Archive_Records in each Lifecycle_State (ACTIVE, ARCHIVED, RETURNED, CLOSED).
|
||||
4. WHEN an unauthenticated request is made to any Archive_API endpoint, THE Archive_API SHALL return a 401 status code.
|
||||
5. WHEN a GET request is made to `/api/ivanti/archive/:findingId/history` with a finding_id that has no Archive_Record, THE Archive_API SHALL return an empty transitions array with a 200 status code.
|
||||
|
||||
### Requirement 5: Archive Summary Bar UI
|
||||
|
||||
**User Story:** As a security analyst, I want a visual summary bar on the Ivanti dashboard showing counts for each archive state, so that I can quickly assess the archive landscape and navigate to details.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Archive_Summary_Bar SHALL display four stat cards showing the count of findings in each Lifecycle_State: ACTIVE, ARCHIVED, RETURNED, and CLOSED.
|
||||
2. WHEN the Archive_Summary_Bar loads, THE Archive_Summary_Bar SHALL fetch data from the `/api/ivanti/archive/stats` endpoint.
|
||||
3. WHEN a user clicks a state card in the Archive_Summary_Bar, THE Archive_Summary_Bar SHALL filter the displayed archive list to show only findings in that state.
|
||||
4. THE Archive_Summary_Bar SHALL use the existing design system colors: sky blue (#0EA5E9) for ACTIVE, amber (#F59E0B) for ARCHIVED, emerald (#10B981) for RETURNED, and red (#EF4444) for CLOSED.
|
||||
5. THE Archive_Summary_Bar SHALL use Lucide icons and monospace typography consistent with the existing dashboard design system.
|
||||
|
||||
### Requirement 6: Migration Script
|
||||
|
||||
**User Story:** As a developer, I want a standalone migration script to create the archive tables, so that the schema can be applied to existing deployments following the established migration pattern.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE migration script SHALL be located at `backend/migrations/add_finding_archive_tables.js` and follow the existing migration pattern of opening the database, running DDL statements in `db.serialize()`, and closing the connection.
|
||||
2. THE migration script SHALL use `CREATE TABLE IF NOT EXISTS` and `CREATE INDEX IF NOT EXISTS` to be idempotent.
|
||||
3. WHEN the migration script is executed, THE migration script SHALL log progress messages for each table and index created.
|
||||
134
.kiro/specs/finding-archive-tracking/tasks.md
Normal file
134
.kiro/specs/finding-archive-tracking/tasks.md
Normal file
@@ -0,0 +1,134 @@
|
||||
# Implementation Plan: Finding Archive Tracking
|
||||
|
||||
## Overview
|
||||
|
||||
Implement the Finding Archive Tracking system by creating the database migration, archive detection logic within the existing sync pipeline, three API endpoints via a new route module, and an Archive Summary Bar UI component. Each task builds incrementally — schema first, then detection logic, then API, then frontend.
|
||||
|
||||
## Tasks
|
||||
|
||||
- [x] 1. Create database migration and archive tables
|
||||
- [x] 1.1 Create `backend/migrations/add_finding_archive_tables.js` migration script
|
||||
- Create `ivanti_finding_archives` table with columns: id, finding_id (UNIQUE), finding_title, host_name, ip_address, current_state (CHECK constraint for ACTIVE/ARCHIVED/RETURNED/CLOSED), last_severity, first_archived_at, last_transition_at, created_at
|
||||
- Create `ivanti_archive_transitions` table with columns: id, archive_id (FK), from_state, to_state, severity_at_transition, reason, transitioned_at
|
||||
- Create indexes: idx_archive_finding_id, idx_archive_current_state, idx_transition_archive_id
|
||||
- Use `CREATE TABLE IF NOT EXISTS` and `CREATE INDEX IF NOT EXISTS` for idempotency
|
||||
- Follow existing migration pattern: open db, `db.serialize()`, log progress, close db
|
||||
- _Requirements: 3.1, 3.2, 3.3, 3.4, 6.1, 6.2, 6.3_
|
||||
|
||||
- [ ]* 1.2 Write property test for migration idempotency
|
||||
- **Property 9: Migration idempotency**
|
||||
- Run migration logic multiple times against in-memory SQLite, verify no errors and schema is consistent
|
||||
- **Validates: Requirements 6.2**
|
||||
|
||||
- [x] 2. Implement archive detection logic in sync pipeline
|
||||
- [x] 2.1 Add `initArchiveTables(db)` function to `backend/routes/ivantiFindings.js`
|
||||
- Create both archive tables inline (same pattern as existing `initTables`) so they exist on startup
|
||||
- Call from `createIvantiFindingsRouter` during init alongside existing `initTables`
|
||||
- _Requirements: 3.1, 3.2, 3.3, 3.4_
|
||||
|
||||
- [x] 2.2 Implement `detectArchiveChanges(db, previousFindings, currentFindings)` function
|
||||
- Build ID sets from previous and current findings
|
||||
- For disappeared findings (in previous, not in current): upsert archive record with state ARCHIVED, insert transition history
|
||||
- For returned findings (in current, has ARCHIVED record): update to RETURNED, insert transition history
|
||||
- For re-disappeared findings (has RETURNED record, not in current): update to ARCHIVED, insert transition history
|
||||
- Use `db.run` with callbacks wrapped in promises (matching existing `dbRun` helper pattern)
|
||||
- _Requirements: 1.1, 1.2, 1.3, 1.4, 2.1, 2.2_
|
||||
|
||||
- [x] 2.3 Implement `detectClosedFindings(db, closedFindingIds)` function
|
||||
- Query archive records with state ARCHIVED or RETURNED
|
||||
- For any that appear in the closed findings set, update to CLOSED with reason "remediated_in_ivanti"
|
||||
- Insert transition history for each state change
|
||||
- _Requirements: 2.3_
|
||||
|
||||
- [x] 2.4 Integrate archive detection into `syncFindings()` flow
|
||||
- Before updating the cache, read the current findings from `ivanti_findings_cache` as `previousFindings`
|
||||
- After successful cache update, call `detectArchiveChanges(db, previousFindings, currentFindings)`
|
||||
- Skip archive detection if sync encountered an error (requirement 1.5)
|
||||
- Call `detectClosedFindings` during `syncClosedCount` with closed finding IDs
|
||||
- _Requirements: 1.1, 1.5, 2.3_
|
||||
|
||||
- [ ]* 2.5 Write property test for archive detection — disappeared findings
|
||||
- **Property 1: Disappeared findings are archived with complete metadata**
|
||||
- Generate random previous/current finding sets using fast-check, run detectArchiveChanges against in-memory SQLite, verify all disappeared findings have ARCHIVED records with correct metadata
|
||||
- **Validates: Requirements 1.1, 1.2, 2.2**
|
||||
|
||||
- [ ]* 2.6 Write property test for archive detection — returned findings
|
||||
- **Property 2: Returned findings transition from ARCHIVED to RETURNED**
|
||||
- Generate archived findings, add some back to current set, verify RETURNED state and updated severity
|
||||
- **Validates: Requirements 1.3**
|
||||
|
||||
- [ ]* 2.7 Write property test for archive detection — re-disappeared findings
|
||||
- **Property 3: Re-disappeared findings transition from RETURNED to ARCHIVED**
|
||||
- Generate returned findings, remove some from current set, verify ARCHIVED state
|
||||
- **Validates: Requirements 1.4**
|
||||
|
||||
- [ ]* 2.8 Write property test for transition history completeness
|
||||
- **Property 4: Every state transition produces a history record with all required fields**
|
||||
- Generate random state transitions, verify each produces a complete history row with archive_id, from_state, to_state, severity_at_transition, reason, transitioned_at
|
||||
- **Validates: Requirements 2.1**
|
||||
|
||||
- [ ]* 2.9 Write property test for closed finding detection
|
||||
- **Property 5: Closed findings transition to CLOSED state**
|
||||
- Generate archived/returned findings, mark some as closed, verify CLOSED state and reason "remediated_in_ivanti"
|
||||
- **Validates: Requirements 2.3**
|
||||
|
||||
- [x] 3. Checkpoint — Verify archive detection logic
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
- [x] 4. Implement Archive API endpoints
|
||||
- [x] 4.1 Create `backend/routes/ivantiArchive.js` route module
|
||||
- Export factory function `createIvantiArchiveRouter(db, requireAuth)` returning Express Router
|
||||
- Apply `requireAuth(db)` middleware to all routes
|
||||
- Implement GET `/` — list archive records with optional `?state=` filter, return `{ archives: [...], total: N }`. Return 400 with message "Invalid state parameter. Valid values: ACTIVE, ARCHIVED, RETURNED, CLOSED" if an unrecognized state value is provided.
|
||||
- Implement GET `/stats` — return `{ ACTIVE: N, ARCHIVED: N, RETURNED: N, CLOSED: N, total: N }`
|
||||
- Implement GET `/:findingId/history` — return `{ finding_id, transitions: [...] }` ordered by transitioned_at DESC, return empty array for unknown finding_id
|
||||
- _Requirements: 4.1, 4.2, 4.3, 4.4, 4.5_
|
||||
|
||||
- [x] 4.2 Register archive router in `backend/server.js`
|
||||
- Import `createIvantiArchiveRouter` from `./routes/ivantiArchive`
|
||||
- Mount at `/api/ivanti/archive` with `requireAuth` middleware
|
||||
- _Requirements: 4.1_
|
||||
|
||||
- [ ]* 4.3 Write property test for state filtering
|
||||
- **Property 6: State filter returns only matching records**
|
||||
- Generate archive records with random states, query with filter, verify only matching records returned
|
||||
- **Validates: Requirements 4.1**
|
||||
|
||||
- [ ]* 4.4 Write property test for history ordering
|
||||
- **Property 7: Transition history is ordered by timestamp descending**
|
||||
- Generate multiple transitions for a finding, query history, verify descending timestamp order
|
||||
- **Validates: Requirements 4.2**
|
||||
|
||||
- [ ]* 4.5 Write property test for stats accuracy
|
||||
- **Property 8: Stats counts match actual record distribution**
|
||||
- Generate archive records with random states, query stats, verify counts match actual distribution
|
||||
- **Validates: Requirements 4.3**
|
||||
|
||||
- [x] 5. Checkpoint — Verify API endpoints
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
- [x] 6. Implement Archive Summary Bar UI component
|
||||
- [x] 6.1 Create `frontend/src/components/pages/ArchiveSummaryBar.js`
|
||||
- Fetch stats from `/api/ivanti/archive/stats` on mount
|
||||
- Render four stat cards: ACTIVE (sky blue #0EA5E9), ARCHIVED (amber #F59E0B), RETURNED (emerald #10B981), CLOSED (red #EF4444)
|
||||
- Each card shows the count and state label with Lucide icons and monospace typography
|
||||
- Accept `onStateClick` callback prop and `activeFilter` prop for highlighting the selected state
|
||||
- Use inline style objects matching the existing design system (dark gradients, glows, hover effects)
|
||||
- _Requirements: 5.1, 5.2, 5.3, 5.4, 5.5_
|
||||
|
||||
- [x] 6.2 Integrate Archive Summary Bar into the Ivanti findings page
|
||||
- Import and render `ArchiveSummaryBar` in the Ivanti findings section of `App.js` (or the relevant page component)
|
||||
- Wire `onStateClick` to manage a state filter for the archive list display
|
||||
- _Requirements: 5.3_
|
||||
|
||||
- [x] 7. Final checkpoint — Verify full integration
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
## Notes
|
||||
|
||||
- Tasks marked with `*` are optional and can be skipped for faster MVP
|
||||
- Each task references specific requirements for traceability
|
||||
- Checkpoints ensure incremental validation
|
||||
- Property tests use `fast-check` library with minimum 100 iterations per test
|
||||
- All backend code uses callback-based SQLite API wrapped in promises (matching existing patterns)
|
||||
- All frontend code uses plain JavaScript (no TypeScript)
|
||||
0
.kiro/specs/group-based-access-control/design.md
Normal file
0
.kiro/specs/group-based-access-control/design.md
Normal file
143
.kiro/specs/group-based-access-control/requirements.md
Normal file
143
.kiro/specs/group-based-access-control/requirements.md
Normal file
@@ -0,0 +1,143 @@
|
||||
# Requirements Document
|
||||
|
||||
## Introduction
|
||||
|
||||
Replace the existing simple role-based access control system (admin/editor/viewer) with a group-based access control model. The system supports exactly four user groups (Admin, Standard User, Leadership, Read Only) with distinct permission boundaries. This change affects the database schema, backend middleware, API endpoint authorization, frontend conditional rendering, and the admin panel user management interface.
|
||||
|
||||
## Glossary
|
||||
|
||||
- **Dashboard**: The STEAM Security Dashboard application comprising a React frontend and Express backend
|
||||
- **Group**: One of four access control categories (Admin, Standard_User, Leadership, Read_Only) that determines a user's permissions
|
||||
- **Admin_Group**: The group with full CRUD access to all resources, user management, and admin panel access
|
||||
- **Standard_User_Group**: The working group with view-all, create, edit, and conditional delete permissions plus basic export
|
||||
- **Leadership_Group**: The read-only group with additional export capabilities for reports, compliance documents, and visualizations
|
||||
- **Read_Only_Group**: The view-only group with no create, edit, delete, or export capabilities
|
||||
- **Permission_Middleware**: Backend Express middleware that validates a user's group membership before allowing an API action
|
||||
- **Cascade_Impact**: The set of associated Archer tickets, JIRA tickets, and documents that would be deleted when a CVE is deleted
|
||||
- **Compliance_Link**: An association between a ticket (Archer or JIRA) and a compliance report that blocks Standard_User deletion
|
||||
- **Group_Migration**: The database migration that replaces the role field with a group field and maps existing users
|
||||
|
||||
## Requirements
|
||||
|
||||
### Requirement 1: Group Data Model
|
||||
|
||||
**User Story:** As a system administrator, I want the user model to reference one of four defined groups instead of the legacy role field, so that permissions are enforced through a well-defined group structure.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL store exactly four groups: Admin, Standard_User, Leadership, and Read_Only
|
||||
2. THE Dashboard SHALL assign each user to exactly one group via a group field on the user record
|
||||
3. WHEN a user record is created, THE Dashboard SHALL default the group to Read_Only
|
||||
4. THE Dashboard SHALL enforce a foreign key or CHECK constraint so that the group field only accepts valid group values
|
||||
|
||||
### Requirement 2: Group Migration
|
||||
|
||||
**User Story:** As a system administrator, I want existing users to be automatically mapped from the old role system to the new group system, so that no manual re-assignment is needed after the upgrade.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN the migration runs, THE Group_Migration SHALL map users with role "admin" to Admin_Group
|
||||
2. WHEN the migration runs, THE Group_Migration SHALL map users with role "editor" to Standard_User_Group
|
||||
3. WHEN the migration runs, THE Group_Migration SHALL map users with role "viewer" to Read_Only_Group
|
||||
4. WHEN the migration runs, THE Group_Migration SHALL remove the CHECK constraint on the old role column and replace it with the new group field
|
||||
5. IF a user record has no role value or an unrecognized role value, THEN THE Group_Migration SHALL assign that user to Read_Only_Group
|
||||
|
||||
### Requirement 3: Backend Permission Enforcement
|
||||
|
||||
**User Story:** As a security-conscious developer, I want every API endpoint to check the requesting user's group before allowing the action, so that permissions are enforced server-side and cannot be bypassed through direct API calls.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Permission_Middleware SHALL replace the existing requireRole middleware with a requireGroup middleware that accepts one or more group names
|
||||
2. WHEN an unauthenticated request reaches a protected endpoint, THE Permission_Middleware SHALL return HTTP 401
|
||||
3. WHEN an authenticated user's group is not in the allowed groups for an endpoint, THE Permission_Middleware SHALL return HTTP 403
|
||||
4. THE Permission_Middleware SHALL attach the user's group to the request object for downstream route handlers to use
|
||||
5. WHEN a Standard_User_Group user attempts to delete a resource they did not create, THE Dashboard SHALL return HTTP 403
|
||||
6. WHEN a Standard_User_Group user attempts to delete a finding that is marked as resolved or closed, THE Dashboard SHALL return HTTP 403
|
||||
7. WHEN a Standard_User_Group user attempts to delete a ticket that is linked to a compliance report, THE Dashboard SHALL return HTTP 403
|
||||
8. WHEN a Standard_User_Group user attempts to delete a CVE they created, THE Dashboard SHALL check for Cascade_Impact and return the list of associated Archer tickets, JIRA tickets, and documents
|
||||
9. IF any ticket in the Cascade_Impact is linked to a compliance report, THEN THE Dashboard SHALL block the CVE deletion and return HTTP 403 with a message indicating Admin-only deletion is required
|
||||
10. WHEN an Admin_Group user performs any CRUD operation, THE Dashboard SHALL allow the operation without ownership or state restrictions
|
||||
|
||||
### Requirement 4: Admin Group Permissions
|
||||
|
||||
**User Story:** As an admin, I want full unrestricted access to all resources and management functions, so that I can manage the entire system without limitations.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL allow Admin_Group users to create, read, update, and delete all resources (CVEs, findings, tickets, comments, compliance reports)
|
||||
2. THE Dashboard SHALL allow Admin_Group users to access the admin panel
|
||||
3. THE Dashboard SHALL allow Admin_Group users to manage users and assign users to groups
|
||||
4. THE Dashboard SHALL allow Admin_Group users to export all data
|
||||
5. THE Dashboard SHALL allow Admin_Group users to delete any resource regardless of ownership, state, or compliance linkage
|
||||
|
||||
### Requirement 5: Standard User Group Permissions
|
||||
|
||||
**User Story:** As a standard user, I want to view all data and create/edit resources while having controlled delete access, so that I can do my daily work without accidentally removing critical linked data.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL allow Standard_User_Group users to view all data across the dashboard
|
||||
2. THE Dashboard SHALL allow Standard_User_Group users to create and edit CVEs, findings, tickets, and comments
|
||||
3. THE Dashboard SHALL allow Standard_User_Group users to delete their own findings, tickets, and comments subject to state and linkage restrictions
|
||||
4. WHEN a Standard_User_Group user attempts to delete a finding that is resolved or closed, THE Dashboard SHALL reject the deletion
|
||||
5. WHEN a Standard_User_Group user attempts to delete a ticket linked to a compliance report, THE Dashboard SHALL reject the deletion
|
||||
6. WHEN a Standard_User_Group user attempts to delete a CVE they created, THE Dashboard SHALL display a warning listing associated Archer tickets, JIRA tickets, and documents that will be cascade-deleted
|
||||
7. IF any associated ticket in the cascade is linked to a compliance report, THEN THE Dashboard SHALL block the CVE deletion entirely
|
||||
8. THE Dashboard SHALL allow Standard_User_Group users to perform basic exports (CSV and XLSX of CVEs and findings)
|
||||
|
||||
### Requirement 6: Leadership Group Permissions
|
||||
|
||||
**User Story:** As a leadership user, I want read-only access with export capabilities, so that I can review data and generate reports without risk of modifying records.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL allow Leadership_Group users to view all data across the dashboard
|
||||
2. THE Dashboard SHALL allow Leadership_Group users to export reports, compliance documents, and graph visualizations
|
||||
3. THE Dashboard SHALL prevent Leadership_Group users from creating, editing, or deleting any records
|
||||
4. THE Dashboard SHALL prevent Leadership_Group users from accessing the admin panel
|
||||
|
||||
### Requirement 7: Read Only Group Permissions
|
||||
|
||||
**User Story:** As a read-only user, I want view-only access to the dashboard, so that I can see data without any ability to modify or export it.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL allow Read_Only_Group users to view all data across the dashboard
|
||||
2. THE Dashboard SHALL prevent Read_Only_Group users from creating, editing, or deleting any records
|
||||
3. THE Dashboard SHALL prevent Read_Only_Group users from exporting any data
|
||||
4. THE Dashboard SHALL prevent Read_Only_Group users from accessing the admin panel
|
||||
|
||||
### Requirement 8: Admin Panel Group Management
|
||||
|
||||
**User Story:** As an admin, I want to view all users with their current group and reassign groups through the admin panel, so that I can manage access control centrally.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN an Admin_Group user opens the user management section, THE Dashboard SHALL display all users with their current group assignment
|
||||
2. WHEN an Admin_Group user changes a user's group, THE Dashboard SHALL update the group assignment and persist it to the database
|
||||
3. WHEN an Admin_Group user changes a user's group, THE Dashboard SHALL display a confirmation dialog before applying the change
|
||||
4. WHEN an Admin_Group user downgrades another Admin_Group user, THE Dashboard SHALL display an additional warning in the confirmation dialog
|
||||
5. THE Dashboard SHALL prevent an Admin_Group user from changing their own group to a non-Admin group
|
||||
|
||||
### Requirement 9: Audit Logging for Group Changes
|
||||
|
||||
**User Story:** As a system administrator, I want all group assignment changes to be logged with full context, so that I can audit who changed access for whom and when.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. WHEN a user's group is changed, THE Dashboard SHALL log the change with the acting user's ID, the target user's ID, the previous group, the new group, and a timestamp
|
||||
2. THE Dashboard SHALL preserve existing audit trail behavior for all CRUD operations performed under the new group system
|
||||
3. WHEN a group change is logged, THE Dashboard SHALL record the IP address of the acting user
|
||||
|
||||
### Requirement 10: Frontend Conditional Rendering
|
||||
|
||||
**User Story:** As a user, I want the UI to show only the actions available to my group, so that I have a clear and uncluttered interface matching my permissions.
|
||||
|
||||
#### Acceptance Criteria
|
||||
|
||||
1. THE Dashboard SHALL conditionally render create, edit, and delete buttons based on the current user's group
|
||||
2. THE Dashboard SHALL conditionally render export options based on the current user's group
|
||||
3. THE Dashboard SHALL conditionally render the admin panel link based on the current user's group
|
||||
4. WHEN a Standard_User_Group user views a resource they did not create, THE Dashboard SHALL hide the delete button for that resource
|
||||
5. THE Dashboard SHALL replace the existing role-based helper functions (hasRole, canWrite, isAdmin) with group-based equivalents (isInGroup, canWrite, canDelete, canExport, isAdmin)
|
||||
279
.kiro/specs/group-based-access-control/tasks.md
Normal file
279
.kiro/specs/group-based-access-control/tasks.md
Normal file
@@ -0,0 +1,279 @@
|
||||
# Implementation Plan: Group-Based Access Control
|
||||
|
||||
## Overview
|
||||
|
||||
Replace the existing role-based access control (admin/editor/viewer) with a four-group model (Admin, Standard_User, Leadership, Read_Only). This touches the database schema, backend middleware, all route authorization, frontend permission helpers, and the admin panel UI. Tasks build incrementally: migration first, then middleware, then routes, then frontend.
|
||||
|
||||
## Tasks
|
||||
|
||||
- [ ] 1. Create database migration for user groups
|
||||
- [x] 1.1 Create `backend/migrations/add_user_groups.js` migration script
|
||||
- Add `user_group` column (VARCHAR(20), NOT NULL, DEFAULT 'Read_Only') to users table
|
||||
- Map existing role values: admin to Admin, editor to Standard_User, viewer to Read_Only
|
||||
- Map NULL or unrecognized role values to Read_Only
|
||||
- Add CHECK constraint: user_group IN ('Admin', 'Standard_User', 'Leadership', 'Read_Only')
|
||||
- Add index `idx_users_user_group` on user_group column
|
||||
- Use idempotent checks so migration is safe to run multiple times
|
||||
- Follow existing migration pattern: open db, db.serialize(), log progress, close db
|
||||
- _Requirements: 1.1, 1.2, 1.3, 1.4, 2.1, 2.2, 2.3, 2.4, 2.5_
|
||||
|
||||
- [ ]* 1.2 Write property test for migration role mapping
|
||||
- **Property 8: Migration maps all role values correctly**
|
||||
- Generate users with random roles from {admin, editor, viewer, NULL, arbitrary}, run migration against in-memory SQLite, verify mapping
|
||||
- **Validates: Requirements 2.1, 2.2, 2.3, 2.5**
|
||||
|
||||
- [ ]* 1.3 Write property test for migration idempotency
|
||||
- **Property 9: Migration is idempotent**
|
||||
- Run migration N times (N in 1-5) against in-memory SQLite, verify schema and data identical each time
|
||||
- **Validates: Requirements 2.4**
|
||||
|
||||
- [ ] 1.4 Write unit tests for migration
|
||||
- Test column creation with correct CHECK constraint
|
||||
- Test role mapping: admin to Admin, editor to Standard_User, viewer to Read_Only
|
||||
- Test NULL and unrecognized role handling defaults to Read_Only
|
||||
- Test new user defaults to Read_Only group
|
||||
- _Requirements: 1.3, 1.4, 2.1, 2.2, 2.3, 2.5_
|
||||
|
||||
- [ ] 2. Update auth middleware to use groups
|
||||
- [x] 2.1 Update `requireAuth` in `backend/middleware/auth.js`
|
||||
- Modify session join query to SELECT user_group and attach as req.user.group
|
||||
- _Requirements: 3.4_
|
||||
|
||||
- [x] 2.2 Add `requireGroup` middleware function
|
||||
- Accept spread of allowed group names
|
||||
- Return 401 if req.user is missing
|
||||
- Return 403 with error details if user group not in allowed set
|
||||
- Call next() if group is allowed
|
||||
- _Requirements: 3.1, 3.2, 3.3_
|
||||
|
||||
- [x] 2.3 Remove `requireRole` and export `requireGroup`
|
||||
- Remove requireRole function and its export
|
||||
- Export requireGroup in its place
|
||||
- _Requirements: 3.1_
|
||||
|
||||
- [ ]* 2.4 Write property test for group constraint
|
||||
- **Property 1: Group constraint rejects invalid values**
|
||||
- Generate random strings not in valid group set, attempt DB insert, verify constraint error
|
||||
- **Validates: Requirements 1.1, 1.4**
|
||||
|
||||
- [ ]* 2.5 Write property test for requireGroup
|
||||
- **Property 3: requireGroup rejects unauthorized groups**
|
||||
- Generate random group and allowedGroups pairs where group is not in allowed set, verify 403
|
||||
- **Validates: Requirements 3.3**
|
||||
|
||||
- [ ] 2.6 Write unit tests for requireGroup middleware
|
||||
- Test 401 for unauthenticated requests
|
||||
- Test 403 for wrong group
|
||||
- Test group attached to req.user
|
||||
- Test next() called for allowed group
|
||||
- _Requirements: 3.2, 3.3, 3.4_
|
||||
|
||||
- [x] 3. Checkpoint: Verify migration and middleware
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
- [ ] 4. Update auth routes to return group
|
||||
- [x] 4.1 Update login endpoint in `backend/routes/auth.js`
|
||||
- Return group (from user_group) instead of role in user response object
|
||||
- Update audit log details to log group instead of role
|
||||
- _Requirements: 3.4, 9.2_
|
||||
|
||||
- [x] 4.2 Update me endpoint in `backend/routes/auth.js`
|
||||
- Return group instead of role in user response object
|
||||
- _Requirements: 3.4_
|
||||
|
||||
- [ ] 5. Update user management routes
|
||||
- [x] 5.1 Switch `backend/routes/users.js` to use requireGroup
|
||||
- Replace requireRole('admin') with requireGroup('Admin')
|
||||
- _Requirements: 4.2, 4.3_
|
||||
|
||||
- [x] 5.2 Update GET endpoints to return user_group
|
||||
- Return user_group instead of role in user records
|
||||
- _Requirements: 8.1_
|
||||
|
||||
- [x] 5.3 Update POST create user to accept group param
|
||||
- Validate group against valid values
|
||||
- Default to Read_Only if not provided
|
||||
- Return 400 for invalid group values
|
||||
- _Requirements: 1.3, 8.2_
|
||||
|
||||
- [x] 5.4 Update PATCH update user to accept group param
|
||||
- Validate group against valid values
|
||||
- Prevent admin self-demotion (return 400)
|
||||
- _Requirements: 8.2, 8.5_
|
||||
|
||||
- [x] 5.5 Add audit logging for group changes
|
||||
- Log acting user ID, target user ID, previous group, new group, IP address, timestamp
|
||||
- _Requirements: 9.1, 9.3_
|
||||
|
||||
- [ ]* 5.6 Write property test for user group validity
|
||||
- **Property 2: Every user has exactly one valid group**
|
||||
- Generate random user sets, query all users, verify each has exactly one valid group
|
||||
- **Validates: Requirements 1.2**
|
||||
|
||||
- [ ] 5.7 Write unit tests for user management group logic
|
||||
- Test group validation rejects invalid values
|
||||
- Test self-demotion prevention
|
||||
- Test audit logging includes all required fields
|
||||
- _Requirements: 8.2, 8.5, 9.1, 9.3_
|
||||
|
||||
- [ ] 6. Update backend route authorization across all routes
|
||||
- [x] 6.1 Update `backend/routes/auditLog.js`
|
||||
- Replace requireRole('admin') with requireGroup('Admin')
|
||||
- _Requirements: 4.2_
|
||||
|
||||
- [x] 6.2 Update `backend/routes/archerTickets.js`
|
||||
- Use requireGroup('Admin', 'Standard_User') for create, update, delete
|
||||
- _Requirements: 5.2_
|
||||
|
||||
- [x] 6.3 Update `backend/routes/knowledgeBase.js`
|
||||
- Use requireGroup('Admin', 'Standard_User') for upload and delete
|
||||
- _Requirements: 5.2_
|
||||
|
||||
- [x] 6.4 Update `backend/routes/ivantiFindings.js`
|
||||
- Use requireGroup('Admin', 'Standard_User') for override endpoint
|
||||
- _Requirements: 5.2_
|
||||
|
||||
- [x] 6.5 Update `backend/routes/compliance.js`
|
||||
- Use requireGroup('Admin', 'Standard_User') for preview and commit
|
||||
- _Requirements: 5.2_
|
||||
|
||||
- [x] 6.6 Update `backend/server.js` inline CVE routes
|
||||
- Use requireGroup('Admin', 'Standard_User') for POST, PUT, PATCH, DELETE
|
||||
- _Requirements: 5.2_
|
||||
|
||||
- [x] 6.7 Update `backend/server.js` route mounting
|
||||
- Pass requireGroup instead of requireRole to route factories
|
||||
- _Requirements: 3.1_
|
||||
|
||||
- [ ]* 6.8 Write property test for Leadership restrictions
|
||||
- **Property 5: Leadership cannot mutate any resource**
|
||||
- Generate random mutation requests as Leadership, verify 403
|
||||
- **Validates: Requirements 6.3**
|
||||
|
||||
- [ ]* 6.9 Write property test for Read_Only restrictions
|
||||
- **Property 6: Read_Only cannot mutate or export**
|
||||
- Generate random mutation and export requests as Read_Only, verify 403
|
||||
- **Validates: Requirements 7.2, 7.3**
|
||||
|
||||
- [x] 7. Checkpoint: Verify backend route authorization
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
- [ ] 8. Implement Standard User conditional delete logic
|
||||
- [x] 8.1 Add created_by column tracking
|
||||
- Add created_by to CVE, finding, and ticket creation endpoints storing req.user.id on insert
|
||||
- _Requirements: 3.5_
|
||||
|
||||
- [x] 8.2 Implement ownership check for CVE delete
|
||||
- Standard_User can only delete CVEs they created
|
||||
- Return 403 if not owner
|
||||
- _Requirements: 3.5_
|
||||
|
||||
- [x] 8.3 Implement cascade impact check for CVE delete
|
||||
- Query associated Archer tickets and documents
|
||||
- Check compliance linkage on cascaded tickets
|
||||
- Return cascade_impact response schema
|
||||
- Block deletion if any cascaded ticket is compliance-linked
|
||||
- _Requirements: 3.8, 3.9_
|
||||
|
||||
- [x] 8.4 Implement state check for finding delete
|
||||
- Standard_User cannot delete resolved or closed findings
|
||||
- Return 403 with appropriate error message
|
||||
- _Requirements: 3.6_
|
||||
|
||||
- [x] 8.5 Implement compliance linkage check for ticket delete
|
||||
- Standard_User cannot delete tickets linked to compliance reports
|
||||
- Return 403 with appropriate error message
|
||||
- _Requirements: 3.7_
|
||||
|
||||
- [x] 8.6 Ensure Admin bypasses all delete restrictions
|
||||
- Admin group skips ownership, state, and compliance checks
|
||||
- _Requirements: 3.10, 4.5_
|
||||
|
||||
- [ ]* 8.7 Write property test for Admin delete bypass
|
||||
- **Property 4: Admin bypasses all delete restrictions**
|
||||
- Generate resources with random ownership, state, compliance linkage, delete as Admin, verify success
|
||||
- **Validates: Requirements 3.10, 4.1, 4.5**
|
||||
|
||||
- [ ] 8.8 Write unit tests for conditional delete logic
|
||||
- Test ownership rejection for non-owner
|
||||
- Test state rejection for resolved/closed findings
|
||||
- Test compliance linkage rejection
|
||||
- Test cascade impact response format
|
||||
- Test Admin bypass of all restrictions
|
||||
- _Requirements: 3.5, 3.6, 3.7, 3.8, 3.9, 3.10_
|
||||
|
||||
- [x] 9. Checkpoint: Verify conditional delete logic
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
- [ ] 10. Update frontend AuthContext with group helpers
|
||||
- [x] 10.1 Update `frontend/src/contexts/AuthContext.js`
|
||||
- Read group from user object instead of role
|
||||
- Replace hasRole with isInGroup(...groups) helper
|
||||
- Update canWrite to check isInGroup('Admin', 'Standard_User')
|
||||
- Add canDelete(resource) helper: Admin always true, Standard_User only if owns resource, others false
|
||||
- Add canExport() helper: true for Admin, Standard_User, Leadership
|
||||
- Update isAdmin() to check isInGroup('Admin')
|
||||
- _Requirements: 10.1, 10.2, 10.3, 10.4, 10.5_
|
||||
|
||||
- [ ]* 10.2 Write property test for permission helpers
|
||||
- **Property 7: Group permission helpers are consistent with group matrix**
|
||||
- Generate all valid group values, call each helper, verify against permission matrix
|
||||
- **Validates: Requirements 10.5**
|
||||
|
||||
- [ ] 11. Update frontend UI for group-based rendering
|
||||
- [x] 11.1 Update `App.js` conditional rendering
|
||||
- Use canWrite, canDelete, canExport, isAdmin for button and link visibility
|
||||
- _Requirements: 10.1, 10.2, 10.3_
|
||||
|
||||
- [x] 11.2 Update `NavDrawer.js`
|
||||
- Show admin panel link only when isAdmin() is true
|
||||
- _Requirements: 10.3_
|
||||
|
||||
- [x] 11.3 Update `UserMenu.js`
|
||||
- Display user group instead of role
|
||||
- _Requirements: 10.1_
|
||||
|
||||
- [x] 11.4 Update all components using hasRole or canWrite
|
||||
- Replace with new group-based helpers throughout components
|
||||
- _Requirements: 10.5_
|
||||
|
||||
- [x] 11.5 Hide delete buttons for non-owned resources
|
||||
- Standard_User sees delete only on resources they created
|
||||
- _Requirements: 10.4_
|
||||
|
||||
- [ ] 12. Update User Management UI
|
||||
- [x] 12.1 Replace role dropdown with group dropdown in `UserManagement.js`
|
||||
- Options: Admin, Standard_User, Leadership, Read_Only
|
||||
- _Requirements: 8.1, 8.2_
|
||||
|
||||
- [x] 12.2 Update form data and API calls to use group field
|
||||
- Send group instead of role in create and update requests
|
||||
- _Requirements: 8.2_
|
||||
|
||||
- [x] 12.3 Add confirmation dialog for group changes
|
||||
- Show confirmation before applying any group change
|
||||
- _Requirements: 8.3_
|
||||
|
||||
- [x] 12.4 Add extra warning when downgrading Admin
|
||||
- Show additional warning in confirmation dialog
|
||||
- _Requirements: 8.4_
|
||||
|
||||
- [x] 12.5 Prevent admin self-demotion in UI
|
||||
- Disable group change dropdown for current user if Admin
|
||||
- _Requirements: 8.5_
|
||||
|
||||
- [x] 12.6 Update user table to show group badges
|
||||
- Display group badge with appropriate colors instead of role badge
|
||||
- _Requirements: 8.1_
|
||||
|
||||
- [x] 13. Final checkpoint: Verify full integration
|
||||
- Ensure all tests pass, ask the user if questions arise.
|
||||
|
||||
## Notes
|
||||
|
||||
- Tasks marked with `*` are optional and can be skipped for faster MVP
|
||||
- Each task references specific requirements for traceability
|
||||
- Checkpoints ensure incremental validation
|
||||
- Property tests use `fast-check` library with minimum 100 iterations per test
|
||||
- All backend code uses callback-based SQLite API wrapped in promises (matching existing patterns)
|
||||
- All frontend code uses plain JavaScript (no TypeScript)
|
||||
27
.kiro/steering/product.md
Normal file
27
.kiro/steering/product.md
Normal file
@@ -0,0 +1,27 @@
|
||||
# Product Overview
|
||||
|
||||
The STEAM Security Dashboard is a self-hosted vulnerability management tool for the NTS-AEO-STEAM and NTS-AEO-ACCESS-ENG business units. It centralizes CVE tracking, Ivanti host finding triage, AEO compliance posture monitoring, FP/Archer exception workflows, and internal documentation in a single interface.
|
||||
|
||||
## Core Capabilities
|
||||
|
||||
- Searchable CVE list with per-vendor tracking and document storage
|
||||
- NVD API integration for auto-populating CVE metadata
|
||||
- Ivanti/RiskSense integration for syncing open host findings with FP workflow tracking
|
||||
- Reporting page with charts, advanced filtering, inline editing, and CSV/XLSX export
|
||||
- Ivanti Queue for batch-processing FP, Archer, and CARD workflows
|
||||
- AEO Compliance page with weekly xlsx upload, diff preview, per-team metric health cards, and device-level violation tracking
|
||||
- Archer risk acceptance ticket tracking (EXC numbers) linked to CVE/vendor pairs
|
||||
- Knowledge base for internal documentation and policies
|
||||
- Role-based access control (viewer, editor, admin) with full audit trail
|
||||
|
||||
## User Roles
|
||||
|
||||
| Role | Permissions |
|
||||
|------|------------|
|
||||
| viewer | Read-only access to all data |
|
||||
| editor | All viewer permissions plus create/update operations |
|
||||
| admin | All editor permissions plus delete, user management, and audit log access |
|
||||
|
||||
## Teams Tracked
|
||||
|
||||
Only **STEAM** and **ACCESS-ENG** teams are tracked in the compliance module.
|
||||
83
.kiro/steering/structure.md
Normal file
83
.kiro/steering/structure.md
Normal file
@@ -0,0 +1,83 @@
|
||||
# Project Structure & Conventions
|
||||
|
||||
## Directory Layout
|
||||
|
||||
```
|
||||
cve-dashboard/
|
||||
├── backend/ # Express API server
|
||||
│ ├── server.js # Main entry point — app setup, middleware, CVE/document routes inline
|
||||
│ ├── setup.js # One-time DB init + default admin creation
|
||||
│ ├── cve_database.db # SQLite database (gitignored)
|
||||
│ ├── uploads/ # File storage (gitignored)
|
||||
│ ├── routes/ # Express route modules (factory pattern)
|
||||
│ │ ├── auth.js
|
||||
│ │ ├── users.js
|
||||
│ │ ├── auditLog.js
|
||||
│ │ ├── nvdLookup.js
|
||||
│ │ ├── knowledgeBase.js
|
||||
│ │ ├── archerTickets.js
|
||||
│ │ ├── ivantiWorkflows.js
|
||||
│ │ ├── ivantiFindings.js
|
||||
│ │ ├── ivantiTodoQueue.js
|
||||
│ │ └── compliance.js
|
||||
│ ├── middleware/
|
||||
│ │ └── auth.js # requireAuth(db), requireRole(...roles)
|
||||
│ ├── helpers/
|
||||
│ │ └── auditLog.js # logAudit() — fire-and-forget DB insert
|
||||
│ ├── migrations/ # Sequential migration scripts (run manually with node)
|
||||
│ └── scripts/ # Python utilities (compliance parsing, CSV import)
|
||||
│
|
||||
├── frontend/ # React 19 SPA (Create React App)
|
||||
│ └── src/
|
||||
│ ├── App.js # Main dashboard — CVE list, filters, modals, inline styles
|
||||
│ ├── App.css # Global styles and CSS variables
|
||||
│ ├── contexts/
|
||||
│ │ └── AuthContext.js # Auth state provider (login, logout, role helpers)
|
||||
│ └── components/
|
||||
│ ├── LoginForm.js
|
||||
│ ├── NavDrawer.js
|
||||
│ ├── UserMenu.js
|
||||
│ ├── CalendarWidget.js
|
||||
│ ├── UserManagement.js
|
||||
│ ├── AuditLog.js
|
||||
│ ├── NvdSyncModal.js
|
||||
│ ├── KnowledgeBaseModal.js
|
||||
│ ├── KnowledgeBaseViewer.js
|
||||
│ └── pages/ # Full-page views
|
||||
│ ├── ReportingPage.js
|
||||
│ ├── CompliancePage.js
|
||||
│ ├── ComplianceUploadModal.js
|
||||
│ ├── ComplianceDetailPanel.js
|
||||
│ ├── ComplianceChartsPanel.js
|
||||
│ ├── IvantiCountsChart.js
|
||||
│ ├── KnowledgeBasePage.js
|
||||
│ └── ExportsPage.js
|
||||
│
|
||||
├── docs/ # Internal documentation (markdown)
|
||||
├── start-servers.sh # Start both servers in background
|
||||
├── stop-servers.sh # Stop both servers
|
||||
└── DESIGN_SYSTEM.md # UI design system reference (colors, typography, components)
|
||||
```
|
||||
|
||||
## Backend Conventions
|
||||
|
||||
- Route modules export a factory function: `function createXxxRouter(db, ...middleware)` that returns an Express Router.
|
||||
- The `db` (sqlite3 Database instance) is passed via dependency injection from `server.js`.
|
||||
- Auth middleware: `requireAuth(db)` validates session cookie, attaches `req.user`. `requireRole('editor', 'admin')` checks role.
|
||||
- All state-changing actions call `logAudit(db, { userId, username, action, entityType, entityId, details, ipAddress })`.
|
||||
- Input validation is done inline in route handlers with early-return error responses.
|
||||
- SQLite queries use the callback-based `db.run()`, `db.get()`, `db.all()` API.
|
||||
- API routes are prefixed with `/api`. All endpoints except login/logout require a valid session cookie.
|
||||
- CVE and document routes are defined inline in `server.js`; feature routes are in separate modules under `routes/`.
|
||||
|
||||
## Frontend Conventions
|
||||
|
||||
- Single-page app with page-level navigation managed in `App.js` (no React Router).
|
||||
- Auth state managed via React Context (`AuthContext`). Use `useAuth()` hook for login/logout/role checks.
|
||||
- API calls use `fetch()` with `credentials: 'include'` for cookie-based auth.
|
||||
- API base URL from `process.env.REACT_APP_API_BASE`.
|
||||
- Styling uses a mix of inline style objects (defined as constants in component files) and `App.css` global styles.
|
||||
- Dark theme with a "tactical intelligence" aesthetic — see `DESIGN_SYSTEM.md` for color palette, typography, and component specs.
|
||||
- Icons from `lucide-react`. Charts from `recharts`.
|
||||
- Page components live in `components/pages/`. Shared components live in `components/`.
|
||||
- No TypeScript — the project uses plain JavaScript throughout.
|
||||
78
.kiro/steering/tech.md
Normal file
78
.kiro/steering/tech.md
Normal file
@@ -0,0 +1,78 @@
|
||||
# Tech Stack & Build System
|
||||
|
||||
## Stack
|
||||
|
||||
| Layer | Technology |
|
||||
|-------|-----------|
|
||||
| Backend | Node.js 18+, Express 5 |
|
||||
| Database | SQLite3 (file: `backend/cve_database.db`) |
|
||||
| Auth | bcryptjs, cookie-based sessions (httpOnly, 24h expiry) |
|
||||
| File uploads | Multer 2 (10MB limit) |
|
||||
| Frontend | React 19 (Create React App / react-scripts 5) |
|
||||
| UI Icons | lucide-react |
|
||||
| Charts | recharts |
|
||||
| Spreadsheet parsing | xlsx (frontend), pandas + openpyxl (backend Python scripts) |
|
||||
| Markdown rendering | react-markdown |
|
||||
| Diagrams | mermaid |
|
||||
|
||||
## Common Commands
|
||||
|
||||
### Backend
|
||||
```bash
|
||||
cd backend
|
||||
node setup.js # Initialize DB, tables, indexes, default admin user
|
||||
node server.js # Start backend on port 3001
|
||||
```
|
||||
|
||||
### Frontend
|
||||
```bash
|
||||
cd frontend
|
||||
npm install # Install dependencies
|
||||
npm start # Dev server on port 3000
|
||||
npm run build # Production build
|
||||
npm test # Run tests (react-scripts test)
|
||||
```
|
||||
|
||||
### Both servers (from project root)
|
||||
```bash
|
||||
./start-servers.sh # Start backend + frontend in background
|
||||
./stop-servers.sh # Stop all servers
|
||||
```
|
||||
|
||||
### Database Migrations (run from `backend/` in order)
|
||||
```bash
|
||||
node migrations/add_knowledge_base_table.js
|
||||
node migrations/add_archer_tickets_table.js
|
||||
node migrations/add_ivanti_sync_table.js
|
||||
node migrations/add_ivanti_findings_tables.js
|
||||
node migrations/add_ivanti_todo_queue_table.js
|
||||
node migrations/add_card_workflow_type.js
|
||||
node migrations/add_todo_queue_ip_address.js
|
||||
node migrations/add_compliance_tables.js
|
||||
```
|
||||
|
||||
### Python Scripts (from `backend/scripts/`)
|
||||
```bash
|
||||
# Compliance xlsx parsing (called automatically by upload flow)
|
||||
python3 parse_compliance_xlsx.py <file>
|
||||
|
||||
# Bulk notes import
|
||||
python3 import_notes_from_csv.py input.csv --dry-run
|
||||
python3 import_notes_from_csv.py input.csv
|
||||
```
|
||||
|
||||
Python dependencies: `pandas>=2.0.0`, `openpyxl>=3.0.0` (install via apt or venv).
|
||||
|
||||
## Environment Configuration
|
||||
|
||||
- `backend/.env` — PORT, CORS_ORIGINS, SESSION_SECRET, NVD_API_KEY, Ivanti API credentials
|
||||
- `frontend/.env` — REACT_APP_API_BASE, REACT_APP_API_HOST
|
||||
- Both `.env` files are gitignored; see `.env.example` files for templates.
|
||||
- React caches env vars at build/start time — restart the frontend process after changes.
|
||||
|
||||
## Default Ports
|
||||
|
||||
| Service | URL |
|
||||
|---------|-----|
|
||||
| Frontend | http://localhost:3000 |
|
||||
| Backend API | http://localhost:3001 |
|
||||
451
README.md
451
README.md
@@ -13,7 +13,7 @@ A self-hosted vulnerability management dashboard for the NTS-AEO-STEAM and NTS-A
|
||||
- [Configuration](#configuration)
|
||||
- [Running the Application](#running-the-application)
|
||||
- [Features](#features)
|
||||
- [Authentication and User Roles](#authentication-and-user-roles)
|
||||
- [Authentication and User Groups](#authentication-and-user-groups)
|
||||
- [Home — CVE Management](#home--cve-management)
|
||||
- [Reporting — Host Findings](#reporting--host-findings)
|
||||
- [Ivanti Queue](#ivanti-queue)
|
||||
@@ -28,7 +28,9 @@ A self-hosted vulnerability management dashboard for the NTS-AEO-STEAM and NTS-A
|
||||
- [Architecture](#architecture)
|
||||
- [Database Schema](#database-schema)
|
||||
- [Security Model](#security-model)
|
||||
- [Upgrading an Existing Deployment](#upgrading-an-existing-deployment)
|
||||
- [Migrations](#migrations)
|
||||
- [Troubleshooting](#troubleshooting)
|
||||
|
||||
---
|
||||
|
||||
@@ -46,7 +48,7 @@ The application provides:
|
||||
- **AEO Compliance page** — weekly xlsx upload, diff preview, per-team metric health cards, device-level violation tracking with notes history
|
||||
- Archer risk acceptance ticket tracking (EXC numbers) linked to CVE/vendor pairs
|
||||
- A knowledge base for internal documentation and policies
|
||||
- Role-based access control with a full audit trail
|
||||
- Group-based access control (Admin, Standard_User, Leadership, Read_Only) with a full audit trail
|
||||
|
||||
---
|
||||
|
||||
@@ -54,11 +56,11 @@ The application provides:
|
||||
|
||||
| Layer | Technology |
|
||||
|---|---|
|
||||
| Backend | Node.js, Express 5 |
|
||||
| Backend | Node.js 18+, Express 5 |
|
||||
| Database | SQLite3 |
|
||||
| File uploads | Multer 2 |
|
||||
| Auth | bcryptjs, cookie-based sessions |
|
||||
| Frontend | React 19, lucide-react, xlsx |
|
||||
| Auth | bcryptjs, cookie-based sessions, express-rate-limit |
|
||||
| Frontend | React 19, lucide-react, xlsx, rehype-sanitize |
|
||||
| Compliance xlsx parsing | Python 3, pandas, openpyxl |
|
||||
| Bulk notes import | Python 3 (stdlib only) |
|
||||
|
||||
@@ -84,7 +86,6 @@ cd cve-dashboard
|
||||
### 2. Install backend dependencies
|
||||
|
||||
```bash
|
||||
cd backend
|
||||
npm install
|
||||
```
|
||||
|
||||
@@ -107,7 +108,20 @@ apt install -y python3-pandas python3-openpyxl
|
||||
|
||||
> The bulk notes import script (`import_notes_from_csv.py`) uses only Python stdlib and does **not** require these packages.
|
||||
|
||||
### 5. Initialize the database
|
||||
### 5. Configure environment variables
|
||||
|
||||
Create `backend/.env` — the server will refuse to start without `SESSION_SECRET`:
|
||||
|
||||
```bash
|
||||
cd backend
|
||||
cp .env.example .env
|
||||
# Edit .env and set SESSION_SECRET to a random string:
|
||||
# openssl rand -base64 32
|
||||
```
|
||||
|
||||
See [Configuration](#configuration) for all available options.
|
||||
|
||||
### 6. Initialize the database
|
||||
|
||||
Run once from the `backend/` directory to create the SQLite database, all tables, indexes, and a default admin user:
|
||||
|
||||
@@ -116,13 +130,9 @@ cd backend
|
||||
node setup.js
|
||||
```
|
||||
|
||||
This creates `backend/cve_database.db` and a default admin account:
|
||||
- Username: `admin`
|
||||
- Password: `admin123`
|
||||
This creates `backend/cve_database.db` and generates a random admin password printed to stdout. **Save the password — it is only shown once.**
|
||||
|
||||
**Change the admin password immediately after first login.**
|
||||
|
||||
### 6. Run database migrations
|
||||
### 7. Run database migrations
|
||||
|
||||
Apply all feature migrations in order:
|
||||
|
||||
@@ -136,9 +146,14 @@ node migrations/add_ivanti_todo_queue_table.js
|
||||
node migrations/add_card_workflow_type.js
|
||||
node migrations/add_todo_queue_ip_address.js
|
||||
node migrations/add_compliance_tables.js
|
||||
node migrations/add_finding_archive_tables.js
|
||||
node migrations/add_archer_tickets_timestamps.js
|
||||
node migrations/add_ivanti_counts_history_table.js
|
||||
node migrations/add_user_groups.js
|
||||
node migrations/add_created_by_columns.js
|
||||
```
|
||||
|
||||
### 7. Build the frontend
|
||||
### 8. Build the frontend
|
||||
|
||||
```bash
|
||||
cd frontend
|
||||
@@ -159,8 +174,8 @@ The application is configured via `.env` files. These files are gitignored and m
|
||||
PORT=3001
|
||||
API_HOST=localhost
|
||||
CORS_ORIGINS=http://YOUR_IP:3000
|
||||
SESSION_SECRET=change-this-to-a-long-random-string
|
||||
NODE_ENV=production
|
||||
SESSION_SECRET=<generate with: openssl rand -base64 32>
|
||||
# NODE_ENV=production — see note below
|
||||
|
||||
# Optional: NVD API key for higher rate limits (50 req/30s vs 5 req/30s)
|
||||
# Register at https://nvd.nist.gov/developers/request-an-api-key
|
||||
@@ -176,6 +191,10 @@ IVANTI_LAST_NAME=
|
||||
IVANTI_SKIP_TLS=false
|
||||
```
|
||||
|
||||
**`SESSION_SECRET` is required.** The server will exit on startup if it is not set. Generate one with `openssl rand -base64 32`.
|
||||
|
||||
**`NODE_ENV` and the Secure cookie flag:** When `NODE_ENV=production`, session cookies are set with the `Secure` flag, which means the browser will only send them over HTTPS connections. If you are running the application over plain HTTP (no TLS/SSL), you **must** leave `NODE_ENV` unset or set it to `development` — otherwise login will succeed but every subsequent API request will return 401 because the browser silently drops the cookie. Only set `NODE_ENV=production` when the application is served behind HTTPS (e.g., via a reverse proxy with TLS termination).
|
||||
|
||||
### Frontend: `frontend/.env`
|
||||
|
||||
```env
|
||||
@@ -225,17 +244,26 @@ npm start
|
||||
|
||||
## Features
|
||||
|
||||
### Authentication and User Roles
|
||||
### Authentication and User Groups
|
||||
|
||||
All routes require authentication. Three roles are supported:
|
||||
All routes require authentication. Four user groups are supported:
|
||||
|
||||
| Role | Permissions |
|
||||
| Group | Permissions |
|
||||
|---|---|
|
||||
| `viewer` | Read-only: CVEs, documents, findings, reports, knowledge base, Archer tickets, compliance data |
|
||||
| `editor` | All viewer permissions plus: create/update CVEs, upload documents, sync Ivanti findings, save notes and overrides, manage knowledge base, manage Archer tickets, upload compliance reports, manage Ivanti Queue |
|
||||
| `admin` | All editor permissions plus: delete documents, delete reports, manage users, view audit logs |
|
||||
| `Admin` | Full CRUD on all resources, user management, audit log access, export all data, delete any resource regardless of ownership |
|
||||
| `Standard_User` | View all data, create and edit resources, delete own resources (with state and compliance restrictions), basic export (CSV/XLSX) |
|
||||
| `Leadership` | View all data, export reports/compliance/visualizations, no create/edit/delete |
|
||||
| `Read_Only` | View all data only — no create, edit, delete, or export |
|
||||
|
||||
Sessions expire after 24 hours. Session tokens are stored in `httpOnly` cookies.
|
||||
**Standard User delete restrictions:**
|
||||
- Can only delete resources they created (`created_by` ownership check)
|
||||
- Cannot delete findings marked as resolved or closed
|
||||
- Cannot delete tickets linked to compliance reports
|
||||
- CVE deletion triggers a cascade impact check — if any associated Archer or JIRA ticket is compliance-linked, deletion is blocked and requires Admin intervention
|
||||
|
||||
Sessions expire after 24 hours. Session tokens are stored in `httpOnly` cookies. Login is rate-limited to 20 attempts per 15-minute window.
|
||||
|
||||
**Migration from legacy roles:** The `add_user_groups.js` migration automatically maps existing users: `admin` → `Admin`, `editor` → `Standard_User`, `viewer` → `Read_Only`. Unrecognized or NULL roles default to `Read_Only`.
|
||||
|
||||
---
|
||||
|
||||
@@ -249,11 +277,11 @@ The home page is the primary CVE research and tracking tool.
|
||||
- Color-coded severity badges: Critical (red), High (amber), Medium (sky blue), Low (green)
|
||||
- Paginated list view
|
||||
|
||||
**CVE Operations (editor/admin)**
|
||||
**CVE Operations (Admin/Standard_User)**
|
||||
- Add a new CVE entry — NVD auto-fill populates description, severity, and published date automatically
|
||||
- Edit any field on an existing CVE entry
|
||||
- Update status for all vendor rows matching a CVE ID in one click
|
||||
- Delete a single vendor entry or all vendor entries for a CVE ID
|
||||
- Delete a single vendor entry or all vendor entries for a CVE ID (ownership restrictions apply for Standard_User)
|
||||
- The same CVE ID can be tracked across multiple vendors independently
|
||||
|
||||
**Document Management**
|
||||
@@ -265,7 +293,7 @@ The home page is the primary CVE research and tracking tool.
|
||||
|
||||
**NVD Integration**
|
||||
- Auto-fill CVE description, severity, and published date from the NIST NVD API 2.0 when adding a new CVE
|
||||
- Bulk NVD Sync (editor/admin): fetch updated metadata for all CVEs in the database in one operation
|
||||
- Bulk NVD Sync (Admin/Standard_User): fetch updated metadata for all CVEs in the database in one operation
|
||||
- CVSS severity cascade: v3.1 preferred, then v3.0, then v2.0
|
||||
- Rate-limit aware: respects NVD's 5 req/30s unauthenticated limit; with `NVD_API_KEY` the limit increases to 50 req/30s
|
||||
|
||||
@@ -285,7 +313,7 @@ The Reporting page is the core operational view for remediation tracking. It int
|
||||
|
||||
#### Syncing Data
|
||||
|
||||
Click **Sync** (top right) to pull the latest findings from Ivanti. The sync:
|
||||
Click **Sync** (top right) to pull the latest findings from Ivanti. Sync requires Admin or Standard_User group. The sync:
|
||||
1. Fetches all open host findings matching your BU filters and severity range (8.5–9.9 VRR)
|
||||
2. Fetches the closed finding count separately
|
||||
3. Sweeps closed findings to capture FP workflow states (including Approved FPs now closed)
|
||||
@@ -324,19 +352,19 @@ Each row represents a single Ivanti host finding.
|
||||
| Last Found | Last detection date from Ivanti |
|
||||
| Notes | Free-form notes — inline editable, persists across syncs |
|
||||
|
||||
**Inline editing:** Click a Host or DNS cell to override the Ivanti value. An amber dot (●) marks overridden cells; use the revert button (↻) to restore the original. Overrides survive re-syncs.
|
||||
**Inline editing:** Click a Host or DNS cell to override the Ivanti value. An amber dot (●) marks overridden cells; use the revert button (↻) to restore the original. Overrides survive re-syncs. Requires Admin or Standard_User group.
|
||||
|
||||
**Filtering:** Click ⊙ on any column header for multi-select filtering. The `— empty —` option filters to findings with no value in that column. Multiple filters are ANDed. The Action Coverage chart also acts as a filter.
|
||||
|
||||
**Column management:** Toggle visibility and drag to reorder via the **Columns** button. Order and visibility persist to `localStorage`.
|
||||
|
||||
**Export:** Click **Export** to download the current filtered view as CSV or XLSX.
|
||||
**Export:** Click **Export** to download the current filtered view as CSV or XLSX. Requires Admin, Standard_User, or Leadership group.
|
||||
|
||||
---
|
||||
|
||||
### Ivanti Queue
|
||||
|
||||
A personal staging list for batch-processing FP, Archer, and CARD workflows without context-switching into Ivanti mid-review.
|
||||
A personal staging list for batch-processing FP, Archer, and CARD workflows without context-switching into Ivanti mid-review. Requires Admin or Standard_User group.
|
||||
|
||||
**Adding items:** Check the checkbox at the far left of any finding row. A popover appears:
|
||||
- For **FP** and **Archer** items: enter the Vendor / Platform (e.g., "Juniper MX", "Cisco IOS-XE")
|
||||
@@ -364,7 +392,7 @@ The Compliance page tracks NTS-AEO team posture against the AEO compliance frame
|
||||
|
||||
#### Upload Workflow
|
||||
|
||||
Editors and admins can upload a new compliance report via the **Upload Report** button:
|
||||
Admin and Standard_User groups can upload a new compliance report via the **Upload Report** button:
|
||||
|
||||
1. Drop or browse for the `NTS_AEO_YYYY_MM_DD.xlsx` file
|
||||
2. The report is parsed server-side and a **diff preview** is shown — new violations, resolved items, and recurring items since the last upload
|
||||
@@ -391,7 +419,7 @@ A slide-out panel for a selected device showing:
|
||||
- For **2.3.x vulnerability metrics**: the `Ivanti_Vulnerability_ID` is displayed with a **View in Reporting →** button that navigates directly to the Reporting page
|
||||
- **Resolved Metrics** — previously failing metrics now back in compliance
|
||||
- **History** — how many times the device has appeared on the report and since when
|
||||
- **Notes** — timestamped notes per metric with a multi-metric selector if multiple metrics are failing
|
||||
- **Notes** — timestamped notes per metric with a multi-metric selector if multiple metrics are failing. Requires Admin or Standard_User group.
|
||||
|
||||
Notes persist across uploads and are keyed to the device hostname and metric ID.
|
||||
|
||||
@@ -405,11 +433,12 @@ Only **STEAM** and **ACCESS-ENG** teams are tracked. The team selector at the to
|
||||
|
||||
A document library for internal reference material — policies, runbooks, vendor advisories, and process guides.
|
||||
|
||||
- Upload documents with a title, optional description, and category
|
||||
- View documents inline in the browser (PDFs render in an iframe; Markdown files render as HTML)
|
||||
- Upload documents with a title, optional description, and category (Admin/Standard_User)
|
||||
- View documents inline in the browser (PDFs render in a sandboxed iframe; Markdown files render as sanitized HTML)
|
||||
- Download any document
|
||||
- Filter and browse by category
|
||||
- Editors and admins can upload and delete; all authenticated users can view
|
||||
- Admin can delete any article; Standard_User can delete articles they created
|
||||
- All authenticated users can view
|
||||
|
||||
Allowed file types: PDF, Markdown, TXT, Office documents (DOC, DOCX, XLS, XLSX, PPT, PPTX), HTML, JSON, YAML, and images (PNG, JPG, GIF).
|
||||
|
||||
@@ -417,7 +446,7 @@ Allowed file types: PDF, Markdown, TXT, Office documents (DOC, DOCX, XLS, XLSX,
|
||||
|
||||
### Exports
|
||||
|
||||
Bulk export tools for reports and data extracts.
|
||||
Bulk export tools for reports and data extracts. Available to Admin, Standard_User, and Leadership groups. Read_Only users cannot access the Exports page.
|
||||
|
||||
---
|
||||
|
||||
@@ -430,15 +459,18 @@ Track Archer exception tickets (EXC numbers) linked to specific CVE/vendor pairs
|
||||
- Optional Archer URL field for deep-linking to the Archer record
|
||||
- Filter tickets by CVE ID, vendor, or status
|
||||
- Clicking an EXC badge on the Home page navigates to the Reporting page pre-filtered to findings with that EXC number in their notes
|
||||
- Admin/Standard_User can create, edit, and delete tickets (Standard_User delete subject to ownership and compliance linkage checks)
|
||||
|
||||
---
|
||||
|
||||
### User Management (Admin)
|
||||
|
||||
- Create users with a role assignment
|
||||
- Change username, email, password, role, or active status
|
||||
- Create users with a group assignment (Admin, Standard_User, Leadership, Read_Only)
|
||||
- Change username, email, password, group, or active status
|
||||
- Group changes require confirmation; downgrading an Admin shows an additional warning
|
||||
- Deactivating a user immediately invalidates all their active sessions
|
||||
- Admins cannot demote themselves or deactivate their own account
|
||||
- All group changes are audit-logged with previous and new group values
|
||||
|
||||
---
|
||||
|
||||
@@ -506,130 +538,147 @@ python3 import_notes_from_csv.py input.csv --db /path/to/cve_database.db
|
||||
|
||||
## API Reference
|
||||
|
||||
All endpoints are prefixed with `/api`. All endpoints except `/api/auth/login` and `/api/auth/logout` require a valid session cookie.
|
||||
All endpoints are prefixed with `/api`. All endpoints except `/api/auth/login` and `/api/auth/logout` require a valid session cookie. Group requirements are listed per endpoint.
|
||||
|
||||
### Auth
|
||||
|
||||
| Method | Path | Auth | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| POST | `/api/auth/login` | Public | Log in, receive session cookie |
|
||||
| POST | `/api/auth/login` | Public | Log in, receive session cookie (rate-limited: 20/15min) |
|
||||
| POST | `/api/auth/logout` | Public | Invalidate session |
|
||||
| GET | `/api/auth/me` | Session | Get current user info |
|
||||
| POST | `/api/auth/cleanup-sessions` | Session | Delete expired sessions |
|
||||
| GET | `/api/auth/me` | Any | Get current user info (returns `group` field) |
|
||||
| POST | `/api/auth/cleanup-sessions` | Admin | Delete expired sessions |
|
||||
|
||||
### CVEs
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/cves` | viewer+ | List CVEs; query params: `search`, `vendor`, `severity`, `status` |
|
||||
| POST | `/api/cves` | editor+ | Create a new CVE entry |
|
||||
| PUT | `/api/cves/:id` | editor+ | Update a CVE entry by row ID |
|
||||
| PATCH | `/api/cves/:cveId/status` | editor+ | Update status for all vendor rows matching a CVE ID |
|
||||
| DELETE | `/api/cves/:id` | editor+ | Delete a single CVE vendor entry |
|
||||
| DELETE | `/api/cves/by-cve-id/:cveId` | editor+ | Delete all vendor entries for a CVE ID |
|
||||
| GET | `/api/cves/check/:cveId` | viewer+ | Quick check: existence and status of a CVE |
|
||||
| GET | `/api/cves/distinct-ids` | viewer+ | All distinct CVE IDs (used by NVD sync) |
|
||||
| GET | `/api/cves/:cveId/vendors` | viewer+ | All vendor entries for a specific CVE ID |
|
||||
| GET | `/api/cves` | Any | List CVEs; query params: `search`, `vendor`, `severity`, `status` |
|
||||
| POST | `/api/cves` | Admin, Standard_User | Create a new CVE entry |
|
||||
| PUT | `/api/cves/:id` | Admin, Standard_User | Update a CVE entry by row ID |
|
||||
| PATCH | `/api/cves/:cveId/status` | Admin, Standard_User | Update status for all vendor rows matching a CVE ID |
|
||||
| DELETE | `/api/cves/:id` | Admin, Standard_User | Delete a single CVE vendor entry (ownership + cascade check for Standard_User) |
|
||||
| DELETE | `/api/cves/by-cve-id/:cveId` | Admin, Standard_User | Delete all vendor entries for a CVE ID (ownership + cascade check for Standard_User) |
|
||||
| GET | `/api/cves/check/:cveId` | Any | Quick check: existence and status of a CVE |
|
||||
| GET | `/api/cves/distinct-ids` | Any | All distinct CVE IDs (used by NVD sync) |
|
||||
| GET | `/api/cves/:cveId/vendors` | Any | All vendor entries for a specific CVE ID |
|
||||
| GET | `/api/cves/compliance` | Any | Document compliance status view |
|
||||
|
||||
### Documents
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/cves/:cveId/documents` | viewer+ | List documents for a CVE; optional `?vendor=` filter |
|
||||
| POST | `/api/cves/:cveId/documents` | editor+ | Upload a document for a CVE/vendor pair |
|
||||
| DELETE | `/api/documents/:id` | admin | Delete a document and its file from disk |
|
||||
| GET | `/api/cves/:cveId/documents` | Any | List documents for a CVE; optional `?vendor=` filter |
|
||||
| POST | `/api/cves/:cveId/documents` | Admin, Standard_User | Upload a document for a CVE/vendor pair |
|
||||
| DELETE | `/api/documents/:id` | Admin | Delete a document and its file from disk |
|
||||
|
||||
### NVD
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/nvd/lookup/:cveId` | viewer+ | Look up a single CVE in the NVD 2.0 API |
|
||||
| POST | `/api/cves/nvd-sync` | editor+ | Bulk update CVE metadata from NVD |
|
||||
| GET | `/api/nvd/lookup/:cveId` | Any | Look up a single CVE in the NVD 2.0 API |
|
||||
| POST | `/api/cves/nvd-sync` | Admin, Standard_User | Bulk update CVE metadata from NVD |
|
||||
|
||||
### JIRA Tickets
|
||||
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/jira-tickets` | Any | List tickets; optional filters: `cve_id`, `vendor`, `status` |
|
||||
| POST | `/api/jira-tickets` | Admin, Standard_User | Create a JIRA ticket |
|
||||
| PUT | `/api/jira-tickets/:id` | Admin, Standard_User | Update a JIRA ticket |
|
||||
| DELETE | `/api/jira-tickets/:id` | Admin, Standard_User | Delete a JIRA ticket (ownership + compliance check for Standard_User) |
|
||||
|
||||
### Ivanti — Host Findings
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/ivanti/findings` | viewer+ | Get cached findings with notes and overrides merged in |
|
||||
| POST | `/api/ivanti/findings/sync` | viewer+ | Trigger an immediate findings sync from Ivanti |
|
||||
| GET | `/api/ivanti/findings/counts` | viewer+ | Open vs closed finding totals |
|
||||
| GET | `/api/ivanti/findings/fp-workflow-counts` | viewer+ | FP workflow state breakdown |
|
||||
| PUT | `/api/ivanti/findings/:findingId/override` | editor+ | Override `hostName` or `dns`; empty value clears the override |
|
||||
| PUT | `/api/ivanti/findings/:findingId/note` | viewer+ | Save or update a finding note (max 255 chars) |
|
||||
| GET | `/api/ivanti/findings` | Any | Get cached findings with notes and overrides merged in |
|
||||
| POST | `/api/ivanti/findings/sync` | Admin, Standard_User | Trigger an immediate findings sync from Ivanti |
|
||||
| GET | `/api/ivanti/findings/counts` | Any | Open vs closed finding totals |
|
||||
| GET | `/api/ivanti/findings/fp-workflow-counts` | Any | FP workflow state breakdown |
|
||||
| PUT | `/api/ivanti/findings/:findingId/override` | Admin, Standard_User | Override `hostName` or `dns`; empty value clears the override |
|
||||
| PUT | `/api/ivanti/findings/:findingId/note` | Admin, Standard_User | Save or update a finding note (max 255 chars) |
|
||||
|
||||
### Ivanti — Workflows
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/ivanti/workflows` | viewer+ | Get cached workflow data |
|
||||
| POST | `/api/ivanti/workflows/sync` | viewer+ | Trigger an immediate workflow sync |
|
||||
| GET | `/api/ivanti/workflows` | Any | Get cached workflow data |
|
||||
| POST | `/api/ivanti/workflows/sync` | Admin, Standard_User | Trigger an immediate workflow sync |
|
||||
|
||||
### Ivanti Queue
|
||||
### Ivanti — Todo Queue
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/ivanti/queue` | viewer+ | Get all queue items for the current user |
|
||||
| POST | `/api/ivanti/queue` | editor+ | Add a finding to the queue |
|
||||
| PATCH | `/api/ivanti/queue/:id` | editor+ | Update a queue item (mark complete, edit vendor/type) |
|
||||
| DELETE | `/api/ivanti/queue/:id` | editor+ | Delete a single queue item |
|
||||
| DELETE | `/api/ivanti/queue` | editor+ | Delete multiple queue items (body: `{ ids: [...] }`) |
|
||||
| GET | `/api/ivanti/todo-queue` | Any | Get all queue items for the current user |
|
||||
| POST | `/api/ivanti/todo-queue` | Admin, Standard_User | Add a finding to the queue |
|
||||
| PUT | `/api/ivanti/todo-queue/:id` | Admin, Standard_User | Update a queue item (mark complete, edit vendor/type) |
|
||||
| DELETE | `/api/ivanti/todo-queue/:id` | Admin, Standard_User | Delete a single queue item |
|
||||
| DELETE | `/api/ivanti/todo-queue/completed` | Admin, Standard_User | Delete all completed queue items |
|
||||
|
||||
### Ivanti — Archive
|
||||
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/ivanti/archive` | Any | Get finding archive data for severity score drift tracking |
|
||||
|
||||
### Compliance
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| POST | `/api/compliance/preview` | editor+ | Parse an xlsx upload and return diff + temp file path |
|
||||
| POST | `/api/compliance/commit` | editor+ | Commit a previewed upload to the database |
|
||||
| GET | `/api/compliance/uploads` | viewer+ | List all compliance upload records |
|
||||
| GET | `/api/compliance/summary` | viewer+ | Metric health summary; `?team=STEAM` |
|
||||
| GET | `/api/compliance/items` | viewer+ | Device list; `?team=STEAM&status=active` |
|
||||
| GET | `/api/compliance/items/:hostname` | viewer+ | Full detail for a device (metrics + notes) |
|
||||
| GET | `/api/compliance/notes/:hostname/:metricId` | viewer+ | Notes for a specific hostname/metric |
|
||||
| POST | `/api/compliance/notes` | editor+ | Add a note for a hostname/metric |
|
||||
| POST | `/api/compliance/preview` | Admin, Standard_User | Parse an xlsx upload and return diff + temp file path |
|
||||
| POST | `/api/compliance/commit` | Admin, Standard_User | Commit a previewed upload to the database |
|
||||
| GET | `/api/compliance/uploads` | Any | List all compliance upload records |
|
||||
| GET | `/api/compliance/summary` | Any | Metric health summary; `?team=STEAM` |
|
||||
| GET | `/api/compliance/items` | Any | Device list; `?team=STEAM&status=active` |
|
||||
| GET | `/api/compliance/items/:hostname` | Any | Full detail for a device (metrics + notes) |
|
||||
| GET | `/api/compliance/notes/:hostname/:metricId` | Any | Notes for a specific hostname/metric |
|
||||
| POST | `/api/compliance/notes` | Admin, Standard_User | Add a note for a hostname/metric |
|
||||
|
||||
### Knowledge Base
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| POST | `/api/knowledge-base/upload` | editor+ | Upload a new knowledge base document |
|
||||
| GET | `/api/knowledge-base` | viewer+ | List all articles |
|
||||
| GET | `/api/knowledge-base/:id` | viewer+ | Get article metadata |
|
||||
| GET | `/api/knowledge-base/:id/content` | viewer+ | Get file content for inline display |
|
||||
| GET | `/api/knowledge-base/:id/download` | viewer+ | Download the file |
|
||||
| DELETE | `/api/knowledge-base/:id` | editor+ | Delete article and file |
|
||||
| POST | `/api/knowledge-base/upload` | Admin, Standard_User | Upload a new knowledge base document |
|
||||
| GET | `/api/knowledge-base` | Any | List all articles |
|
||||
| GET | `/api/knowledge-base/:id` | Any | Get article metadata |
|
||||
| GET | `/api/knowledge-base/:id/content` | Any | Get file content for inline display |
|
||||
| GET | `/api/knowledge-base/:id/download` | Any | Download the file |
|
||||
| DELETE | `/api/knowledge-base/:id` | Admin, Standard_User | Delete article and file (Standard_User: own articles only) |
|
||||
|
||||
### Archer Tickets
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/archer-tickets` | viewer+ | List tickets; optional filters: `cve_id`, `vendor`, `status` |
|
||||
| POST | `/api/archer-tickets` | editor+ | Create a new Archer ticket |
|
||||
| PUT | `/api/archer-tickets/:id` | editor+ | Update an Archer ticket |
|
||||
| DELETE | `/api/archer-tickets/:id` | editor+ | Delete an Archer ticket |
|
||||
| GET | `/api/archer-tickets` | Any | List tickets; optional filters: `cve_id`, `vendor`, `status` |
|
||||
| GET | `/api/archer-tickets/status-trend` | Any | Ticket counts by date and status for pipeline chart |
|
||||
| POST | `/api/archer-tickets` | Admin, Standard_User | Create a new Archer ticket |
|
||||
| PUT | `/api/archer-tickets/:id` | Admin, Standard_User | Update an Archer ticket |
|
||||
| DELETE | `/api/archer-tickets/:id` | Admin, Standard_User | Delete an Archer ticket (ownership + compliance check for Standard_User) |
|
||||
|
||||
### Users (Admin only)
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/users` | admin | List all users |
|
||||
| GET | `/api/users/:id` | admin | Get a single user |
|
||||
| POST | `/api/users` | admin | Create a user |
|
||||
| PATCH | `/api/users/:id` | admin | Update a user |
|
||||
| DELETE | `/api/users/:id` | admin | Delete a user |
|
||||
| GET | `/api/users` | Admin | List all users |
|
||||
| GET | `/api/users/:id` | Admin | Get a single user |
|
||||
| POST | `/api/users` | Admin | Create a user |
|
||||
| PATCH | `/api/users/:id` | Admin | Update a user |
|
||||
| DELETE | `/api/users/:id` | Admin | Delete a user |
|
||||
|
||||
### Audit Logs (Admin only)
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/audit-logs` | admin | Paginated audit log; filters: `user`, `action`, `entityType`, `startDate`, `endDate` |
|
||||
| GET | `/api/audit-logs/actions` | admin | List distinct action types for filter dropdowns |
|
||||
| GET | `/api/audit-logs` | Admin | Paginated audit log; filters: `user`, `action`, `entityType`, `startDate`, `endDate` |
|
||||
| GET | `/api/audit-logs/actions` | Admin | List distinct action types for filter dropdowns |
|
||||
|
||||
### Utility
|
||||
|
||||
| Method | Path | Role | Description |
|
||||
| Method | Path | Group | Description |
|
||||
|---|---|---|---|
|
||||
| GET | `/api/vendors` | viewer+ | List all distinct vendor names |
|
||||
| GET | `/api/stats` | viewer+ | Dashboard statistics |
|
||||
| GET | `/api/vendors` | Any | List all distinct vendor names |
|
||||
| GET | `/api/stats` | Any | Dashboard statistics |
|
||||
|
||||
---
|
||||
|
||||
@@ -639,6 +688,7 @@ All endpoints are prefixed with `/api`. All endpoints except `/api/auth/login` a
|
||||
cve-dashboard/
|
||||
├── start-servers.sh # Start backend + frontend in background
|
||||
├── stop-servers.sh # Stop all servers
|
||||
├── package.json # Root package.json (backend dependencies)
|
||||
│
|
||||
├── backend/
|
||||
│ ├── server.js # Express app — routes, middleware, security headers
|
||||
@@ -649,7 +699,7 @@ cve-dashboard/
|
||||
│ │ ├── knowledge_base/ # Knowledge base documents
|
||||
│ │ └── temp/ # Temporary upload staging
|
||||
│ ├── routes/
|
||||
│ │ ├── auth.js # Login, logout, session check
|
||||
│ │ ├── auth.js # Login, logout, session check, rate limiting
|
||||
│ │ ├── users.js # User CRUD (admin)
|
||||
│ │ ├── auditLog.js # Audit log viewer (admin)
|
||||
│ │ ├── nvdLookup.js # NVD API proxy
|
||||
@@ -658,20 +708,13 @@ cve-dashboard/
|
||||
│ │ ├── ivantiWorkflows.js # Ivanti workflow batch sync and cache
|
||||
│ │ ├── ivantiFindings.js # Ivanti host findings sync, notes, overrides, FP counts
|
||||
│ │ ├── ivantiTodoQueue.js # Ivanti Queue — personal FP/Archer/CARD staging list
|
||||
│ │ ├── ivantiArchive.js # Finding archive for severity score drift
|
||||
│ │ └── compliance.js # AEO compliance upload, diff, device tracking, notes
|
||||
│ ├── middleware/
|
||||
│ │ └── auth.js # requireAuth and requireRole middleware
|
||||
│ │ └── auth.js # requireAuth and requireGroup middleware
|
||||
│ ├── helpers/
|
||||
│ │ ├── auditLog.js # logAudit helper (fire-and-forget)
|
||||
│ ├── migrations/
|
||||
│ │ ├── add_knowledge_base_table.js
|
||||
│ │ ├── add_archer_tickets_table.js
|
||||
│ │ ├── add_ivanti_sync_table.js
|
||||
│ │ ├── add_ivanti_findings_tables.js
|
||||
│ │ ├── add_ivanti_todo_queue_table.js # Ivanti Queue table
|
||||
│ │ ├── add_card_workflow_type.js # CARD workflow type support
|
||||
│ │ ├── add_todo_queue_ip_address.js # IP address column on queue items
|
||||
│ │ └── add_compliance_tables.js # AEO compliance tables
|
||||
│ │ └── auditLog.js # logAudit helper (fire-and-forget)
|
||||
│ ├── migrations/ # Sequential migration scripts (run manually with node)
|
||||
│ └── scripts/
|
||||
│ ├── parse_compliance_xlsx.py # Parses NTS_AEO xlsx compliance reports
|
||||
│ ├── import_notes_from_csv.py # Bulk-import finding notes from CSV
|
||||
@@ -682,24 +725,27 @@ cve-dashboard/
|
||||
├── App.js # Home dashboard — CVE list, filters, modals, calendar
|
||||
├── App.css # Global styles and CSS variables
|
||||
├── contexts/
|
||||
│ └── AuthContext.js # Auth state provider (login, logout, role helpers)
|
||||
│ └── AuthContext.js # Auth state provider (login, logout, group helpers)
|
||||
└── components/
|
||||
├── LoginForm.js # Login page
|
||||
├── NavDrawer.js # Side navigation drawer
|
||||
├── UserMenu.js # User dropdown in header
|
||||
├── NavDrawer.js # Side navigation drawer (Admin Panel link for Admin group)
|
||||
├── UserMenu.js # User dropdown in header (shows group badge)
|
||||
├── CalendarWidget.js # Due-date calendar with Ivanti finding indicators
|
||||
├── UserManagement.js # Admin user management panel
|
||||
├── UserManagement.js # Admin user management panel (group assignment)
|
||||
├── AuditLog.js # Admin audit log viewer
|
||||
├── NvdSyncModal.js # Bulk NVD sync dialog
|
||||
├── KnowledgeBaseModal.js # Knowledge base upload/list modal
|
||||
├── KnowledgeBaseViewer.js # Inline document viewer
|
||||
├── KnowledgeBaseViewer.js # Inline document viewer (sandboxed iframe, sanitized markdown)
|
||||
└── pages/
|
||||
├── ReportingPage.js # Host findings: charts, table, queue, export
|
||||
├── CompliancePage.js # AEO compliance: metric cards, device table
|
||||
├── ComplianceUploadModal.js # xlsx upload with diff preview
|
||||
├── ComplianceDetailPanel.js # Per-device metrics, history, notes
|
||||
├── ComplianceChartsPanel.js # Compliance trend charts
|
||||
├── IvantiCountsChart.js # Ivanti counts history chart
|
||||
├── ArchiveSummaryBar.js # Finding archive summary
|
||||
├── KnowledgeBasePage.js # Knowledge base page
|
||||
└── ExportsPage.js # Exports page
|
||||
└── ExportsPage.js # Exports page (group-gated)
|
||||
```
|
||||
|
||||
---
|
||||
@@ -708,13 +754,13 @@ cve-dashboard/
|
||||
|
||||
### Core tables (created by `setup.js`)
|
||||
|
||||
**`cves`** — One row per CVE/vendor pair. `UNIQUE(cve_id, vendor)`.
|
||||
**`cves`** — One row per CVE/vendor pair. `UNIQUE(cve_id, vendor)`. Includes `created_by` column for ownership tracking.
|
||||
|
||||
**`documents`** — Files attached to a CVE/vendor pair. Foreign key to `cves(cve_id)`.
|
||||
**`documents`** — Files attached to a CVE/vendor pair. Foreign key to `cves(cve_id)` with `ON DELETE CASCADE`.
|
||||
|
||||
**`required_documents`** — Vendor-specific document requirements.
|
||||
|
||||
**`users`** — Accounts with roles: `admin`, `editor`, `viewer`.
|
||||
**`users`** — Accounts with group-based access control. `user_group` column with values: `Admin`, `Standard_User`, `Leadership`, `Read_Only`. Enforced by INSERT/UPDATE triggers. Legacy `role` column retained for rollback safety.
|
||||
|
||||
**`sessions`** — Active sessions with 24-hour expiry.
|
||||
|
||||
@@ -722,9 +768,11 @@ cve-dashboard/
|
||||
|
||||
### Feature tables (added by migrations)
|
||||
|
||||
**`knowledge_base`** — Document library entries with title, slug, category, description, and file metadata.
|
||||
**`knowledge_base`** — Document library entries with title, slug, category, description, file metadata, and `created_by`.
|
||||
|
||||
**`archer_tickets`** — Archer EXC exception tickets linked to CVE/vendor pairs. `UNIQUE(exc_number)`.
|
||||
**`archer_tickets`** — Archer EXC exception tickets linked to CVE/vendor pairs. `UNIQUE(exc_number)`. Includes `created_by` for ownership tracking. Foreign key to `cves(cve_id, vendor)` with `ON DELETE CASCADE`.
|
||||
|
||||
**`jira_tickets`** — JIRA tickets linked to CVE/vendor pairs. Includes `created_by`. Foreign key to `cves(cve_id, vendor)` with `ON DELETE CASCADE`.
|
||||
|
||||
**`ivanti_sync_state`** — Single-row cache for Ivanti workflow batch data.
|
||||
|
||||
@@ -752,18 +800,47 @@ cve-dashboard/
|
||||
|
||||
## Security Model
|
||||
|
||||
### Authentication
|
||||
|
||||
- Cookie-based sessions with `httpOnly: true`, `sameSite: lax`, `secure: true` (in production)
|
||||
- Sessions expire after 24 hours
|
||||
- Login rate-limited to 20 attempts per 15-minute window via `express-rate-limit`
|
||||
- `SESSION_SECRET` is required — server refuses to start without it
|
||||
|
||||
### Group-based access control
|
||||
|
||||
Four groups with distinct permission boundaries enforced server-side via `requireGroup` middleware:
|
||||
|
||||
| Capability | Admin | Standard_User | Leadership | Read_Only |
|
||||
|---|---|---|---|---|
|
||||
| View all data | ✓ | ✓ | ✓ | ✓ |
|
||||
| Create/edit resources | ✓ | ✓ | ✗ | ✗ |
|
||||
| Delete own resources | ✓ | ✓ (restricted) | ✗ | ✗ |
|
||||
| Delete any resource | ✓ | ✗ | ✗ | ✗ |
|
||||
| Export (CSV/XLSX) | ✓ | ✓ | ✓ | ✗ |
|
||||
| Admin panel / user management | ✓ | ✗ | ✗ | ✗ |
|
||||
|
||||
Standard_User delete restrictions are enforced at the API level: ownership check, finding state check, compliance linkage check, and cascade impact check for CVEs.
|
||||
|
||||
### File upload security
|
||||
|
||||
- Extension allowlist enforced by Multer; executables (`.exe`, `.js`, `.sh`, `.py`, `.bat`, etc.) are blocked
|
||||
- MIME type prefix validation in addition to extension checking
|
||||
- 10 MB per-file size limit
|
||||
- Filenames are sanitized: path separators, `..` sequences, null bytes, and non-alphanumeric characters are removed
|
||||
- Content-Disposition headers sanitize filenames to prevent header injection
|
||||
|
||||
### Path traversal prevention
|
||||
|
||||
- `sanitizePathSegment()` strips `/`, `\`, `..`, and null bytes from any value used in `path.join()`
|
||||
- `isPathWithinUploads()` verifies resolved paths stay within the uploads root before any file operation
|
||||
|
||||
### Content security
|
||||
|
||||
- Knowledge base PDF iframe uses `sandbox="allow-same-origin"` to prevent script execution
|
||||
- Markdown rendering uses `rehype-sanitize` to strip dangerous HTML
|
||||
- CSP `frame-ancestors` header derived from `CORS_ORIGINS` environment variable
|
||||
|
||||
### Input validation
|
||||
|
||||
- CVE ID must match `/^CVE-\d{4}-\d{4,}$/`
|
||||
@@ -771,14 +848,10 @@ cve-dashboard/
|
||||
- Status must be one of: `Open`, `Addressed`, `In Progress`, `Resolved`
|
||||
- Archer EXC numbers must match `/^EXC-\d+$/`
|
||||
- Finding override field must be one of: `hostName`, `dns`
|
||||
- User group validated against: `Admin`, `Standard_User`, `Leadership`, `Read_Only` (enforced by DB triggers and app-level validation)
|
||||
- Hostname format validated with `/^[a-zA-Z0-9._-]+$/` in compliance notes
|
||||
- All database operations use prepared statements — no string interpolation in SQL
|
||||
|
||||
### Error handling
|
||||
|
||||
- 500 responses never expose internal error messages to the client
|
||||
- Full errors are logged server-side only
|
||||
- Descriptive 400/409 responses contain only application-authored validation messages
|
||||
|
||||
### Security headers
|
||||
|
||||
Applied to all responses:
|
||||
@@ -789,15 +862,69 @@ Applied to all responses:
|
||||
- `Referrer-Policy: strict-origin-when-cross-origin`
|
||||
- `Permissions-Policy: camera=(), microphone=(), geolocation=()`
|
||||
|
||||
### Session cookies
|
||||
---
|
||||
|
||||
`httpOnly: true`, `sameSite: lax`, `secure: true` in production (`NODE_ENV=production`).
|
||||
## Upgrading an Existing Deployment
|
||||
|
||||
This procedure updates the application code and schema while preserving all existing data. The database file (`backend/cve_database.db`) is never overwritten by `git pull` — it is gitignored.
|
||||
|
||||
```bash
|
||||
# 1. Stop the running servers
|
||||
cd /home/cve-dashboard
|
||||
./stop-servers.sh
|
||||
|
||||
# 2. Pull latest code
|
||||
git pull origin master
|
||||
|
||||
# 3. Install backend dependencies (picks up any new packages)
|
||||
npm install
|
||||
|
||||
# 4. Install frontend dependencies
|
||||
cd frontend
|
||||
npm install
|
||||
cd ..
|
||||
|
||||
# 5. Ensure SESSION_SECRET is set in backend/.env
|
||||
# If missing:
|
||||
# echo "SESSION_SECRET=$(openssl rand -base64 32)" >> backend/.env
|
||||
|
||||
# 6. Run all migrations (idempotent — safe to re-run, skips already-applied changes)
|
||||
cd backend
|
||||
node migrations/add_knowledge_base_table.js
|
||||
node migrations/add_archer_tickets_table.js
|
||||
node migrations/add_ivanti_sync_table.js
|
||||
node migrations/add_ivanti_findings_tables.js
|
||||
node migrations/add_ivanti_todo_queue_table.js
|
||||
node migrations/add_card_workflow_type.js
|
||||
node migrations/add_todo_queue_ip_address.js
|
||||
node migrations/add_compliance_tables.js
|
||||
node migrations/add_finding_archive_tables.js
|
||||
node migrations/add_archer_tickets_timestamps.js
|
||||
node migrations/add_ivanti_counts_history_table.js
|
||||
node migrations/add_user_groups.js
|
||||
node migrations/add_created_by_columns.js
|
||||
cd ..
|
||||
|
||||
# 7. Rebuild the frontend
|
||||
cd frontend
|
||||
npm run build
|
||||
cd ..
|
||||
|
||||
# 8. Start servers
|
||||
./start-servers.sh
|
||||
```
|
||||
|
||||
After upgrading, clear your browser cookies and log in fresh — session format changes between versions will invalidate old sessions.
|
||||
|
||||
> **Do not re-run `node setup.js`** on an existing deployment. It is only for first-time initialization. Re-running it will not destroy data (it checks for existing tables/users), but it is unnecessary and may create a duplicate admin account.
|
||||
|
||||
> **NODE_ENV reminder:** If you are running over plain HTTP (no TLS), make sure `NODE_ENV` is **not** set to `production` in `backend/.env`. See [Troubleshooting](#troubleshooting) for details.
|
||||
|
||||
---
|
||||
|
||||
## Migrations
|
||||
|
||||
Migrations are standalone Node.js scripts. Run them in the listed order on a fresh install. All use `CREATE TABLE IF NOT EXISTS` or `ALTER TABLE ... ADD COLUMN IF NOT EXISTS` and are safe to re-run.
|
||||
Migrations are standalone Node.js scripts. Run them in the listed order on a fresh install. All are idempotent and safe to re-run.
|
||||
|
||||
```bash
|
||||
cd backend
|
||||
@@ -809,6 +936,11 @@ node migrations/add_ivanti_todo_queue_table.js
|
||||
node migrations/add_card_workflow_type.js
|
||||
node migrations/add_todo_queue_ip_address.js
|
||||
node migrations/add_compliance_tables.js
|
||||
node migrations/add_finding_archive_tables.js
|
||||
node migrations/add_archer_tickets_timestamps.js
|
||||
node migrations/add_ivanti_counts_history_table.js
|
||||
node migrations/add_user_groups.js
|
||||
node migrations/add_created_by_columns.js
|
||||
```
|
||||
|
||||
For deployments upgrading from an older schema, the following legacy migration scripts are also available in `backend/`:
|
||||
@@ -818,3 +950,38 @@ For deployments upgrading from an older schema, the following legacy migration s
|
||||
- `migrate-to-1.1.js` — General 1.0 → 1.1 schema update
|
||||
|
||||
> Several columns (`fp_workflow_counts_json`, `fp_id_counts_json`, `seen_count`, `summary_json`) are added automatically via idempotent `ALTER TABLE` statements each time the server starts. No manual re-run is needed.
|
||||
|
||||
---
|
||||
|
||||
## Troubleshooting
|
||||
|
||||
### Login succeeds but all pages show "Error Loading" / 401 Unauthorized
|
||||
|
||||
**Symptom:** You can log in successfully, but the dashboard shows "Error Loading CVEs", "Failed to fetch", and the browser console shows 401 on every API call.
|
||||
|
||||
**Cause:** The session cookie has the `Secure` flag set (because `NODE_ENV=production` in `backend/.env`), but the application is being accessed over plain HTTP. Browsers silently refuse to send `Secure` cookies over non-HTTPS connections, so every request after login arrives without a session cookie.
|
||||
|
||||
**Fix:** Either:
|
||||
1. Remove `NODE_ENV=production` from `backend/.env` (or set it to `development`) and restart the backend, **or**
|
||||
2. Set up HTTPS (e.g., via nginx reverse proxy with TLS termination) and access the app over `https://`
|
||||
|
||||
### Login fails with "Too many login attempts"
|
||||
|
||||
**Cause:** The login endpoint is rate-limited to 20 attempts per 15-minute window. Wait 15 minutes or restart the backend to reset the counter.
|
||||
|
||||
### Server refuses to start: "SESSION_SECRET environment variable must be set"
|
||||
|
||||
**Fix:** Add a `SESSION_SECRET` to `backend/.env`:
|
||||
```bash
|
||||
echo "SESSION_SECRET=$(openssl rand -base64 32)" >> backend/.env
|
||||
```
|
||||
|
||||
### After upgrading: "user_group" errors or missing group data
|
||||
|
||||
**Fix:** Run the group migration:
|
||||
```bash
|
||||
cd backend
|
||||
node migrations/add_user_groups.js
|
||||
node migrations/add_created_by_columns.js
|
||||
```
|
||||
This maps existing roles to groups automatically (admin→Admin, editor→Standard_User, viewer→Read_Only).
|
||||
|
||||
@@ -12,7 +12,7 @@ function requireAuth(db) {
|
||||
try {
|
||||
const session = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
`SELECT s.*, u.id as user_id, u.username, u.email, u.role, u.is_active
|
||||
`SELECT s.*, u.id as user_id, u.username, u.email, u.role, u.user_group, u.is_active
|
||||
FROM sessions s
|
||||
JOIN users u ON s.user_id = u.id
|
||||
WHERE s.session_id = ? AND s.expires_at > datetime('now')`,
|
||||
@@ -37,7 +37,8 @@ function requireAuth(db) {
|
||||
id: session.user_id,
|
||||
username: session.username,
|
||||
email: session.email,
|
||||
role: session.role
|
||||
role: session.role,
|
||||
group: session.user_group
|
||||
};
|
||||
|
||||
next();
|
||||
@@ -48,18 +49,18 @@ function requireAuth(db) {
|
||||
};
|
||||
}
|
||||
|
||||
// Require specific role(s)
|
||||
function requireRole(...allowedRoles) {
|
||||
// Require specific group(s)
|
||||
function requireGroup(...allowedGroups) {
|
||||
return (req, res, next) => {
|
||||
if (!req.user) {
|
||||
return res.status(401).json({ error: 'Authentication required' });
|
||||
}
|
||||
|
||||
if (!allowedRoles.includes(req.user.role)) {
|
||||
if (!allowedGroups.includes(req.user.group)) {
|
||||
return res.status(403).json({
|
||||
error: 'Insufficient permissions',
|
||||
required: allowedRoles,
|
||||
current: req.user.role
|
||||
required: allowedGroups,
|
||||
current: req.user.group
|
||||
});
|
||||
}
|
||||
|
||||
@@ -67,4 +68,4 @@ function requireRole(...allowedRoles) {
|
||||
};
|
||||
}
|
||||
|
||||
module.exports = { requireAuth, requireRole };
|
||||
module.exports = { requireAuth, requireGroup };
|
||||
|
||||
56
backend/migrations/add_archer_tickets_timestamps.js
Normal file
56
backend/migrations/add_archer_tickets_timestamps.js
Normal file
@@ -0,0 +1,56 @@
|
||||
// Migration: Add created_at / updated_at columns to archer_tickets
|
||||
//
|
||||
// SQLite does not support ALTER TABLE ADD COLUMN IF NOT EXISTS, so we check
|
||||
// PRAGMA table_info first and only add the column when it is absent.
|
||||
//
|
||||
// Run on any instance where archer_tickets was created before these columns
|
||||
// were added to the schema (symptoms: every /api/archer-tickets call → 500).
|
||||
//
|
||||
// Usage: node backend/migrations/add_archer_tickets_timestamps.js
|
||||
|
||||
const sqlite3 = require('sqlite3').verbose();
|
||||
const path = require('path');
|
||||
|
||||
const dbPath = path.join(__dirname, '..', 'cve_database.db');
|
||||
const db = new sqlite3.Database(dbPath);
|
||||
|
||||
console.log('Starting archer_tickets timestamp migration...');
|
||||
|
||||
db.all('PRAGMA table_info(archer_tickets)', [], (err, columns) => {
|
||||
if (err) {
|
||||
console.error('Error reading table info:', err);
|
||||
return db.close();
|
||||
}
|
||||
|
||||
const names = columns.map(c => c.name);
|
||||
|
||||
db.serialize(() => {
|
||||
if (!names.includes('created_at')) {
|
||||
db.run(
|
||||
`ALTER TABLE archer_tickets ADD COLUMN created_at DATETIME DEFAULT CURRENT_TIMESTAMP`,
|
||||
(err) => {
|
||||
if (err) console.error('Error adding created_at:', err);
|
||||
else console.log('✓ created_at column added');
|
||||
}
|
||||
);
|
||||
} else {
|
||||
console.log('✓ created_at already exists — skipping');
|
||||
}
|
||||
|
||||
if (!names.includes('updated_at')) {
|
||||
db.run(
|
||||
`ALTER TABLE archer_tickets ADD COLUMN updated_at DATETIME DEFAULT CURRENT_TIMESTAMP`,
|
||||
(err) => {
|
||||
if (err) console.error('Error adding updated_at:', err);
|
||||
else console.log('✓ updated_at column added');
|
||||
}
|
||||
);
|
||||
} else {
|
||||
console.log('✓ updated_at already exists — skipping');
|
||||
}
|
||||
});
|
||||
|
||||
db.close(() => {
|
||||
console.log('Migration complete. Restart the backend server.');
|
||||
});
|
||||
});
|
||||
76
backend/migrations/add_created_by_columns.js
Normal file
76
backend/migrations/add_created_by_columns.js
Normal file
@@ -0,0 +1,76 @@
|
||||
// Migration: Add created_by column to cves, archer_tickets, and jira_tickets tables
|
||||
// Stores the user ID of the creator for ownership-based delete checks.
|
||||
// Idempotent — safe to run multiple times.
|
||||
const sqlite3 = require('sqlite3').verbose();
|
||||
const path = require('path');
|
||||
|
||||
/**
|
||||
* Run the migration against the given database instance.
|
||||
* Exported for testing with in-memory databases.
|
||||
* @param {sqlite3.Database} db
|
||||
* @returns {Promise<void>}
|
||||
*/
|
||||
function runMigration(db) {
|
||||
return new Promise((resolve, reject) => {
|
||||
const tables = ['cves', 'archer_tickets', 'jira_tickets'];
|
||||
let completed = 0;
|
||||
|
||||
db.serialize(() => {
|
||||
tables.forEach((table) => {
|
||||
db.all(`PRAGMA table_info(${table})`, (err, columns) => {
|
||||
if (err) {
|
||||
// Table may not exist yet — skip gracefully
|
||||
console.log(`⚠ Could not inspect ${table}: ${err.message} — skipping`);
|
||||
completed++;
|
||||
if (completed === tables.length) resolve();
|
||||
return;
|
||||
}
|
||||
|
||||
const hasCreatedBy = columns.some(col => col.name === 'created_by');
|
||||
|
||||
if (hasCreatedBy) {
|
||||
console.log(`✓ ${table}.created_by already exists — skipping`);
|
||||
completed++;
|
||||
if (completed === tables.length) resolve();
|
||||
return;
|
||||
}
|
||||
|
||||
db.run(
|
||||
`ALTER TABLE ${table} ADD COLUMN created_by INTEGER REFERENCES users(id)`,
|
||||
(err) => {
|
||||
if (err) {
|
||||
reject(err);
|
||||
return;
|
||||
}
|
||||
console.log(`✓ Added created_by column to ${table}`);
|
||||
completed++;
|
||||
if (completed === tables.length) resolve();
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
// Run directly if executed as a script
|
||||
if (require.main === module) {
|
||||
const dbPath = path.join(__dirname, '..', 'cve_database.db');
|
||||
const db = new sqlite3.Database(dbPath);
|
||||
console.log('Starting add_created_by_columns migration...');
|
||||
|
||||
runMigration(db)
|
||||
.then(() => {
|
||||
console.log('Migration complete!');
|
||||
db.close(() => {
|
||||
console.log('Database connection closed.');
|
||||
});
|
||||
})
|
||||
.catch((err) => {
|
||||
console.error('Migration failed:', err);
|
||||
db.close();
|
||||
process.exit(1);
|
||||
});
|
||||
}
|
||||
|
||||
module.exports = { runMigration };
|
||||
75
backend/migrations/add_finding_archive_tables.js
Normal file
75
backend/migrations/add_finding_archive_tables.js
Normal file
@@ -0,0 +1,75 @@
|
||||
// Migration: Add ivanti_finding_archives and ivanti_archive_transitions tables
|
||||
const sqlite3 = require('sqlite3').verbose();
|
||||
const path = require('path');
|
||||
|
||||
const dbPath = path.join(__dirname, '..', 'cve_database.db');
|
||||
const db = new sqlite3.Database(dbPath);
|
||||
|
||||
console.log('Starting finding archive tables migration...');
|
||||
|
||||
db.serialize(() => {
|
||||
// Archive records — one row per finding that has entered the archive lifecycle
|
||||
db.run(`
|
||||
CREATE TABLE IF NOT EXISTS ivanti_finding_archives (
|
||||
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
finding_id TEXT NOT NULL UNIQUE,
|
||||
finding_title TEXT NOT NULL DEFAULT '',
|
||||
host_name TEXT NOT NULL DEFAULT '',
|
||||
ip_address TEXT NOT NULL DEFAULT '',
|
||||
current_state TEXT NOT NULL CHECK(current_state IN ('ARCHIVED', 'RETURNED', 'CLOSED')),
|
||||
last_severity REAL NOT NULL DEFAULT 0,
|
||||
first_archived_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
last_transition_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
created_at DATETIME DEFAULT CURRENT_TIMESTAMP
|
||||
)
|
||||
`, (err) => {
|
||||
if (err) console.error('Error creating ivanti_finding_archives table:', err);
|
||||
else console.log('✓ ivanti_finding_archives table created');
|
||||
});
|
||||
|
||||
// Transition history — one row per state change on an archive record
|
||||
db.run(`
|
||||
CREATE TABLE IF NOT EXISTS ivanti_archive_transitions (
|
||||
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
archive_id INTEGER NOT NULL,
|
||||
from_state TEXT NOT NULL,
|
||||
to_state TEXT NOT NULL,
|
||||
severity_at_transition REAL NOT NULL DEFAULT 0,
|
||||
reason TEXT NOT NULL DEFAULT '',
|
||||
transitioned_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
FOREIGN KEY (archive_id) REFERENCES ivanti_finding_archives(id)
|
||||
)
|
||||
`, (err) => {
|
||||
if (err) console.error('Error creating ivanti_archive_transitions table:', err);
|
||||
else console.log('✓ ivanti_archive_transitions table created');
|
||||
});
|
||||
|
||||
// Indexes for query performance
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_archive_finding_id
|
||||
ON ivanti_finding_archives(finding_id)
|
||||
`, (err) => {
|
||||
if (err) console.error('Error creating idx_archive_finding_id:', err);
|
||||
else console.log('✓ idx_archive_finding_id index created');
|
||||
});
|
||||
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_archive_current_state
|
||||
ON ivanti_finding_archives(current_state)
|
||||
`, (err) => {
|
||||
if (err) console.error('Error creating idx_archive_current_state:', err);
|
||||
else console.log('✓ idx_archive_current_state index created');
|
||||
});
|
||||
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_transition_archive_id
|
||||
ON ivanti_archive_transitions(archive_id)
|
||||
`, (err) => {
|
||||
if (err) console.error('Error creating idx_transition_archive_id:', err);
|
||||
else console.log('✓ idx_transition_archive_id index created');
|
||||
});
|
||||
});
|
||||
|
||||
db.close(() => {
|
||||
console.log('Migration complete!');
|
||||
});
|
||||
146
backend/migrations/add_user_groups.js
Normal file
146
backend/migrations/add_user_groups.js
Normal file
@@ -0,0 +1,146 @@
|
||||
// Migration: Add user_group column to users table and map legacy roles
|
||||
// Mapping: admin→Admin, editor→Standard_User, viewer→Read_Only
|
||||
// NULL/unrecognized roles default to Read_Only
|
||||
// Idempotent — safe to run multiple times
|
||||
const sqlite3 = require('sqlite3').verbose();
|
||||
const path = require('path');
|
||||
|
||||
/**
|
||||
* Run the migration against the given database instance.
|
||||
* Exported for testing with in-memory databases.
|
||||
* @param {sqlite3.Database} db
|
||||
* @returns {Promise<void>}
|
||||
*/
|
||||
function runMigration(db) {
|
||||
return new Promise((resolve, reject) => {
|
||||
db.serialize(() => {
|
||||
// Check if user_group column already exists
|
||||
db.all("PRAGMA table_info(users)", (err, columns) => {
|
||||
if (err) {
|
||||
reject(err);
|
||||
return;
|
||||
}
|
||||
|
||||
const hasUserGroup = columns.some(col => col.name === 'user_group');
|
||||
|
||||
if (hasUserGroup) {
|
||||
console.log('✓ user_group column already exists — skipping migration');
|
||||
resolve();
|
||||
return;
|
||||
}
|
||||
|
||||
console.log('Adding user_group column to users table...');
|
||||
|
||||
// SQLite doesn't support ADD COLUMN with CHECK inline in all versions,
|
||||
// so we add the column first, map values, then recreate with constraint.
|
||||
// However, SQLite also doesn't support ALTER TABLE ADD CONSTRAINT.
|
||||
// Strategy: add column, map values, create index.
|
||||
// The CHECK constraint is enforced via table rebuild.
|
||||
|
||||
db.run(
|
||||
`ALTER TABLE users ADD COLUMN user_group VARCHAR(20) NOT NULL DEFAULT 'Read_Only'`,
|
||||
(err) => {
|
||||
if (err) {
|
||||
reject(err);
|
||||
return;
|
||||
}
|
||||
console.log('✓ Added user_group column');
|
||||
|
||||
// Map existing roles to groups
|
||||
db.run(
|
||||
`UPDATE users SET user_group = 'Admin' WHERE role = 'admin'`,
|
||||
function(err) {
|
||||
if (err) { reject(err); return; }
|
||||
console.log(` ✓ Mapped ${this.changes} admin(s) → Admin`);
|
||||
|
||||
db.run(
|
||||
`UPDATE users SET user_group = 'Standard_User' WHERE role = 'editor'`,
|
||||
function(err) {
|
||||
if (err) { reject(err); return; }
|
||||
console.log(` ✓ Mapped ${this.changes} editor(s) → Standard_User`);
|
||||
|
||||
db.run(
|
||||
`UPDATE users SET user_group = 'Read_Only' WHERE role = 'viewer'`,
|
||||
function(err) {
|
||||
if (err) { reject(err); return; }
|
||||
console.log(` ✓ Mapped ${this.changes} viewer(s) → Read_Only`);
|
||||
|
||||
// Map NULL or unrecognized roles to Read_Only
|
||||
db.run(
|
||||
`UPDATE users SET user_group = 'Read_Only' WHERE user_group = 'Read_Only' AND role NOT IN ('admin', 'editor', 'viewer')`,
|
||||
function(err) {
|
||||
if (err) { reject(err); return; }
|
||||
console.log(` ✓ Mapped ${this.changes} unrecognized role(s) → Read_Only`);
|
||||
|
||||
// Create index on user_group
|
||||
db.run(
|
||||
`CREATE INDEX IF NOT EXISTS idx_users_user_group ON users(user_group)`,
|
||||
(err) => {
|
||||
if (err) { reject(err); return; }
|
||||
console.log('✓ Created idx_users_user_group index');
|
||||
|
||||
// Add CHECK constraint via trigger (SQLite can't ALTER TABLE ADD CONSTRAINT)
|
||||
db.run(
|
||||
`CREATE TRIGGER IF NOT EXISTS check_user_group_insert
|
||||
BEFORE INSERT ON users
|
||||
FOR EACH ROW
|
||||
WHEN NEW.user_group NOT IN ('Admin', 'Standard_User', 'Leadership', 'Read_Only')
|
||||
BEGIN
|
||||
SELECT RAISE(ABORT, 'Invalid user_group value. Must be Admin, Standard_User, Leadership, or Read_Only');
|
||||
END`,
|
||||
(err) => {
|
||||
if (err) { reject(err); return; }
|
||||
db.run(
|
||||
`CREATE TRIGGER IF NOT EXISTS check_user_group_update
|
||||
BEFORE UPDATE OF user_group ON users
|
||||
FOR EACH ROW
|
||||
WHEN NEW.user_group NOT IN ('Admin', 'Standard_User', 'Leadership', 'Read_Only')
|
||||
BEGIN
|
||||
SELECT RAISE(ABORT, 'Invalid user_group value. Must be Admin, Standard_User, Leadership, or Read_Only');
|
||||
END`,
|
||||
(err) => {
|
||||
if (err) { reject(err); return; }
|
||||
console.log('✓ Created user_group validation triggers');
|
||||
console.log('Migration complete!');
|
||||
resolve();
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
// Run directly if executed as a script
|
||||
if (require.main === module) {
|
||||
const dbPath = path.join(__dirname, '..', 'cve_database.db');
|
||||
const db = new sqlite3.Database(dbPath);
|
||||
console.log('Starting add_user_groups migration...');
|
||||
|
||||
runMigration(db)
|
||||
.then(() => {
|
||||
db.close(() => {
|
||||
console.log('Database connection closed.');
|
||||
});
|
||||
})
|
||||
.catch((err) => {
|
||||
console.error('Migration failed:', err);
|
||||
db.close();
|
||||
process.exit(1);
|
||||
});
|
||||
}
|
||||
|
||||
module.exports = { runMigration };
|
||||
@@ -1,6 +1,6 @@
|
||||
// routes/archerTickets.js
|
||||
const express = require('express');
|
||||
const { requireAuth, requireRole } = require('../middleware/auth');
|
||||
const { requireAuth, requireGroup } = require('../middleware/auth');
|
||||
const logAudit = require('../helpers/auditLog');
|
||||
|
||||
// Validation helpers
|
||||
@@ -48,7 +48,7 @@ function createArcherTicketsRouter(db) {
|
||||
});
|
||||
|
||||
// Create Archer ticket
|
||||
router.post('/', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
router.post('/', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { exc_number, archer_url, status, cve_id, vendor } = req.body;
|
||||
|
||||
// Validation
|
||||
@@ -74,9 +74,9 @@ function createArcherTicketsRouter(db) {
|
||||
const validatedStatus = status || 'Draft';
|
||||
|
||||
db.run(
|
||||
`INSERT INTO archer_tickets (exc_number, archer_url, status, cve_id, vendor)
|
||||
VALUES (?, ?, ?, ?, ?)`,
|
||||
[exc_number.trim(), archer_url || null, validatedStatus, cve_id, vendor],
|
||||
`INSERT INTO archer_tickets (exc_number, archer_url, status, cve_id, vendor, created_by)
|
||||
VALUES (?, ?, ?, ?, ?, ?)`,
|
||||
[exc_number.trim(), archer_url || null, validatedStatus, cve_id, vendor, req.user.id],
|
||||
function(err) {
|
||||
if (err) {
|
||||
console.error('Error creating Archer ticket:', err);
|
||||
@@ -89,8 +89,8 @@ function createArcherTicketsRouter(db) {
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
action: 'CREATE_ARCHER_TICKET',
|
||||
targetType: 'archer_ticket',
|
||||
targetId: this.lastID,
|
||||
entityType: 'archer_ticket',
|
||||
entityId: String(this.lastID),
|
||||
details: { exc_number, archer_url, status: validatedStatus, cve_id, vendor },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
@@ -104,7 +104,7 @@ function createArcherTicketsRouter(db) {
|
||||
});
|
||||
|
||||
// Update Archer ticket
|
||||
router.put('/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
router.put('/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
const { exc_number, archer_url, status } = req.body;
|
||||
|
||||
@@ -172,8 +172,8 @@ function createArcherTicketsRouter(db) {
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
action: 'UPDATE_ARCHER_TICKET',
|
||||
targetType: 'archer_ticket',
|
||||
targetId: id,
|
||||
entityType: 'archer_ticket',
|
||||
entityId: String(id),
|
||||
details: { before: existing, changes: req.body },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
@@ -184,8 +184,29 @@ function createArcherTicketsRouter(db) {
|
||||
});
|
||||
});
|
||||
|
||||
// Helper: perform the actual Archer ticket deletion
|
||||
function performArcherDelete(db, req, res, id, ticket) {
|
||||
db.run('DELETE FROM archer_tickets WHERE id = ?', [id], function(err) {
|
||||
if (err) {
|
||||
console.error(err);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
action: 'DELETE_ARCHER_TICKET',
|
||||
entityType: 'archer_ticket',
|
||||
entityId: String(id),
|
||||
details: { deleted: ticket },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
res.json({ message: 'Archer ticket deleted successfully' });
|
||||
});
|
||||
}
|
||||
|
||||
// Delete Archer ticket
|
||||
router.delete('/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
router.delete('/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
db.get('SELECT * FROM archer_tickets WHERE id = ?', [id], (err, ticket) => {
|
||||
@@ -197,23 +218,45 @@ function createArcherTicketsRouter(db) {
|
||||
return res.status(404).json({ error: 'Archer ticket not found.' });
|
||||
}
|
||||
|
||||
db.run('DELETE FROM archer_tickets WHERE id = ?', [id], function(err) {
|
||||
if (err) {
|
||||
console.error(err);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
// Admin bypasses all delete restrictions
|
||||
if (req.user.group === 'Admin') {
|
||||
return performArcherDelete(db, req, res, id, ticket);
|
||||
}
|
||||
|
||||
// Standard_User: ownership check
|
||||
if (ticket.created_by && ticket.created_by !== req.user.id) {
|
||||
return res.status(403).json({ error: 'You can only delete resources you created' });
|
||||
}
|
||||
|
||||
// Standard_User: compliance linkage check
|
||||
const excNumber = ticket.exc_number;
|
||||
db.all(
|
||||
`SELECT ci.id, ci.extra_json
|
||||
FROM compliance_items ci
|
||||
JOIN compliance_uploads cu ON ci.upload_id = cu.id
|
||||
WHERE ci.status = 'active' AND ci.extra_json LIKE ?`,
|
||||
[`%${excNumber}%`],
|
||||
(compErr, compLinks) => {
|
||||
// If compliance_items table doesn't exist yet, treat as no linkage
|
||||
if (compErr && compErr.message && compErr.message.includes('no such table')) {
|
||||
compLinks = [];
|
||||
} else if (compErr) {
|
||||
console.error(compErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
const isLinked = (compLinks || []).some(cl => {
|
||||
const json = cl.extra_json || '';
|
||||
return json.includes(excNumber);
|
||||
});
|
||||
|
||||
if (isLinked) {
|
||||
return res.status(403).json({ error: 'Cannot delete ticket linked to compliance report. Contact an admin.' });
|
||||
}
|
||||
|
||||
return performArcherDelete(db, req, res, id, ticket);
|
||||
}
|
||||
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
action: 'DELETE_ARCHER_TICKET',
|
||||
targetType: 'archer_ticket',
|
||||
targetId: id,
|
||||
details: { deleted: ticket },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
res.json({ message: 'Archer ticket deleted successfully' });
|
||||
});
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -1,11 +1,11 @@
|
||||
// Audit Log Routes (Admin only)
|
||||
const express = require('express');
|
||||
|
||||
function createAuditLogRouter(db, requireAuth, requireRole) {
|
||||
function createAuditLogRouter(db, requireAuth, requireGroup) {
|
||||
const router = express.Router();
|
||||
|
||||
// All routes require admin role
|
||||
router.use(requireAuth(db), requireRole('admin'));
|
||||
// All routes require Admin group
|
||||
router.use(requireAuth(db), requireGroup('Admin'));
|
||||
|
||||
// Get paginated audit logs with filters
|
||||
router.get('/', async (req, res) => {
|
||||
|
||||
@@ -2,12 +2,35 @@
|
||||
const express = require('express');
|
||||
const bcrypt = require('bcryptjs');
|
||||
const crypto = require('crypto');
|
||||
const rateLimit = require('express-rate-limit');
|
||||
const { requireAuth, requireGroup } = require('../middleware/auth');
|
||||
|
||||
const loginLimiter = rateLimit({
|
||||
windowMs: 15 * 60 * 1000, // 15 minutes
|
||||
max: 20, // 20 attempts per window
|
||||
standardHeaders: true,
|
||||
legacyHeaders: false,
|
||||
message: { error: 'Too many login attempts. Please try again in 15 minutes.' }
|
||||
});
|
||||
|
||||
function createAuthRouter(db, logAudit) {
|
||||
const router = express.Router();
|
||||
|
||||
// Login
|
||||
router.post('/login', async (req, res) => {
|
||||
/**
|
||||
* POST /api/auth/login
|
||||
*
|
||||
* Authenticates a user with username and password, creates a session,
|
||||
* and sets an httpOnly session cookie. Rate-limited to 20 attempts per 15 minutes.
|
||||
*
|
||||
* @body {string} username - The user's login username
|
||||
* @body {string} password - The user's password
|
||||
* @returns {object} 200 - { message: 'Login successful', user: { id, username, email, group } }
|
||||
* @returns {object} 400 - { error: 'Username and password are required' }
|
||||
* @returns {object} 401 - { error: 'Invalid username or password' } | { error: 'Account is disabled' }
|
||||
* @returns {object} 429 - { error: 'Too many login attempts. Please try again in 15 minutes.' }
|
||||
* @returns {object} 500 - { error: 'Login failed' }
|
||||
*/
|
||||
router.post('/login', loginLimiter, async (req, res) => {
|
||||
const { username, password } = req.body;
|
||||
|
||||
if (!username || !password) {
|
||||
@@ -110,7 +133,7 @@ function createAuthRouter(db, logAudit) {
|
||||
action: 'login',
|
||||
entityType: 'auth',
|
||||
entityId: null,
|
||||
details: { role: user.role },
|
||||
details: { group: user.user_group },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
@@ -120,7 +143,7 @@ function createAuthRouter(db, logAudit) {
|
||||
id: user.id,
|
||||
username: user.username,
|
||||
email: user.email,
|
||||
role: user.role
|
||||
group: user.user_group
|
||||
}
|
||||
});
|
||||
} catch (err) {
|
||||
@@ -129,7 +152,14 @@ function createAuthRouter(db, logAudit) {
|
||||
}
|
||||
});
|
||||
|
||||
// Logout
|
||||
/**
|
||||
* POST /api/auth/logout
|
||||
*
|
||||
* Ends the current user session by deleting it from the database
|
||||
* and clearing the session cookie.
|
||||
*
|
||||
* @returns {object} 200 - { message: 'Logged out successfully' }
|
||||
*/
|
||||
router.post('/logout', async (req, res) => {
|
||||
const sessionId = req.cookies?.session_id;
|
||||
|
||||
@@ -172,7 +202,16 @@ function createAuthRouter(db, logAudit) {
|
||||
res.json({ message: 'Logged out successfully' });
|
||||
});
|
||||
|
||||
// Get current user
|
||||
/**
|
||||
* GET /api/auth/me
|
||||
*
|
||||
* Returns the currently authenticated user based on the session cookie.
|
||||
* Clears the cookie and returns 401 if the session is expired or the account is disabled.
|
||||
*
|
||||
* @returns {object} 200 - { user: { id, username, email, group } }
|
||||
* @returns {object} 401 - { error: 'Not authenticated' } | { error: 'Session expired' } | { error: 'Account is disabled' }
|
||||
* @returns {object} 500 - { error: 'Failed to get user' }
|
||||
*/
|
||||
router.get('/me', async (req, res) => {
|
||||
const sessionId = req.cookies?.session_id;
|
||||
|
||||
@@ -183,7 +222,7 @@ function createAuthRouter(db, logAudit) {
|
||||
try {
|
||||
const session = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
`SELECT s.*, u.id as user_id, u.username, u.email, u.role, u.is_active
|
||||
`SELECT s.*, u.id as user_id, u.username, u.email, u.user_group, u.is_active
|
||||
FROM sessions s
|
||||
JOIN users u ON s.user_id = u.id
|
||||
WHERE s.session_id = ? AND s.expires_at > datetime('now')`,
|
||||
@@ -210,7 +249,7 @@ function createAuthRouter(db, logAudit) {
|
||||
id: session.user_id,
|
||||
username: session.username,
|
||||
email: session.email,
|
||||
role: session.role
|
||||
group: session.user_group
|
||||
}
|
||||
});
|
||||
} catch (err) {
|
||||
@@ -219,13 +258,17 @@ function createAuthRouter(db, logAudit) {
|
||||
}
|
||||
});
|
||||
|
||||
// Clean up expired sessions (admin only)
|
||||
router.post('/cleanup-sessions', async (req, res) => {
|
||||
// Basic auth check - require a valid session to call this
|
||||
const sessionId = req.cookies?.session_id;
|
||||
if (!sessionId) {
|
||||
return res.status(401).json({ error: 'Authentication required' });
|
||||
}
|
||||
/**
|
||||
* POST /api/auth/cleanup-sessions
|
||||
*
|
||||
* Deletes all expired sessions from the database. Requires Admin group.
|
||||
*
|
||||
* @returns {object} 200 - { message: 'Expired sessions cleaned up' }
|
||||
* @returns {object} 401 - { error: 'Authentication required' }
|
||||
* @returns {object} 403 - { error: 'Insufficient permissions', required: ['Admin'], current: '...' }
|
||||
* @returns {object} 500 - { error: 'Cleanup failed' }
|
||||
*/
|
||||
router.post('/cleanup-sessions', requireAuth(db), requireGroup('Admin'), async (req, res) => {
|
||||
try {
|
||||
await new Promise((resolve, reject) => {
|
||||
db.run(
|
||||
|
||||
@@ -213,7 +213,7 @@ function groupByHostname(rows, noteHostnames) {
|
||||
// ---------------------------------------------------------------------------
|
||||
// Router factory
|
||||
// ---------------------------------------------------------------------------
|
||||
function createComplianceRouter(db, upload, requireAuth, requireRole) {
|
||||
function createComplianceRouter(db, upload, requireAuth, requireGroup) {
|
||||
const router = express.Router();
|
||||
|
||||
// Idempotent column additions — errors mean column already exists, which is fine
|
||||
@@ -228,7 +228,7 @@ function createComplianceRouter(db, upload, requireAuth, requireRole) {
|
||||
// Parse the uploaded xlsx, compute diff, save parsed data to a temp JSON.
|
||||
// Returns diff counts + tempFile path for the commit step.
|
||||
// -----------------------------------------------------------------------
|
||||
router.post('/preview', requireRole('editor', 'admin'), (req, res) => {
|
||||
router.post('/preview', requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
upload.single('file')(req, res, async (uploadErr) => {
|
||||
if (uploadErr) {
|
||||
return res.status(400).json({ error: uploadErr.message });
|
||||
@@ -260,7 +260,7 @@ function createComplianceRouter(db, upload, requireAuth, requireRole) {
|
||||
items: parsed.items,
|
||||
summary: parsed.summary,
|
||||
report_date: parsed.report_date,
|
||||
filename: req.file.originalname,
|
||||
filename: req.file.originalname.replace(/[^\w.\-() ]/g, '_'),
|
||||
}));
|
||||
|
||||
// Delete the original xlsx from temp (we only need the JSON now)
|
||||
@@ -291,7 +291,7 @@ function createComplianceRouter(db, upload, requireAuth, requireRole) {
|
||||
// Commit a previewed upload to the DB.
|
||||
// Body: { tempFile, filename, report_date }
|
||||
// -----------------------------------------------------------------------
|
||||
router.post('/commit', requireRole('editor', 'admin'), async (req, res) => {
|
||||
router.post('/commit', requireGroup('Admin', 'Standard_User'), async (req, res) => {
|
||||
const { tempFile, filename, report_date } = req.body;
|
||||
|
||||
if (!tempFile || typeof tempFile !== 'string') {
|
||||
@@ -520,11 +520,11 @@ function createComplianceRouter(db, upload, requireAuth, requireRole) {
|
||||
// Add a note to a (hostname, metric_id) pair.
|
||||
// Body: { hostname, metric_id, note }
|
||||
// -----------------------------------------------------------------------
|
||||
router.post('/notes', async (req, res) => {
|
||||
router.post('/notes', requireGroup('Admin', 'Standard_User'), async (req, res) => {
|
||||
const { hostname, metric_id, note } = req.body;
|
||||
|
||||
if (!hostname || typeof hostname !== 'string' || hostname.length > 300) {
|
||||
return res.status(400).json({ error: 'Invalid hostname' });
|
||||
if (!hostname || typeof hostname !== 'string' || hostname.length > 300 || !/^[a-zA-Z0-9._-]+$/.test(hostname)) {
|
||||
return res.status(400).json({ error: 'Invalid hostname format' });
|
||||
}
|
||||
if (!metric_id || typeof metric_id !== 'string' || metric_id.length > 50) {
|
||||
return res.status(400).json({ error: 'Invalid metric_id' });
|
||||
|
||||
162
backend/routes/ivantiArchive.js
Normal file
162
backend/routes/ivantiArchive.js
Normal file
@@ -0,0 +1,162 @@
|
||||
// Ivanti Archive Routes — list, stats, and transition history for archived findings
|
||||
const express = require('express');
|
||||
|
||||
const VALID_STATES = ['ACTIVE', 'ARCHIVED', 'RETURNED', 'CLOSED'];
|
||||
|
||||
function createIvantiArchiveRouter(db, requireAuth) {
|
||||
const router = express.Router();
|
||||
|
||||
// All routes require authentication
|
||||
router.use(requireAuth(db));
|
||||
|
||||
/**
|
||||
* GET /
|
||||
* List archive records with optional state filtering.
|
||||
*
|
||||
* @query {string} [state] - Filter by lifecycle state (ACTIVE, ARCHIVED, RETURNED, CLOSED)
|
||||
* @returns {Object} 200 - { archives: Array<ArchiveRecord>, total: number }
|
||||
* @returns {Object} 400 - { error: string } when state param is invalid
|
||||
* @returns {Object} 500 - { error: string } on database failure
|
||||
*/
|
||||
router.get('/', async (req, res) => {
|
||||
const { state } = req.query;
|
||||
|
||||
if (state && !VALID_STATES.includes(state)) {
|
||||
return res.status(400).json({
|
||||
error: 'Invalid state parameter. Valid values: ACTIVE, ARCHIVED, RETURNED, CLOSED'
|
||||
});
|
||||
}
|
||||
|
||||
try {
|
||||
let query = 'SELECT * FROM ivanti_finding_archives';
|
||||
const params = [];
|
||||
|
||||
if (state) {
|
||||
query += ' WHERE current_state = ?';
|
||||
params.push(state);
|
||||
}
|
||||
|
||||
query += ' ORDER BY last_transition_at DESC';
|
||||
|
||||
const archives = await new Promise((resolve, reject) => {
|
||||
db.all(query, params, (err, rows) => {
|
||||
if (err) reject(err);
|
||||
else resolve(rows || []);
|
||||
});
|
||||
});
|
||||
|
||||
res.json({ archives, total: archives.length });
|
||||
} catch (err) {
|
||||
console.error('Archive list error:', err);
|
||||
res.status(500).json({ error: 'Failed to fetch archive records' });
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* GET /stats
|
||||
* Summary counts of archive records by lifecycle state.
|
||||
* ACTIVE is implicit: live findings in the cache that have no ARCHIVED/RETURNED archive record.
|
||||
*
|
||||
* @returns {Object} 200 - { ACTIVE: number, ARCHIVED: number, RETURNED: number, CLOSED: number, total: number }
|
||||
* @returns {Object} 500 - { error: string } on database failure
|
||||
*/
|
||||
router.get('/stats', async (req, res) => {
|
||||
try {
|
||||
// Count archive records by state
|
||||
const rows = await new Promise((resolve, reject) => {
|
||||
db.all(
|
||||
`SELECT current_state, COUNT(*) as count
|
||||
FROM ivanti_finding_archives
|
||||
GROUP BY current_state`,
|
||||
(err, rows) => {
|
||||
if (err) reject(err);
|
||||
else resolve(rows || []);
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
const stats = { ACTIVE: 0, ARCHIVED: 0, RETURNED: 0, CLOSED: 0 };
|
||||
|
||||
for (const row of rows) {
|
||||
if (stats.hasOwnProperty(row.current_state)) {
|
||||
stats[row.current_state] = row.count;
|
||||
}
|
||||
}
|
||||
|
||||
// Compute ACTIVE: total live findings minus those with ARCHIVED or RETURNED records
|
||||
const cacheRow = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
'SELECT total FROM ivanti_findings_cache WHERE id = 1',
|
||||
(err, row) => {
|
||||
if (err) reject(err);
|
||||
else resolve(row);
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
const liveFindingsCount = (cacheRow && cacheRow.total) || 0;
|
||||
// Findings that are ARCHIVED or RETURNED are "missing" from the live set,
|
||||
// so ACTIVE = live count (all findings currently present in sync results)
|
||||
stats.ACTIVE = liveFindingsCount;
|
||||
|
||||
const total = stats.ACTIVE + stats.ARCHIVED + stats.RETURNED + stats.CLOSED;
|
||||
|
||||
res.json({ ...stats, total });
|
||||
} catch (err) {
|
||||
console.error('Archive stats error:', err);
|
||||
res.status(500).json({ error: 'Failed to fetch archive stats' });
|
||||
}
|
||||
});
|
||||
|
||||
/**
|
||||
* GET /:findingId/history
|
||||
* Transition history for a specific archived finding, ordered by most recent first.
|
||||
* Returns an empty transitions array if the finding has no archive record.
|
||||
*
|
||||
* @param {string} findingId - Ivanti finding identifier (route param)
|
||||
* @returns {Object} 200 - { finding_id: string, transitions: Array<TransitionRecord> }
|
||||
* @returns {Object} 500 - { error: string } on database failure
|
||||
*/
|
||||
router.get('/:findingId/history', async (req, res) => {
|
||||
const { findingId } = req.params;
|
||||
|
||||
try {
|
||||
const archive = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
'SELECT id FROM ivanti_finding_archives WHERE finding_id = ?',
|
||||
[findingId],
|
||||
(err, row) => {
|
||||
if (err) reject(err);
|
||||
else resolve(row);
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
if (!archive) {
|
||||
return res.json({ finding_id: findingId, transitions: [] });
|
||||
}
|
||||
|
||||
const transitions = await new Promise((resolve, reject) => {
|
||||
db.all(
|
||||
`SELECT * FROM ivanti_archive_transitions
|
||||
WHERE archive_id = ?
|
||||
ORDER BY transitioned_at DESC`,
|
||||
[archive.id],
|
||||
(err, rows) => {
|
||||
if (err) reject(err);
|
||||
else resolve(rows || []);
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
res.json({ finding_id: findingId, transitions });
|
||||
} catch (err) {
|
||||
console.error('Archive history error:', err);
|
||||
res.status(500).json({ error: 'Failed to fetch transition history' });
|
||||
}
|
||||
});
|
||||
|
||||
return router;
|
||||
}
|
||||
|
||||
module.exports = createIvantiArchiveRouter;
|
||||
@@ -4,7 +4,7 @@
|
||||
|
||||
const express = require('express');
|
||||
const https = require('https');
|
||||
const { requireRole } = require('../middleware/auth');
|
||||
const { requireGroup } = require('../middleware/auth');
|
||||
|
||||
const IVANTI_URL_BASE = 'https://platform4.risksense.com/api/v1';
|
||||
const SYNC_INTERVAL_MS = 24 * 60 * 60 * 1000;
|
||||
@@ -192,6 +192,201 @@ function initTables(db) {
|
||||
});
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Archive table init — creates archive tracking tables alongside the main cache
|
||||
// ---------------------------------------------------------------------------
|
||||
function initArchiveTables(db) {
|
||||
return new Promise((resolve, reject) => {
|
||||
db.serialize(() => {
|
||||
db.run(`
|
||||
CREATE TABLE IF NOT EXISTS ivanti_finding_archives (
|
||||
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
finding_id TEXT NOT NULL UNIQUE,
|
||||
finding_title TEXT NOT NULL DEFAULT '',
|
||||
host_name TEXT NOT NULL DEFAULT '',
|
||||
ip_address TEXT NOT NULL DEFAULT '',
|
||||
current_state TEXT NOT NULL CHECK(current_state IN ('ARCHIVED','RETURNED','CLOSED')),
|
||||
last_severity REAL NOT NULL DEFAULT 0,
|
||||
first_archived_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
last_transition_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
created_at DATETIME DEFAULT CURRENT_TIMESTAMP
|
||||
)
|
||||
`, (err) => { if (err) return reject(err); });
|
||||
|
||||
db.run(`
|
||||
CREATE TABLE IF NOT EXISTS ivanti_archive_transitions (
|
||||
id INTEGER PRIMARY KEY AUTOINCREMENT,
|
||||
archive_id INTEGER NOT NULL,
|
||||
from_state TEXT NOT NULL,
|
||||
to_state TEXT NOT NULL,
|
||||
severity_at_transition REAL NOT NULL DEFAULT 0,
|
||||
reason TEXT NOT NULL DEFAULT '',
|
||||
transitioned_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
|
||||
FOREIGN KEY (archive_id) REFERENCES ivanti_finding_archives(id)
|
||||
)
|
||||
`, (err) => { if (err) return reject(err); });
|
||||
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_archive_finding_id
|
||||
ON ivanti_finding_archives(finding_id)
|
||||
`, (err) => { if (err) return reject(err); });
|
||||
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_archive_current_state
|
||||
ON ivanti_finding_archives(current_state)
|
||||
`, (err) => { if (err) return reject(err); });
|
||||
|
||||
db.run(`
|
||||
CREATE INDEX IF NOT EXISTS idx_transition_archive_id
|
||||
ON ivanti_archive_transitions(archive_id)
|
||||
`, (err) => {
|
||||
if (err) reject(err);
|
||||
else resolve();
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Archive detection — compare previous vs current findings to detect state changes
|
||||
// ---------------------------------------------------------------------------
|
||||
async function detectArchiveChanges(db, previousFindings, currentFindings) {
|
||||
const previousIds = new Set(previousFindings.map(f => String(f.id)));
|
||||
const currentIds = new Set(currentFindings.map(f => String(f.id)));
|
||||
|
||||
// Build lookup maps for metadata
|
||||
const previousMap = new Map(previousFindings.map(f => [String(f.id), f]));
|
||||
const currentMap = new Map(currentFindings.map(f => [String(f.id), f]));
|
||||
|
||||
// 1. Disappeared findings: in previous but not in current → ARCHIVED
|
||||
const disappearedIds = [...previousIds].filter(id => !currentIds.has(id));
|
||||
|
||||
for (const id of disappearedIds) {
|
||||
const finding = previousMap.get(id);
|
||||
const title = finding.title || '';
|
||||
const hostName = finding.hostName || '';
|
||||
const ipAddress = finding.ipAddress || '';
|
||||
const severity = typeof finding.severity === 'number' ? finding.severity : 0;
|
||||
|
||||
try {
|
||||
// Check if this finding already has an archive record
|
||||
const existing = await dbGet(db,
|
||||
`SELECT id, current_state FROM ivanti_finding_archives WHERE finding_id = ?`,
|
||||
[id]
|
||||
);
|
||||
|
||||
if (existing && existing.current_state === 'RETURNED') {
|
||||
// Re-disappeared: RETURNED → ARCHIVED
|
||||
await dbRun(db,
|
||||
`UPDATE ivanti_finding_archives
|
||||
SET current_state = 'ARCHIVED', last_severity = ?, last_transition_at = datetime('now')
|
||||
WHERE id = ?`,
|
||||
[severity, existing.id]
|
||||
);
|
||||
await dbRun(db,
|
||||
`INSERT INTO ivanti_archive_transitions (archive_id, from_state, to_state, severity_at_transition, reason, transitioned_at)
|
||||
VALUES (?, 'RETURNED', 'ARCHIVED', ?, 'severity_score_drift', datetime('now'))`,
|
||||
[existing.id, severity]
|
||||
);
|
||||
console.log(`[Archive Detection] Finding ${id} re-archived (RETURNED → ARCHIVED)`);
|
||||
} else if (!existing) {
|
||||
// First disappearance: NONE → ARCHIVED
|
||||
const result = await dbRun(db,
|
||||
`INSERT INTO ivanti_finding_archives (finding_id, finding_title, host_name, ip_address, current_state, last_severity, first_archived_at, last_transition_at)
|
||||
VALUES (?, ?, ?, ?, 'ARCHIVED', ?, datetime('now'), datetime('now'))`,
|
||||
[id, title, hostName, ipAddress, severity]
|
||||
);
|
||||
const archiveId = result.lastID;
|
||||
await dbRun(db,
|
||||
`INSERT INTO ivanti_archive_transitions (archive_id, from_state, to_state, severity_at_transition, reason, transitioned_at)
|
||||
VALUES (?, 'NONE', 'ARCHIVED', ?, 'severity_score_drift', datetime('now'))`,
|
||||
[archiveId, severity]
|
||||
);
|
||||
console.log(`[Archive Detection] Finding ${id} archived (NONE → ARCHIVED)`);
|
||||
}
|
||||
// If existing state is ARCHIVED or CLOSED, no action needed
|
||||
} catch (err) {
|
||||
console.error(`[Archive Detection] Error processing disappeared finding ${id}:`, err.message);
|
||||
}
|
||||
}
|
||||
|
||||
// 2. Returned findings: in current AND has existing ARCHIVED record → RETURNED
|
||||
const currentIdsList = [...currentIds];
|
||||
if (currentIdsList.length > 0) {
|
||||
try {
|
||||
const archivedRecords = await dbAll(db,
|
||||
`SELECT id, finding_id FROM ivanti_finding_archives WHERE current_state = 'ARCHIVED'`
|
||||
);
|
||||
|
||||
for (const record of archivedRecords) {
|
||||
if (currentIds.has(record.finding_id)) {
|
||||
const finding = currentMap.get(record.finding_id);
|
||||
const severity = typeof finding.severity === 'number' ? finding.severity : 0;
|
||||
|
||||
await dbRun(db,
|
||||
`UPDATE ivanti_finding_archives
|
||||
SET current_state = 'RETURNED', last_severity = ?, last_transition_at = datetime('now')
|
||||
WHERE id = ?`,
|
||||
[severity, record.id]
|
||||
);
|
||||
await dbRun(db,
|
||||
`INSERT INTO ivanti_archive_transitions (archive_id, from_state, to_state, severity_at_transition, reason, transitioned_at)
|
||||
VALUES (?, 'ARCHIVED', 'RETURNED', ?, 'reappeared_in_sync', datetime('now'))`,
|
||||
[record.id, severity]
|
||||
);
|
||||
console.log(`[Archive Detection] Finding ${record.finding_id} returned (ARCHIVED → RETURNED)`);
|
||||
}
|
||||
}
|
||||
} catch (err) {
|
||||
console.error('[Archive Detection] Error processing returned findings:', err.message);
|
||||
}
|
||||
}
|
||||
|
||||
console.log(`[Archive Detection] Processed ${disappearedIds.length} disappeared, checked ${currentIdsList.length} current findings against archive`);
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Closed finding detection — check archived/returned findings against Ivanti closed set
|
||||
// ---------------------------------------------------------------------------
|
||||
async function detectClosedFindings(db, closedFindingIds) {
|
||||
if (!closedFindingIds || closedFindingIds.length === 0) return;
|
||||
|
||||
const closedSet = new Set(closedFindingIds.map(String));
|
||||
|
||||
try {
|
||||
const records = await dbAll(db,
|
||||
`SELECT id, finding_id, current_state, last_severity FROM ivanti_finding_archives WHERE current_state IN ('ARCHIVED', 'RETURNED')`
|
||||
);
|
||||
|
||||
let closedCount = 0;
|
||||
for (const record of records) {
|
||||
if (!closedSet.has(record.finding_id)) continue;
|
||||
|
||||
try {
|
||||
await dbRun(db,
|
||||
`UPDATE ivanti_finding_archives
|
||||
SET current_state = 'CLOSED', last_transition_at = datetime('now')
|
||||
WHERE id = ?`,
|
||||
[record.id]
|
||||
);
|
||||
await dbRun(db,
|
||||
`INSERT INTO ivanti_archive_transitions (archive_id, from_state, to_state, severity_at_transition, reason, transitioned_at)
|
||||
VALUES (?, ?, 'CLOSED', ?, 'remediated_in_ivanti', datetime('now'))`,
|
||||
[record.id, record.current_state, record.last_severity || 0]
|
||||
);
|
||||
closedCount++;
|
||||
console.log(`[Archive Detection] Finding ${record.finding_id} closed (${record.current_state} → CLOSED)`);
|
||||
} catch (err) {
|
||||
console.error(`[Archive Detection] Error closing finding ${record.finding_id}:`, err.message);
|
||||
}
|
||||
}
|
||||
|
||||
console.log(`[Archive Detection] Closed ${closedCount} findings as remediated`);
|
||||
} catch (err) {
|
||||
console.error('[Archive Detection] Error querying archive records for closed detection:', err.message);
|
||||
}
|
||||
}
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// Extract only the fields we need from a raw finding object
|
||||
// ---------------------------------------------------------------------------
|
||||
@@ -266,7 +461,7 @@ async function syncClosedCount(db, openCount, apiKey, clientId, skipTls) {
|
||||
projection: 'internal',
|
||||
sort: [{ field: 'severity', direction: 'ASC' }],
|
||||
page: 0,
|
||||
size: 1
|
||||
size: 100
|
||||
};
|
||||
|
||||
const result = await ivantiPost(urlPath, body, apiKey, skipTls);
|
||||
@@ -275,6 +470,27 @@ async function syncClosedCount(db, openCount, apiKey, clientId, skipTls) {
|
||||
const data = JSON.parse(result.body);
|
||||
// RiskSense returns total in page.totalElements or page.total
|
||||
const closedCount = data.page?.totalElements ?? data.page?.total ?? 0;
|
||||
const totalPages = data.page?.totalPages || 1;
|
||||
|
||||
// Collect closed finding IDs for archive detection
|
||||
const closedFindingIds = [];
|
||||
const firstPageFindings = data._embedded?.hostFindings || [];
|
||||
firstPageFindings.forEach(f => { if (f.id) closedFindingIds.push(String(f.id)); });
|
||||
|
||||
// Fetch remaining pages to collect all closed finding IDs
|
||||
for (let pg = 1; pg < totalPages; pg++) {
|
||||
try {
|
||||
const pageBody = { ...body, page: pg };
|
||||
const pageResult = await ivantiPost(urlPath, pageBody, apiKey, skipTls);
|
||||
if (pageResult.status !== 200) break;
|
||||
const pageData = JSON.parse(pageResult.body);
|
||||
const pageFindings = pageData._embedded?.hostFindings || [];
|
||||
pageFindings.forEach(f => { if (f.id) closedFindingIds.push(String(f.id)); });
|
||||
} catch (err) {
|
||||
console.error(`[Ivanti Findings] Failed to fetch closed findings page ${pg}:`, err.message);
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
await dbRun(db,
|
||||
`UPDATE ivanti_counts_cache SET open_count=?, closed_count=?, synced_at=datetime('now') WHERE id=1`,
|
||||
@@ -289,6 +505,13 @@ async function syncClosedCount(db, openCount, apiKey, clientId, skipTls) {
|
||||
);
|
||||
|
||||
console.log(`[Ivanti Findings] Counts updated — open: ${openCount}, closed: ${closedCount}`);
|
||||
|
||||
// Detect closed findings in the archive — wrap in try/catch so errors don't break sync
|
||||
try {
|
||||
await detectClosedFindings(db, closedFindingIds);
|
||||
} catch (err) {
|
||||
console.error('[Ivanti Findings] Closed finding archive detection failed (non-fatal):', err.message);
|
||||
}
|
||||
} catch (err) {
|
||||
console.error('[Ivanti Findings] Failed to fetch closed count:', err.message);
|
||||
// Still update open count so it stays in sync; leave closed_count as-is
|
||||
@@ -441,17 +664,36 @@ async function syncFindings(db) {
|
||||
page++;
|
||||
} while (page < totalPages);
|
||||
|
||||
// Read previous findings BEFORE updating the cache (they'll be overwritten)
|
||||
let previousFindings = [];
|
||||
try {
|
||||
const state = await readState(db);
|
||||
previousFindings = state.findings || [];
|
||||
} catch (err) {
|
||||
console.error('[Ivanti Findings] Failed to read previous findings for archive detection:', err.message);
|
||||
}
|
||||
|
||||
await dbRun(db,
|
||||
`UPDATE ivanti_findings_cache SET total=?, findings_json=?, synced_at=datetime('now'), sync_status='success', error_message=NULL WHERE id=1`,
|
||||
[allFindings.length, JSON.stringify(allFindings)]
|
||||
);
|
||||
|
||||
console.log(`[Ivanti Findings] Sync complete — ${allFindings.length} findings`);
|
||||
|
||||
// Archive detection — compare previous vs current to detect disappeared/returned findings
|
||||
// Only runs after a successful sync (skipped on error per requirement 1.5)
|
||||
try {
|
||||
await detectArchiveChanges(db, previousFindings, allFindings);
|
||||
} catch (err) {
|
||||
console.error('[Ivanti Findings] Archive detection failed (non-fatal):', err.message);
|
||||
}
|
||||
|
||||
await syncClosedCount(db, allFindings.length, apiKey, clientId, skipTls);
|
||||
await syncFPWorkflowCounts(db, allFindings, apiKey, clientId, skipTls);
|
||||
} catch (err) {
|
||||
const msg = err.message || 'Unknown error';
|
||||
console.error('[Ivanti Findings] Sync failed:', msg);
|
||||
// Archive detection is intentionally skipped on sync error (requirement 1.5)
|
||||
await dbRun(db, `UPDATE ivanti_findings_cache SET sync_status='error', error_message=?, synced_at=datetime('now') WHERE id=1`, [msg]);
|
||||
}
|
||||
}
|
||||
@@ -482,7 +724,19 @@ function scheduleSync(db) {
|
||||
// ---------------------------------------------------------------------------
|
||||
function dbRun(db, sql, params = []) {
|
||||
return new Promise((resolve, reject) => {
|
||||
db.run(sql, params, (err) => { if (err) reject(err); else resolve(); });
|
||||
db.run(sql, params, function (err) { if (err) reject(err); else resolve(this); });
|
||||
});
|
||||
}
|
||||
|
||||
function dbGet(db, sql, params = []) {
|
||||
return new Promise((resolve, reject) => {
|
||||
db.get(sql, params, (err, row) => { if (err) reject(err); else resolve(row); });
|
||||
});
|
||||
}
|
||||
|
||||
function dbAll(db, sql, params = []) {
|
||||
return new Promise((resolve, reject) => {
|
||||
db.all(sql, params, (err, rows) => { if (err) reject(err); else resolve(rows || []); });
|
||||
});
|
||||
}
|
||||
|
||||
@@ -559,7 +813,7 @@ async function readStateWithNotes(db) {
|
||||
function createIvantiFindingsRouter(db, requireAuth) {
|
||||
const router = express.Router();
|
||||
|
||||
initTables(db)
|
||||
Promise.all([initTables(db), initArchiveTables(db)])
|
||||
.then(() => scheduleSync(db))
|
||||
.catch((err) => console.error('[Ivanti Findings] Init failed:', err));
|
||||
|
||||
@@ -575,7 +829,7 @@ function createIvantiFindingsRouter(db, requireAuth) {
|
||||
});
|
||||
|
||||
// POST /sync — trigger immediate sync, return fresh state
|
||||
router.post('/sync', async (req, res) => {
|
||||
router.post('/sync', requireGroup('Admin', 'Standard_User'), async (req, res) => {
|
||||
await syncFindings(db);
|
||||
try {
|
||||
res.json(await readStateWithNotes(db));
|
||||
@@ -645,7 +899,7 @@ function createIvantiFindingsRouter(db, requireAuth) {
|
||||
|
||||
// PUT /:findingId/override — save or clear a field override (editor/admin only)
|
||||
const OVERRIDE_ALLOWED = ['hostName', 'dns'];
|
||||
router.put('/:findingId/override', requireRole('editor', 'admin'), (req, res) => {
|
||||
router.put('/:findingId/override', requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { findingId } = req.params;
|
||||
const { field, value } = req.body;
|
||||
|
||||
@@ -680,7 +934,7 @@ function createIvantiFindingsRouter(db, requireAuth) {
|
||||
});
|
||||
|
||||
// PUT /:findingId/note — save or update a note (max 255 chars enforced here)
|
||||
router.put('/:findingId/note', (req, res) => {
|
||||
router.put('/:findingId/note', requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { findingId } = req.params;
|
||||
const note = String(req.body.note || '').slice(0, 255);
|
||||
|
||||
@@ -700,3 +954,6 @@ function createIvantiFindingsRouter(db, requireAuth) {
|
||||
}
|
||||
|
||||
module.exports = createIvantiFindingsRouter;
|
||||
module.exports.detectArchiveChanges = detectArchiveChanges;
|
||||
module.exports.detectClosedFindings = detectClosedFindings;
|
||||
module.exports.initArchiveTables = initArchiveTables;
|
||||
|
||||
@@ -1,11 +1,14 @@
|
||||
// routes/ivantiTodoQueue.js
|
||||
const express = require('express');
|
||||
const { requireGroup } = require('../middleware/auth');
|
||||
|
||||
const VALID_WORKFLOW_TYPES = ['FP', 'Archer', 'CARD'];
|
||||
const VALID_STATUSES = ['pending', 'complete'];
|
||||
|
||||
function isValidVendor(vendor) {
|
||||
return typeof vendor === 'string' && vendor.trim().length > 0 && vendor.length <= 200;
|
||||
if (typeof vendor !== 'string') return false;
|
||||
const trimmed = vendor.trim();
|
||||
return trimmed.length > 0 && trimmed.length <= 200;
|
||||
}
|
||||
|
||||
function createIvantiTodoQueueRouter(db, requireAuth) {
|
||||
@@ -36,7 +39,7 @@ function createIvantiTodoQueueRouter(db, requireAuth) {
|
||||
|
||||
// POST /api/ivanti/todo-queue
|
||||
// Add a finding to the queue
|
||||
router.post('/', requireAuth(db), (req, res) => {
|
||||
router.post('/', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { finding_id, finding_title, cves, ip_address, vendor, workflow_type } = req.body;
|
||||
|
||||
if (!finding_id || typeof finding_id !== 'string' || finding_id.trim().length === 0) {
|
||||
@@ -86,7 +89,7 @@ function createIvantiTodoQueueRouter(db, requireAuth) {
|
||||
|
||||
// PUT /api/ivanti/todo-queue/:id
|
||||
// Update vendor, workflow_type, or status — scoped to current user
|
||||
router.put('/:id', requireAuth(db), (req, res) => {
|
||||
router.put('/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
const { vendor, workflow_type, status } = req.body;
|
||||
|
||||
@@ -162,7 +165,7 @@ function createIvantiTodoQueueRouter(db, requireAuth) {
|
||||
// DELETE /api/ivanti/todo-queue/completed
|
||||
// Bulk-delete all completed items for the current user
|
||||
// IMPORTANT: This route must be registered BEFORE DELETE /:id
|
||||
router.delete('/completed', requireAuth(db), (req, res) => {
|
||||
router.delete('/completed', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
db.run(
|
||||
"DELETE FROM ivanti_todo_queue WHERE user_id = ? AND status = 'complete'",
|
||||
[req.user.id],
|
||||
@@ -178,7 +181,7 @@ function createIvantiTodoQueueRouter(db, requireAuth) {
|
||||
|
||||
// DELETE /api/ivanti/todo-queue/:id
|
||||
// Delete a single item — scoped to current user
|
||||
router.delete('/:id', requireAuth(db), (req, res) => {
|
||||
router.delete('/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
db.get(
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
|
||||
const express = require('express');
|
||||
const https = require('https');
|
||||
const { requireGroup } = require('../middleware/auth');
|
||||
|
||||
const IVANTI_URL_BASE = 'https://platform4.risksense.com/api/v1';
|
||||
const SYNC_INTERVAL_MS = 24 * 60 * 60 * 1000; // 24 hours
|
||||
@@ -259,7 +260,7 @@ function createIvantiWorkflowsRouter(db, requireAuth) {
|
||||
});
|
||||
|
||||
// POST /sync — trigger an immediate sync, await completion, return fresh state
|
||||
router.post('/sync', async (req, res) => {
|
||||
router.post('/sync', requireGroup('Admin', 'Standard_User'), async (req, res) => {
|
||||
await syncWorkflows(db);
|
||||
try {
|
||||
res.json(await readState(db));
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
const express = require('express');
|
||||
const path = require('path');
|
||||
const fs = require('fs');
|
||||
const { requireAuth, requireRole } = require('../middleware/auth');
|
||||
const { requireAuth, requireGroup } = require('../middleware/auth');
|
||||
const logAudit = require('../helpers/auditLog');
|
||||
|
||||
function createKnowledgeBaseRouter(db, upload) {
|
||||
@@ -39,8 +39,20 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
return ALLOWED_EXTENSIONS.has(ext);
|
||||
}
|
||||
|
||||
// POST /api/knowledge-base/upload - Upload new document
|
||||
router.post('/upload', requireAuth(db), requireRole(db, 'editor', 'admin'), (req, res, next) => {
|
||||
/**
|
||||
* POST /api/knowledge-base/upload
|
||||
* Upload a new knowledge base document.
|
||||
*
|
||||
* @body {string} title - Article title (required)
|
||||
* @body {string} [description] - Article description
|
||||
* @body {string} [category] - Article category (defaults to 'General')
|
||||
* @body {File} file - The document file to upload (multipart/form-data)
|
||||
*
|
||||
* @response 200 - { success: true, id: number, title: string, slug: string, category: string }
|
||||
* @response 400 - { error: string } - Missing title, no file, or invalid file type
|
||||
* @response 500 - { error: string } - Database or filesystem error
|
||||
*/
|
||||
router.post('/upload', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res, next) => {
|
||||
upload.single('file')(req, res, (err) => {
|
||||
if (err) {
|
||||
console.error('[KB Upload] Multer error:', err);
|
||||
@@ -80,22 +92,15 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
const slug = generateSlug(title);
|
||||
const kbDir = path.join(__dirname, '..', 'uploads', 'knowledge_base');
|
||||
|
||||
// Create directory if it doesn't exist
|
||||
if (!fs.existsSync(kbDir)) {
|
||||
fs.mkdirSync(kbDir, { recursive: true });
|
||||
}
|
||||
|
||||
const filename = `${timestamp}_${sanitizedName}`;
|
||||
const filePath = path.join(kbDir, filename);
|
||||
|
||||
try {
|
||||
// Move uploaded file to permanent location
|
||||
fs.renameSync(uploadedFile.path, filePath);
|
||||
|
||||
// Keep file in temp location until DB insert succeeds
|
||||
// Check if slug already exists
|
||||
db.get('SELECT id FROM knowledge_base WHERE slug = ?', [slug], (err, row) => {
|
||||
if (err) {
|
||||
fs.unlinkSync(filePath);
|
||||
fs.unlinkSync(uploadedFile.path);
|
||||
console.error('Error checking slug:', err);
|
||||
return res.status(500).json({ error: 'Database error' });
|
||||
}
|
||||
@@ -126,22 +131,32 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
],
|
||||
function (err) {
|
||||
if (err) {
|
||||
fs.unlinkSync(filePath);
|
||||
fs.unlinkSync(uploadedFile.path);
|
||||
console.error('Error inserting knowledge base entry:', err);
|
||||
return res.status(500).json({ error: 'Failed to save document metadata' });
|
||||
}
|
||||
|
||||
// DB insert succeeded — now move file to permanent location
|
||||
try {
|
||||
if (!fs.existsSync(kbDir)) {
|
||||
fs.mkdirSync(kbDir, { recursive: true });
|
||||
}
|
||||
fs.renameSync(uploadedFile.path, filePath);
|
||||
} catch (moveErr) {
|
||||
console.error('Error moving file to permanent location:', moveErr);
|
||||
// File is orphaned in temp but DB record exists — log and continue
|
||||
}
|
||||
|
||||
// Log audit entry
|
||||
logAudit(
|
||||
db,
|
||||
req.user.id,
|
||||
req.user.username,
|
||||
'CREATE_KB_ARTICLE',
|
||||
'knowledge_base',
|
||||
this.lastID,
|
||||
JSON.stringify({ title: title.trim(), filename: sanitizedName }),
|
||||
req.ip
|
||||
);
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'CREATE_KB_ARTICLE',
|
||||
entityType: 'knowledge_base',
|
||||
entityId: String(this.lastID),
|
||||
details: { title: title.trim(), filename: sanitizedName },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
res.json({
|
||||
success: true,
|
||||
@@ -154,14 +169,20 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
);
|
||||
});
|
||||
} catch (error) {
|
||||
// Clean up file on error
|
||||
if (fs.existsSync(filePath)) fs.unlinkSync(filePath);
|
||||
// Clean up temp file on error
|
||||
if (uploadedFile && fs.existsSync(uploadedFile.path)) fs.unlinkSync(uploadedFile.path);
|
||||
console.error('Error uploading knowledge base document:', error);
|
||||
res.status(500).json({ error: error.message || 'Failed to upload document' });
|
||||
}
|
||||
});
|
||||
|
||||
// GET /api/knowledge-base - List all articles
|
||||
/**
|
||||
* GET /api/knowledge-base
|
||||
* List all knowledge base articles.
|
||||
*
|
||||
* @response 200 - Array of article objects: [{ id, title, slug, description, category, file_name, file_type, file_size, created_at, updated_at, created_by_username }]
|
||||
* @response 500 - { error: string }
|
||||
*/
|
||||
router.get('/', requireAuth(db), (req, res) => {
|
||||
const sql = `
|
||||
SELECT
|
||||
@@ -183,7 +204,16 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
});
|
||||
});
|
||||
|
||||
// GET /api/knowledge-base/:id - Get single article details
|
||||
/**
|
||||
* GET /api/knowledge-base/:id
|
||||
* Get a single article's details by ID.
|
||||
*
|
||||
* @param {string} id - Article ID (route parameter)
|
||||
*
|
||||
* @response 200 - { id, title, slug, description, category, file_name, file_type, file_size, created_at, updated_at, created_by_username }
|
||||
* @response 404 - { error: 'Article not found' }
|
||||
* @response 500 - { error: string }
|
||||
*/
|
||||
router.get('/:id', requireAuth(db), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
@@ -211,7 +241,17 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
});
|
||||
});
|
||||
|
||||
// GET /api/knowledge-base/:id/content - Get document content for display
|
||||
/**
|
||||
* GET /api/knowledge-base/:id/content
|
||||
* Get document content for inline display. Returns the raw file with appropriate
|
||||
* Content-Type headers. Markdown and text files are served as text/plain.
|
||||
*
|
||||
* @param {string} id - Article ID (route parameter)
|
||||
*
|
||||
* @response 200 - Raw file content with Content-Type and Content-Disposition headers
|
||||
* @response 404 - { error: string } - Article or file not found
|
||||
* @response 500 - { error: string }
|
||||
*/
|
||||
router.get('/:id/content', requireAuth(db), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
@@ -232,16 +272,15 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
}
|
||||
|
||||
// Log audit entry
|
||||
logAudit(
|
||||
db,
|
||||
req.user.id,
|
||||
req.user.username,
|
||||
'VIEW_KB_ARTICLE',
|
||||
'knowledge_base',
|
||||
id,
|
||||
JSON.stringify({ filename: row.file_name }),
|
||||
req.ip
|
||||
);
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'VIEW_KB_ARTICLE',
|
||||
entityType: 'knowledge_base',
|
||||
entityId: String(id),
|
||||
details: { filename: row.file_name },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
// Determine content type for inline display
|
||||
let contentType = row.file_type || 'application/octet-stream';
|
||||
@@ -253,17 +292,28 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
contentType = 'text/plain; charset=utf-8';
|
||||
}
|
||||
|
||||
const safeFileName = row.file_name.replace(/["\r\n\\]/g, '');
|
||||
res.setHeader('Content-Type', contentType);
|
||||
// Use inline instead of attachment to allow browser to display
|
||||
res.setHeader('Content-Disposition', `inline; filename="${row.file_name}"`);
|
||||
res.setHeader('Content-Disposition', `inline; filename="${safeFileName}"`);
|
||||
// Allow iframe embedding from frontend origin
|
||||
res.removeHeader('X-Frame-Options');
|
||||
res.setHeader('Content-Security-Policy', "frame-ancestors 'self' http://71.85.90.9:3000 http://localhost:3000");
|
||||
const corsOrigins = process.env.CORS_ORIGINS ? process.env.CORS_ORIGINS.split(',').join(' ') : 'http://localhost:3000';
|
||||
res.setHeader('Content-Security-Policy', `frame-ancestors 'self' ${corsOrigins}`);
|
||||
res.sendFile(row.file_path);
|
||||
});
|
||||
});
|
||||
|
||||
// GET /api/knowledge-base/:id/download - Download document
|
||||
/**
|
||||
* GET /api/knowledge-base/:id/download
|
||||
* Download a knowledge base document as an attachment.
|
||||
*
|
||||
* @param {string} id - Article ID (route parameter)
|
||||
*
|
||||
* @response 200 - File download with Content-Disposition: attachment header
|
||||
* @response 404 - { error: string } - Article or file not found
|
||||
* @response 500 - { error: string }
|
||||
*/
|
||||
router.get('/:id/download', requireAuth(db), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
@@ -284,28 +334,39 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
}
|
||||
|
||||
// Log audit entry
|
||||
logAudit(
|
||||
db,
|
||||
req.user.id,
|
||||
req.user.username,
|
||||
'DOWNLOAD_KB_ARTICLE',
|
||||
'knowledge_base',
|
||||
id,
|
||||
JSON.stringify({ filename: row.file_name }),
|
||||
req.ip
|
||||
);
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'DOWNLOAD_KB_ARTICLE',
|
||||
entityType: 'knowledge_base',
|
||||
entityId: String(id),
|
||||
details: { filename: row.file_name },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
const safeDownloadName = row.file_name.replace(/["\r\n\\]/g, '');
|
||||
res.setHeader('Content-Type', row.file_type || 'application/octet-stream');
|
||||
res.setHeader('Content-Disposition', `attachment; filename="${row.file_name}"`);
|
||||
res.setHeader('Content-Disposition', `attachment; filename="${safeDownloadName}"`);
|
||||
res.sendFile(row.file_path);
|
||||
});
|
||||
});
|
||||
|
||||
// DELETE /api/knowledge-base/:id - Delete article
|
||||
router.delete('/:id', requireAuth(db), requireRole(db, 'editor', 'admin'), (req, res) => {
|
||||
/**
|
||||
* DELETE /api/knowledge-base/:id
|
||||
* Delete a knowledge base article and its associated file.
|
||||
* Standard_User can only delete articles they created. Admin can delete any article.
|
||||
*
|
||||
* @param {string} id - Article ID (route parameter)
|
||||
*
|
||||
* @response 200 - { success: true }
|
||||
* @response 403 - { error: string } - Ownership check failed for Standard_User
|
||||
* @response 404 - { error: 'Article not found' }
|
||||
* @response 500 - { error: string }
|
||||
*/
|
||||
router.delete('/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
const sql = 'SELECT file_path, title FROM knowledge_base WHERE id = ?';
|
||||
const sql = 'SELECT file_path, title, created_by FROM knowledge_base WHERE id = ?';
|
||||
|
||||
db.get(sql, [id], (err, row) => {
|
||||
if (err) {
|
||||
@@ -317,6 +378,11 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
return res.status(404).json({ error: 'Article not found' });
|
||||
}
|
||||
|
||||
// Ownership check: Standard_User can only delete articles they created
|
||||
if (req.user.group === 'Standard_User' && row.created_by !== req.user.id) {
|
||||
return res.status(403).json({ error: 'You can only delete resources you created' });
|
||||
}
|
||||
|
||||
// Delete database record
|
||||
db.run('DELETE FROM knowledge_base WHERE id = ?', [id], (err) => {
|
||||
if (err) {
|
||||
@@ -330,16 +396,15 @@ function createKnowledgeBaseRouter(db, upload) {
|
||||
}
|
||||
|
||||
// Log audit entry
|
||||
logAudit(
|
||||
db,
|
||||
req.user.id,
|
||||
req.user.username,
|
||||
'DELETE_KB_ARTICLE',
|
||||
'knowledge_base',
|
||||
id,
|
||||
JSON.stringify({ title: row.title }),
|
||||
req.ip
|
||||
);
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'DELETE_KB_ARTICLE',
|
||||
entityType: 'knowledge_base',
|
||||
entityId: String(id),
|
||||
details: { title: row.title },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
res.json({ success: true });
|
||||
});
|
||||
|
||||
@@ -2,18 +2,18 @@
|
||||
const express = require('express');
|
||||
const bcrypt = require('bcryptjs');
|
||||
|
||||
function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
function createUsersRouter(db, requireAuth, requireGroup, logAudit) {
|
||||
const router = express.Router();
|
||||
|
||||
// All routes require admin role
|
||||
router.use(requireAuth(db), requireRole('admin'));
|
||||
// All routes require Admin group
|
||||
router.use(requireAuth(db), requireGroup('Admin'));
|
||||
|
||||
// Get all users
|
||||
router.get('/', async (req, res) => {
|
||||
try {
|
||||
const users = await new Promise((resolve, reject) => {
|
||||
db.all(
|
||||
`SELECT id, username, email, role, is_active, created_at, last_login
|
||||
`SELECT id, username, email, user_group AS 'group', is_active, created_at, last_login
|
||||
FROM users ORDER BY created_at DESC`,
|
||||
(err, rows) => {
|
||||
if (err) reject(err);
|
||||
@@ -33,7 +33,7 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
try {
|
||||
const user = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
`SELECT id, username, email, role, is_active, created_at, last_login
|
||||
`SELECT id, username, email, user_group AS 'group', is_active, created_at, last_login
|
||||
FROM users WHERE id = ?`,
|
||||
[req.params.id],
|
||||
(err, row) => {
|
||||
@@ -56,14 +56,17 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
|
||||
// Create new user
|
||||
router.post('/', async (req, res) => {
|
||||
const { username, email, password, role } = req.body;
|
||||
const { username, email, password, group } = req.body;
|
||||
const VALID_GROUPS = ['Admin', 'Standard_User', 'Leadership', 'Read_Only'];
|
||||
|
||||
if (!username || !email || !password) {
|
||||
return res.status(400).json({ error: 'Username, email, and password are required' });
|
||||
}
|
||||
|
||||
if (role && !['admin', 'editor', 'viewer'].includes(role)) {
|
||||
return res.status(400).json({ error: 'Invalid role. Must be admin, editor, or viewer' });
|
||||
const userGroup = group || 'Read_Only';
|
||||
|
||||
if (!VALID_GROUPS.includes(userGroup)) {
|
||||
return res.status(400).json({ error: 'Invalid group. Must be one of: Admin, Standard_User, Leadership, Read_Only' });
|
||||
}
|
||||
|
||||
try {
|
||||
@@ -71,9 +74,9 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
|
||||
const result = await new Promise((resolve, reject) => {
|
||||
db.run(
|
||||
`INSERT INTO users (username, email, password_hash, role)
|
||||
`INSERT INTO users (username, email, password_hash, user_group)
|
||||
VALUES (?, ?, ?, ?)`,
|
||||
[username, email, passwordHash, role || 'viewer'],
|
||||
[username, email, passwordHash, userGroup],
|
||||
function(err) {
|
||||
if (err) reject(err);
|
||||
else resolve({ id: this.lastID });
|
||||
@@ -87,7 +90,7 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
action: 'user_create',
|
||||
entityType: 'user',
|
||||
entityId: String(result.id),
|
||||
details: { created_username: username, role: role || 'viewer' },
|
||||
details: { created_username: username, group: userGroup },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
@@ -97,7 +100,7 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
id: result.id,
|
||||
username,
|
||||
email,
|
||||
role: role || 'viewer'
|
||||
group: userGroup
|
||||
}
|
||||
});
|
||||
} catch (err) {
|
||||
@@ -111,20 +114,42 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
|
||||
// Update user
|
||||
router.patch('/:id', async (req, res) => {
|
||||
const { username, email, password, role, is_active } = req.body;
|
||||
const { username, email, password, group, is_active } = req.body;
|
||||
const VALID_GROUPS = ['Admin', 'Standard_User', 'Leadership', 'Read_Only'];
|
||||
const userId = req.params.id;
|
||||
|
||||
// Prevent self-demotion from admin
|
||||
if (userId == req.user.id && role && role !== 'admin') {
|
||||
return res.status(400).json({ error: 'Cannot remove your own admin role' });
|
||||
// Validate group if provided
|
||||
if (group && !VALID_GROUPS.includes(group)) {
|
||||
return res.status(400).json({ error: 'Invalid group. Must be one of: Admin, Standard_User, Leadership, Read_Only' });
|
||||
}
|
||||
|
||||
// Prevent admin self-demotion
|
||||
if (String(userId) === String(req.user.id) && group && group !== 'Admin') {
|
||||
return res.status(400).json({ error: 'Cannot remove your own admin group' });
|
||||
}
|
||||
|
||||
// Prevent self-deactivation
|
||||
if (userId == req.user.id && is_active === false) {
|
||||
if (String(userId) === String(req.user.id) && is_active === false) {
|
||||
return res.status(400).json({ error: 'Cannot deactivate your own account' });
|
||||
}
|
||||
|
||||
try {
|
||||
// Fetch current user record before update (needed for group change audit)
|
||||
const currentUser = await new Promise((resolve, reject) => {
|
||||
db.get(
|
||||
'SELECT user_group FROM users WHERE id = ?',
|
||||
[userId],
|
||||
(err, row) => {
|
||||
if (err) reject(err);
|
||||
else resolve(row);
|
||||
}
|
||||
);
|
||||
});
|
||||
|
||||
if (!currentUser) {
|
||||
return res.status(404).json({ error: 'User not found' });
|
||||
}
|
||||
|
||||
const updates = [];
|
||||
const values = [];
|
||||
|
||||
@@ -141,12 +166,9 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
updates.push('password_hash = ?');
|
||||
values.push(passwordHash);
|
||||
}
|
||||
if (role) {
|
||||
if (!['admin', 'editor', 'viewer'].includes(role)) {
|
||||
return res.status(400).json({ error: 'Invalid role' });
|
||||
}
|
||||
updates.push('role = ?');
|
||||
values.push(role);
|
||||
if (group) {
|
||||
updates.push('user_group = ?');
|
||||
values.push(group);
|
||||
}
|
||||
if (typeof is_active === 'boolean') {
|
||||
updates.push('is_active = ?');
|
||||
@@ -173,7 +195,7 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
const updatedFields = {};
|
||||
if (username) updatedFields.username = username;
|
||||
if (email) updatedFields.email = email;
|
||||
if (role) updatedFields.role = role;
|
||||
if (group) updatedFields.group = group;
|
||||
if (typeof is_active === 'boolean') updatedFields.is_active = is_active;
|
||||
if (password) updatedFields.password_changed = true;
|
||||
|
||||
@@ -187,6 +209,22 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
// Log specific audit entry for group changes
|
||||
if (group && group !== currentUser.user_group) {
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'user_group_change',
|
||||
entityType: 'user',
|
||||
entityId: String(userId),
|
||||
details: {
|
||||
previous_group: currentUser.user_group,
|
||||
new_group: group
|
||||
},
|
||||
ipAddress: req.ip
|
||||
});
|
||||
}
|
||||
|
||||
// If user was deactivated, delete their sessions
|
||||
if (is_active === false) {
|
||||
await new Promise((resolve) => {
|
||||
@@ -209,7 +247,7 @@ function createUsersRouter(db, requireAuth, requireRole, logAudit) {
|
||||
const userId = req.params.id;
|
||||
|
||||
// Prevent self-deletion
|
||||
if (userId == req.user.id) {
|
||||
if (String(userId) === String(req.user.id)) {
|
||||
return res.status(400).json({ error: 'Cannot delete your own account' });
|
||||
}
|
||||
|
||||
|
||||
@@ -12,7 +12,7 @@ const path = require('path');
|
||||
const fs = require('fs');
|
||||
|
||||
// Auth imports
|
||||
const { requireAuth, requireRole } = require('./middleware/auth');
|
||||
const { requireAuth, requireGroup } = require('./middleware/auth');
|
||||
const createAuthRouter = require('./routes/auth');
|
||||
const createUsersRouter = require('./routes/users');
|
||||
const createAuditLogRouter = require('./routes/auditLog');
|
||||
@@ -23,12 +23,17 @@ const createArcherTicketsRouter = require('./routes/archerTickets');
|
||||
const createIvantiWorkflowsRouter = require('./routes/ivantiWorkflows');
|
||||
const createIvantiFindingsRouter = require('./routes/ivantiFindings');
|
||||
const createIvantiTodoQueueRouter = require('./routes/ivantiTodoQueue');
|
||||
const createIvantiArchiveRouter = require('./routes/ivantiArchive');
|
||||
const createComplianceRouter = require('./routes/compliance');
|
||||
|
||||
const app = express();
|
||||
const PORT = process.env.PORT || 3001;
|
||||
const API_HOST = process.env.API_HOST || 'localhost';
|
||||
const SESSION_SECRET = process.env.SESSION_SECRET || 'default-secret-change-me';
|
||||
const SESSION_SECRET = process.env.SESSION_SECRET;
|
||||
if (!SESSION_SECRET) {
|
||||
console.error('FATAL: SESSION_SECRET environment variable must be set');
|
||||
process.exit(1);
|
||||
}
|
||||
const CORS_ORIGINS = process.env.CORS_ORIGINS
|
||||
? process.env.CORS_ORIGINS.split(',')
|
||||
: ['http://localhost:3000'];
|
||||
@@ -160,10 +165,10 @@ const db = new sqlite3.Database('./cve_database.db', (err) => {
|
||||
app.use('/api/auth', createAuthRouter(db, logAudit));
|
||||
|
||||
// User management routes (admin only)
|
||||
app.use('/api/users', createUsersRouter(db, requireAuth, requireRole, logAudit));
|
||||
app.use('/api/users', createUsersRouter(db, requireAuth, requireGroup, logAudit));
|
||||
|
||||
// Audit log routes (admin only)
|
||||
app.use('/api/audit-logs', createAuditLogRouter(db, requireAuth, requireRole));
|
||||
app.use('/api/audit-logs', createAuditLogRouter(db, requireAuth, requireGroup));
|
||||
|
||||
// NVD lookup routes (authenticated users)
|
||||
app.use('/api/nvd', createNvdLookupRouter(db, requireAuth));
|
||||
@@ -219,8 +224,11 @@ app.use('/api/ivanti/findings', createIvantiFindingsRouter(db, requireAuth));
|
||||
// Ivanti queue routes — per-user staging queue for FP / Archer workflows
|
||||
app.use('/api/ivanti/todo-queue', createIvantiTodoQueueRouter(db, requireAuth));
|
||||
|
||||
// Ivanti archive routes — finding archive tracking for severity score drift
|
||||
app.use('/api/ivanti/archive', createIvantiArchiveRouter(db, requireAuth));
|
||||
|
||||
// AEO compliance routes — xlsx upload, non-compliant item tracking, notes
|
||||
app.use('/api/compliance', createComplianceRouter(db, upload, requireAuth, requireRole));
|
||||
app.use('/api/compliance', createComplianceRouter(db, upload, requireAuth, requireGroup));
|
||||
|
||||
// ========== CVE ENDPOINTS ==========
|
||||
|
||||
@@ -349,7 +357,7 @@ app.get('/api/cves/compliance', requireAuth(db), (req, res) => {
|
||||
});
|
||||
|
||||
// Create new CVE entry - ALLOW MULTIPLE VENDORS (editor or admin)
|
||||
app.post('/api/cves', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.post('/api/cves', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { cve_id, vendor, severity, description, published_date } = req.body;
|
||||
|
||||
// Input validation
|
||||
@@ -370,11 +378,11 @@ app.post('/api/cves', requireAuth(db), requireRole('editor', 'admin'), (req, res
|
||||
}
|
||||
|
||||
const query = `
|
||||
INSERT INTO cves (cve_id, vendor, severity, description, published_date)
|
||||
VALUES (?, ?, ?, ?, ?)
|
||||
INSERT INTO cves (cve_id, vendor, severity, description, published_date, created_by)
|
||||
VALUES (?, ?, ?, ?, ?, ?)
|
||||
`;
|
||||
|
||||
db.run(query, [cve_id, vendor, severity, description, published_date], function(err) {
|
||||
db.run(query, [cve_id, vendor, severity, description, published_date, req.user.id], function(err) {
|
||||
if (err) {
|
||||
console.error('DATABASE ERROR:', err);
|
||||
if (err.message.includes('UNIQUE constraint failed')) {
|
||||
@@ -403,7 +411,7 @@ app.post('/api/cves', requireAuth(db), requireRole('editor', 'admin'), (req, res
|
||||
|
||||
|
||||
// Update CVE status (editor or admin)
|
||||
app.patch('/api/cves/:cveId/status', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.patch('/api/cves/:cveId/status', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { cveId } = req.params;
|
||||
const { status } = req.body;
|
||||
|
||||
@@ -431,7 +439,7 @@ app.patch('/api/cves/:cveId/status', requireAuth(db), requireRole('editor', 'adm
|
||||
});
|
||||
|
||||
// Bulk sync CVE data from NVD (editor or admin)
|
||||
app.post('/api/cves/nvd-sync', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.post('/api/cves/nvd-sync', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { updates } = req.body;
|
||||
if (!Array.isArray(updates) || updates.length === 0) {
|
||||
return res.status(400).json({ error: 'No updates provided' });
|
||||
@@ -501,7 +509,7 @@ app.post('/api/cves/nvd-sync', requireAuth(db), requireRole('editor', 'admin'),
|
||||
// ========== CVE EDIT & DELETE ENDPOINTS ==========
|
||||
|
||||
// Edit single CVE entry (editor or admin)
|
||||
app.put('/api/cves/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.put('/api/cves/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
const { cve_id, vendor, severity, description, published_date, status } = req.body;
|
||||
|
||||
@@ -645,7 +653,7 @@ app.put('/api/cves/:id', requireAuth(db), requireRole('editor', 'admin'), (req,
|
||||
});
|
||||
|
||||
// Delete entire CVE - all vendors (editor or admin) - MUST be before /:id route
|
||||
app.delete('/api/cves/by-cve-id/:cveId', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.delete('/api/cves/by-cve-id/:cveId', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { cveId } = req.params;
|
||||
|
||||
// Get all rows for this CVE ID to know what we're deleting
|
||||
@@ -653,6 +661,151 @@ app.delete('/api/cves/by-cve-id/:cveId', requireAuth(db), requireRole('editor',
|
||||
if (err) { console.error(err); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
if (!rows || rows.length === 0) return res.status(404).json({ error: 'No CVE entries found for this CVE ID' });
|
||||
|
||||
// Ownership check: Standard_User can only delete CVEs they created
|
||||
if (req.user.group === 'Standard_User') {
|
||||
const notOwned = rows.some(row => row.created_by !== req.user.id);
|
||||
if (notOwned) {
|
||||
return res.status(403).json({ error: 'You can only delete resources you created' });
|
||||
}
|
||||
|
||||
// Cascade impact check for Standard_User
|
||||
// Query all three cascade-deleted resource types in parallel
|
||||
db.all('SELECT id, exc_number, cve_id, vendor FROM archer_tickets WHERE cve_id = ?', [cveId], (archerErr, archerTickets) => {
|
||||
if (archerErr) { console.error(archerErr); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
|
||||
db.all('SELECT id, cve_id, vendor, ticket_key, status FROM jira_tickets WHERE cve_id = ?', [cveId], (jiraErr, jiraTickets) => {
|
||||
// If jira_tickets table doesn't exist yet, treat as empty
|
||||
if (jiraErr && jiraErr.message && jiraErr.message.includes('no such table')) {
|
||||
jiraTickets = [];
|
||||
} else if (jiraErr) {
|
||||
console.error(jiraErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
db.all('SELECT id, name, type FROM documents WHERE cve_id = ?', [cveId], (docErr, docs) => {
|
||||
if (docErr) { console.error(docErr); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
|
||||
const allTickets = [
|
||||
...(archerTickets || []).map(t => ({ ...t, source: 'archer', key: t.exc_number })),
|
||||
...(jiraTickets || []).map(t => ({ ...t, source: 'jira', key: t.ticket_key }))
|
||||
];
|
||||
|
||||
// If no tickets at all, no compliance linkage possible — return cascade info
|
||||
if (allTickets.length === 0) {
|
||||
return res.json({
|
||||
cascade_impact: {
|
||||
archer_tickets: [],
|
||||
jira_tickets: [],
|
||||
documents: (docs || []).map(d => ({ id: d.id, name: d.name, type: d.type })),
|
||||
blocked: false,
|
||||
blocked_reason: null
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
// Check compliance linkage for each ticket
|
||||
// A ticket is compliance-linked if its key (exc_number or ticket_key) or cve_id
|
||||
// appears in active compliance_items extra_json
|
||||
const likeConditions = [];
|
||||
const likeParams = [];
|
||||
for (const t of allTickets) {
|
||||
likeConditions.push('ci.extra_json LIKE ?');
|
||||
likeParams.push(`%${t.key}%`);
|
||||
}
|
||||
// Also check if the CVE ID itself appears in compliance extra_json
|
||||
likeConditions.push('ci.extra_json LIKE ?');
|
||||
likeParams.push(`%${cveId}%`);
|
||||
|
||||
db.all(
|
||||
`SELECT ci.id, ci.extra_json, cu.report_date
|
||||
FROM compliance_items ci
|
||||
JOIN compliance_uploads cu ON ci.upload_id = cu.id
|
||||
WHERE ci.status = 'active' AND (${likeConditions.join(' OR ')})`,
|
||||
likeParams,
|
||||
(compErr, compLinks) => {
|
||||
// If compliance_items table doesn't exist yet, treat as no linkage
|
||||
if (compErr && compErr.message && compErr.message.includes('no such table')) {
|
||||
compLinks = [];
|
||||
} else if (compErr) {
|
||||
console.error(compErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
// Determine which tickets are compliance-linked by checking extra_json matches
|
||||
const linkedTicketKeys = new Set();
|
||||
for (const cl of (compLinks || [])) {
|
||||
const json = cl.extra_json || '';
|
||||
for (const t of allTickets) {
|
||||
if (json.includes(t.key)) {
|
||||
linkedTicketKeys.add(`${t.source}:${t.id}`);
|
||||
}
|
||||
}
|
||||
// If CVE ID itself is in compliance data, all tickets are considered linked
|
||||
if (json.includes(cveId)) {
|
||||
for (const t of allTickets) {
|
||||
linkedTicketKeys.add(`${t.source}:${t.id}`);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const archerTicketsResult = (archerTickets || []).map(t => ({
|
||||
id: t.id,
|
||||
exc_number: t.exc_number,
|
||||
compliance_linked: linkedTicketKeys.has(`archer:${t.id}`)
|
||||
}));
|
||||
|
||||
const jiraTicketsResult = (jiraTickets || []).map(t => ({
|
||||
id: t.id,
|
||||
ticket_key: t.ticket_key,
|
||||
compliance_linked: linkedTicketKeys.has(`jira:${t.id}`)
|
||||
}));
|
||||
|
||||
const documentsResult = (docs || []).map(d => ({
|
||||
id: d.id,
|
||||
name: d.name,
|
||||
type: d.type
|
||||
}));
|
||||
|
||||
const hasComplianceLink = archerTicketsResult.some(t => t.compliance_linked)
|
||||
|| jiraTicketsResult.some(t => t.compliance_linked);
|
||||
|
||||
if (hasComplianceLink) {
|
||||
const blockedArcher = archerTicketsResult.find(t => t.compliance_linked);
|
||||
const blockedJira = jiraTicketsResult.find(t => t.compliance_linked);
|
||||
const blockedLabel = blockedArcher
|
||||
? `Archer ticket ${blockedArcher.exc_number}`
|
||||
: `JIRA ticket ${blockedJira.ticket_key}`;
|
||||
return res.status(403).json({
|
||||
error: 'CVE deletion blocked: associated ticket linked to compliance report',
|
||||
cascade_impact: {
|
||||
archer_tickets: archerTicketsResult,
|
||||
jira_tickets: jiraTicketsResult,
|
||||
documents: documentsResult,
|
||||
blocked: true,
|
||||
blocked_reason: `${blockedLabel} is linked to a compliance report`
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
// Not blocked — return cascade impact for frontend warning
|
||||
return res.json({
|
||||
cascade_impact: {
|
||||
archer_tickets: archerTicketsResult,
|
||||
jira_tickets: jiraTicketsResult,
|
||||
documents: documentsResult,
|
||||
blocked: false,
|
||||
blocked_reason: null
|
||||
}
|
||||
});
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
return; // Exit early — Standard_User flow handled above
|
||||
}
|
||||
|
||||
// Admin flow: proceed directly with deletion (no cascade check)
|
||||
// Delete all documents from DB
|
||||
db.run('DELETE FROM documents WHERE cve_id = ?', [cveId], (docErr) => {
|
||||
if (docErr) console.error('Error deleting documents:', docErr);
|
||||
@@ -685,13 +838,71 @@ app.delete('/api/cves/by-cve-id/:cveId', requireAuth(db), requireRole('editor',
|
||||
});
|
||||
|
||||
// Delete single CVE vendor entry (editor or admin)
|
||||
app.delete('/api/cves/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.delete('/api/cves/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
db.get('SELECT * FROM cves WHERE id = ?', [id], (err, cve) => {
|
||||
if (err) { console.error(err); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
if (!cve) return res.status(404).json({ error: 'CVE entry not found' });
|
||||
|
||||
// Ownership check: Standard_User can only delete CVEs they created
|
||||
if (req.user.group === 'Standard_User' && cve.created_by !== req.user.id) {
|
||||
return res.status(403).json({ error: 'You can only delete resources you created' });
|
||||
}
|
||||
|
||||
// Cascade/compliance check for Standard_User
|
||||
if (req.user.group === 'Standard_User') {
|
||||
return db.all('SELECT id, exc_number FROM archer_tickets WHERE cve_id = ? AND vendor = ?', [cve.cve_id, cve.vendor], (archerErr, archerTickets) => {
|
||||
if (archerErr) { console.error(archerErr); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
|
||||
db.all('SELECT id, ticket_key FROM jira_tickets WHERE cve_id = ? AND vendor = ?', [cve.cve_id, cve.vendor], (jiraErr, jiraTickets) => {
|
||||
if (jiraErr && jiraErr.message && jiraErr.message.includes('no such table')) { jiraTickets = []; }
|
||||
else if (jiraErr) { console.error(jiraErr); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
|
||||
const allTickets = [
|
||||
...(archerTickets || []).map(t => ({ ...t, source: 'archer', key: t.exc_number })),
|
||||
...(jiraTickets || []).map(t => ({ ...t, source: 'jira', key: t.ticket_key }))
|
||||
];
|
||||
|
||||
if (allTickets.length === 0) {
|
||||
return doSingleCveDelete(req, res, id, cve);
|
||||
}
|
||||
|
||||
const likeConditions = allTickets.map(() => 'ci.extra_json LIKE ?');
|
||||
const likeParams = allTickets.map(t => `%${t.key}%`);
|
||||
|
||||
db.all(
|
||||
`SELECT ci.id, ci.extra_json FROM compliance_items ci
|
||||
JOIN compliance_uploads cu ON ci.upload_id = cu.id
|
||||
WHERE ci.status = 'active' AND (${likeConditions.join(' OR ')})`,
|
||||
likeParams,
|
||||
(compErr, compLinks) => {
|
||||
if (compErr && compErr.message && compErr.message.includes('no such table')) { compLinks = []; }
|
||||
else if (compErr) { console.error(compErr); return res.status(500).json({ error: 'Internal server error.' }); }
|
||||
|
||||
const hasLink = (compLinks || []).some(cl => {
|
||||
const json = cl.extra_json || '';
|
||||
return allTickets.some(t => json.includes(t.key));
|
||||
});
|
||||
|
||||
if (hasLink) {
|
||||
return res.status(403).json({
|
||||
error: 'CVE deletion blocked: associated ticket linked to compliance report',
|
||||
cascade_impact: { blocked: true, blocked_reason: 'Associated ticket is linked to a compliance report' }
|
||||
});
|
||||
}
|
||||
|
||||
return doSingleCveDelete(req, res, id, cve);
|
||||
}
|
||||
);
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
doSingleCveDelete(req, res, id, cve);
|
||||
});
|
||||
|
||||
function doSingleCveDelete(req, res, id, cve) {
|
||||
// Delete associated documents from DB
|
||||
db.all('SELECT id, file_path FROM documents WHERE cve_id = ? AND vendor = ?', [cve.cve_id, cve.vendor], (docErr, docs) => {
|
||||
if (docErr) console.error('Error fetching documents:', docErr);
|
||||
@@ -738,7 +949,7 @@ app.delete('/api/cves/:id', requireAuth(db), requireRole('editor', 'admin'), (re
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
// ========== DOCUMENT ENDPOINTS ==========
|
||||
@@ -767,7 +978,7 @@ app.get('/api/cves/:cveId/documents', requireAuth(db), (req, res) => {
|
||||
});
|
||||
|
||||
// Upload document - ADD ERROR HANDLING FOR MULTER (editor or admin)
|
||||
app.post('/api/cves/:cveId/documents', requireAuth(db), requireRole('editor', 'admin'), (req, res, next) => {
|
||||
app.post('/api/cves/:cveId/documents', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res, next) => {
|
||||
upload.single('file')(req, res, (err) => {
|
||||
if (err) {
|
||||
console.error('Upload error:', err.message);
|
||||
@@ -875,7 +1086,7 @@ app.post('/api/cves/:cveId/documents', requireAuth(db), requireRole('editor', 'a
|
||||
});
|
||||
});
|
||||
// Delete document (admin only)
|
||||
app.delete('/api/documents/:id', requireAuth(db), requireRole('admin'), (req, res) => {
|
||||
app.delete('/api/documents/:id', requireAuth(db), requireGroup('Admin'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
// First get the file path to delete the actual file
|
||||
@@ -977,7 +1188,7 @@ app.get('/api/jira-tickets', requireAuth(db), (req, res) => {
|
||||
});
|
||||
|
||||
// Create JIRA ticket
|
||||
app.post('/api/jira-tickets', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.post('/api/jira-tickets', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { cve_id, vendor, ticket_key, url, summary, status } = req.body;
|
||||
|
||||
// Validation
|
||||
@@ -1003,11 +1214,11 @@ app.post('/api/jira-tickets', requireAuth(db), requireRole('editor', 'admin'), (
|
||||
const ticketStatus = status || 'Open';
|
||||
|
||||
const query = `
|
||||
INSERT INTO jira_tickets (cve_id, vendor, ticket_key, url, summary, status)
|
||||
VALUES (?, ?, ?, ?, ?, ?)
|
||||
INSERT INTO jira_tickets (cve_id, vendor, ticket_key, url, summary, status, created_by)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?)
|
||||
`;
|
||||
|
||||
db.run(query, [cve_id, vendor, ticket_key.trim(), url || null, summary || null, ticketStatus], function(err) {
|
||||
db.run(query, [cve_id, vendor, ticket_key.trim(), url || null, summary || null, ticketStatus, req.user.id], function(err) {
|
||||
if (err) {
|
||||
console.error('Error creating JIRA ticket:', err);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
@@ -1031,7 +1242,7 @@ app.post('/api/jira-tickets', requireAuth(db), requireRole('editor', 'admin'), (
|
||||
});
|
||||
|
||||
// Update JIRA ticket
|
||||
app.put('/api/jira-tickets/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.put('/api/jira-tickets/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
const { ticket_key, url, summary, status } = req.body;
|
||||
|
||||
@@ -1096,7 +1307,7 @@ app.put('/api/jira-tickets/:id', requireAuth(db), requireRole('editor', 'admin')
|
||||
});
|
||||
|
||||
// Delete JIRA ticket
|
||||
app.delete('/api/jira-tickets/:id', requireAuth(db), requireRole('editor', 'admin'), (req, res) => {
|
||||
app.delete('/api/jira-tickets/:id', requireAuth(db), requireGroup('Admin', 'Standard_User'), (req, res) => {
|
||||
const { id } = req.params;
|
||||
|
||||
db.get('SELECT * FROM jira_tickets WHERE id = ?', [id], (err, ticket) => {
|
||||
@@ -1108,24 +1319,66 @@ app.delete('/api/jira-tickets/:id', requireAuth(db), requireRole('editor', 'admi
|
||||
return res.status(404).json({ error: 'JIRA ticket not found.' });
|
||||
}
|
||||
|
||||
db.run('DELETE FROM jira_tickets WHERE id = ?', [id], function(deleteErr) {
|
||||
if (deleteErr) {
|
||||
console.error('Error deleting JIRA ticket:', deleteErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
// Admin bypasses all delete restrictions
|
||||
if (req.user.group === 'Admin') {
|
||||
return performJiraDelete();
|
||||
}
|
||||
|
||||
// Standard_User: ownership check
|
||||
if (ticket.created_by && ticket.created_by !== req.user.id) {
|
||||
return res.status(403).json({ error: 'You can only delete resources you created' });
|
||||
}
|
||||
|
||||
// Standard_User: compliance linkage check
|
||||
const ticketKey = ticket.ticket_key;
|
||||
db.all(
|
||||
`SELECT ci.id, ci.extra_json
|
||||
FROM compliance_items ci
|
||||
JOIN compliance_uploads cu ON ci.upload_id = cu.id
|
||||
WHERE ci.status = 'active' AND ci.extra_json LIKE ?`,
|
||||
[`%${ticketKey}%`],
|
||||
(compErr, compLinks) => {
|
||||
// If compliance_items table doesn't exist yet, treat as no linkage
|
||||
if (compErr && compErr.message && compErr.message.includes('no such table')) {
|
||||
compLinks = [];
|
||||
} else if (compErr) {
|
||||
console.error(compErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
const isLinked = (compLinks || []).some(cl => {
|
||||
const json = cl.extra_json || '';
|
||||
return json.includes(ticketKey);
|
||||
});
|
||||
|
||||
if (isLinked) {
|
||||
return res.status(403).json({ error: 'Cannot delete ticket linked to compliance report. Contact an admin.' });
|
||||
}
|
||||
|
||||
return performJiraDelete();
|
||||
}
|
||||
);
|
||||
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'jira_ticket_delete',
|
||||
entityType: 'jira_ticket',
|
||||
entityId: id,
|
||||
details: { ticket_key: ticket.ticket_key, cve_id: ticket.cve_id, vendor: ticket.vendor },
|
||||
ipAddress: req.ip
|
||||
function performJiraDelete() {
|
||||
db.run('DELETE FROM jira_tickets WHERE id = ?', [id], function(deleteErr) {
|
||||
if (deleteErr) {
|
||||
console.error('Error deleting JIRA ticket:', deleteErr);
|
||||
return res.status(500).json({ error: 'Internal server error.' });
|
||||
}
|
||||
|
||||
logAudit(db, {
|
||||
userId: req.user.id,
|
||||
username: req.user.username,
|
||||
action: 'jira_ticket_delete',
|
||||
entityType: 'jira_ticket',
|
||||
entityId: id,
|
||||
details: { ticket_key: ticket.ticket_key, cve_id: ticket.cve_id, vendor: ticket.vendor },
|
||||
ipAddress: req.ip
|
||||
});
|
||||
|
||||
res.json({ message: 'JIRA ticket deleted successfully' });
|
||||
});
|
||||
|
||||
res.json({ message: 'JIRA ticket deleted successfully' });
|
||||
});
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -3,6 +3,7 @@
|
||||
|
||||
const sqlite3 = require('sqlite3').verbose();
|
||||
const bcrypt = require('bcryptjs');
|
||||
const crypto = require('crypto');
|
||||
const fs = require('fs');
|
||||
const path = require('path');
|
||||
|
||||
@@ -172,8 +173,9 @@ async function createDefaultAdmin(db) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Create admin user with password 'admin123'
|
||||
const passwordHash = await bcrypt.hash('admin123', 10);
|
||||
// Generate a random admin password on first run
|
||||
const generatedPassword = crypto.randomBytes(12).toString('base64url');
|
||||
const passwordHash = await bcrypt.hash(generatedPassword, 10);
|
||||
|
||||
db.run(
|
||||
`INSERT INTO users (username, email, password_hash, role, is_active)
|
||||
@@ -183,7 +185,12 @@ async function createDefaultAdmin(db) {
|
||||
if (err) {
|
||||
reject(err);
|
||||
} else {
|
||||
console.log('✓ Created default admin user (admin/admin123)');
|
||||
console.log('✓ Created default admin user');
|
||||
console.log(`\n ╔══════════════════════════════════════════╗`);
|
||||
console.log(` ║ Admin credentials (save these now!) ║`);
|
||||
console.log(` ║ Username: admin ║`);
|
||||
console.log(` ║ Password: ${generatedPassword.padEnd(29)}║`);
|
||||
console.log(` ╚══════════════════════════════════════════╝\n`);
|
||||
resolve();
|
||||
}
|
||||
}
|
||||
@@ -269,7 +276,7 @@ function displaySummary() {
|
||||
console.log(' ✓ Indexes for fast queries');
|
||||
console.log(' ✓ Document compliance view');
|
||||
console.log(' ✓ Uploads directory for file storage');
|
||||
console.log(' ✓ Default admin user (admin/admin123)');
|
||||
console.log(' ✓ Default admin user (see credentials above)');
|
||||
console.log('\n📁 File structure will be:');
|
||||
console.log(' uploads/');
|
||||
console.log(' └── CVE-XXXX-XXXX/');
|
||||
|
||||
617
docs/security-audit-2026-04-01.md
Normal file
617
docs/security-audit-2026-04-01.md
Normal file
@@ -0,0 +1,617 @@
|
||||
# Security Audit Report — STEAM Security Dashboard
|
||||
|
||||
**Date:** 2026-04-01
|
||||
**Scope:** Full codebase — backend routes, authentication, file handling, Python scripts, React frontend
|
||||
**Methodology:** Static analysis across four parallel audit tracks
|
||||
|
||||
---
|
||||
|
||||
## Executive Summary
|
||||
|
||||
The audit identified **31 findings** across four severity levels. The most serious issues are concentrated in the **authentication and authorization layer** — several endpoints are either completely unauthenticated or have role-checking middleware called with the wrong arguments, silently bypassing access control. These require immediate remediation before the application is exposed to a broader user base.
|
||||
|
||||
| Severity | Count |
|
||||
|----------|-------|
|
||||
| Critical | 6 |
|
||||
| High | 9 |
|
||||
| Medium | 10 |
|
||||
| Low / Info | 6 |
|
||||
| **Total** | **31** |
|
||||
|
||||
The application has strong foundational security in several areas: all database queries use parameterized statements (no SQL injection risk), path traversal prevention is comprehensive, Python script execution uses `spawn` with argument arrays (no shell injection), and file type allowlisting is in place. The vulnerabilities are largely in middleware wiring and missing access controls rather than fundamental design flaws.
|
||||
|
||||
---
|
||||
|
||||
## Critical Findings
|
||||
|
||||
---
|
||||
|
||||
### C-1 — Missing Authentication on Ivanti Findings Endpoints
|
||||
|
||||
**File:** `backend/routes/ivantiFindings.js:552–600`
|
||||
|
||||
The findings router imports `requireRole` but **not** `requireAuth`. No authentication middleware is applied at the router level or on individual routes. Four endpoints are fully unauthenticated:
|
||||
|
||||
```js
|
||||
const { requireRole } = require('../middleware/auth'); // requireAuth never imported
|
||||
|
||||
router.get('/', async (req, res) => { // line 552 — no auth
|
||||
router.post('/sync', async (req, res) => { // line 561 — no auth
|
||||
router.get('/counts', async (req, res) => { // line 571 — no auth
|
||||
router.get('/fp-workflow-counts', ...) // line 580 — no auth
|
||||
```
|
||||
|
||||
**Impact:** Any unauthenticated attacker on the network can read the full list of Ivanti host findings (hostnames, IPs, CVEs, severity, SLA status), trigger a sync operation, and enumerate all finding metrics.
|
||||
|
||||
**Fix:** Import `requireAuth` and apply it to the router or each route:
|
||||
```js
|
||||
const { requireAuth, requireRole } = require('../middleware/auth');
|
||||
router.use(requireAuth(db));
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### C-2 — Broken requireRole Call — Privilege Escalation in Knowledge Base
|
||||
|
||||
**File:** `backend/routes/knowledgeBase.js:43, 305`
|
||||
|
||||
`requireRole` is called with `db` as the first argument:
|
||||
|
||||
```js
|
||||
router.post('/upload', requireAuth(db), requireRole(db, 'editor', 'admin'), ...)
|
||||
router.delete('/:id', requireAuth(db), requireRole(db, 'editor', 'admin'), ...)
|
||||
```
|
||||
|
||||
The function signature is `function requireRole(...allowedRoles)`. It does not accept `db`. The database object is treated as the first "allowed role", so the check becomes `req.user.role === db` — an object comparison that always evaluates false, meaning **the check never blocks anyone**. Any authenticated viewer can upload and delete knowledge base documents.
|
||||
|
||||
**Fix:** Remove `db` from all `requireRole` calls:
|
||||
```js
|
||||
requireRole('editor', 'admin')
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### C-3 — Unauthenticated Ivanti Finding Note Writes
|
||||
|
||||
**File:** `backend/routes/ivantiFindings.js:639`
|
||||
|
||||
The PUT endpoint for saving finding notes has no authentication middleware:
|
||||
|
||||
```js
|
||||
router.put('/:findingId/note', (req, res) => {
|
||||
const note = String(req.body.note || '').slice(0, 255);
|
||||
db.run(`INSERT INTO ivanti_finding_notes ...`);
|
||||
});
|
||||
```
|
||||
|
||||
**Impact:** Any unauthenticated request can write notes to any finding. Notes are visible to all users and used during remediation triage. An attacker could inject false status information (e.g. "EXC-12345 — patched") to mislead the team or cover tracks.
|
||||
|
||||
**Fix:** Add `requireAuth(db)` to this route.
|
||||
|
||||
---
|
||||
|
||||
### C-4 — No Brute Force Protection on Login Endpoint
|
||||
|
||||
**File:** `backend/routes/auth.js:10`
|
||||
|
||||
The login endpoint has no rate limiting, attempt counting, or lockout:
|
||||
|
||||
```js
|
||||
router.post('/login', async (req, res) => {
|
||||
const { username, password } = req.body;
|
||||
// Direct DB lookup, unlimited attempts
|
||||
```
|
||||
|
||||
**Impact:** An attacker can run unlimited password guesses against any account at full network speed. With the default credentials documented in the README and displayed in the UI (see F-2), admin accounts are a trivial target.
|
||||
|
||||
**Fix:** Apply `express-rate-limit` to the login route:
|
||||
```js
|
||||
const rateLimit = require('express-rate-limit');
|
||||
const loginLimiter = rateLimit({ windowMs: 15 * 60 * 1000, max: 20 });
|
||||
router.post('/login', loginLimiter, async (req, res) => { ... });
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### C-5 — Default Credentials Displayed in Login UI
|
||||
|
||||
**File:** `frontend/src/components/LoginForm.js:104`
|
||||
|
||||
The login form renders hardcoded credentials in plain text:
|
||||
|
||||
```jsx
|
||||
<p className="text-sm text-gray-500 text-center font-mono">
|
||||
Default: <span className="text-intel-accent">admin</span> /
|
||||
<span className="text-intel-accent">admin123</span>
|
||||
</p>
|
||||
```
|
||||
|
||||
**Impact:** Anyone who opens the login page — including unauthenticated users — sees the default admin credentials. Combined with C-4 (no rate limiting), this is a direct path to admin compromise if the password has not been changed.
|
||||
|
||||
**Fix:** Remove this block entirely. Document default credentials only in the deployment guide. Enforce password change on first login server-side.
|
||||
|
||||
---
|
||||
|
||||
### C-6 — Missing Sandbox Attribute on Knowledge Base PDF Iframe
|
||||
|
||||
**File:** `frontend/src/components/KnowledgeBaseViewer.js:195`
|
||||
|
||||
The inline document viewer renders uploaded files in an unsandboxed iframe:
|
||||
|
||||
```jsx
|
||||
<iframe
|
||||
src={`${API_BASE}/knowledge-base/${article.id}/content`}
|
||||
title={article.title}
|
||||
className="w-full h-full rounded"
|
||||
>
|
||||
```
|
||||
|
||||
**Impact:** A malicious PDF or HTML file uploaded by an editor could execute JavaScript within the application's origin, accessing `localStorage`, `sessionStorage`, and DOM of the parent page. An attacker with editor access could upload a file that steals session data from any user who views it.
|
||||
|
||||
**Fix:** Add a restrictive `sandbox` attribute:
|
||||
```jsx
|
||||
<iframe
|
||||
sandbox="allow-same-origin allow-scripts"
|
||||
src={...}
|
||||
title={article.title}
|
||||
/>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## High Findings
|
||||
|
||||
---
|
||||
|
||||
### H-1 — /cleanup-sessions Missing Role Check
|
||||
|
||||
**File:** `backend/routes/auth.js:223`
|
||||
|
||||
The comment says "admin only" but the endpoint only checks for any valid session:
|
||||
|
||||
```js
|
||||
router.post('/cleanup-sessions', async (req, res) => {
|
||||
const sessionId = req.cookies?.session_id;
|
||||
if (!sessionId) return res.status(401).json({ error: '...' });
|
||||
// No role check
|
||||
```
|
||||
|
||||
**Fix:** Apply `requireAuth(db)` and `requireRole('admin')`.
|
||||
|
||||
---
|
||||
|
||||
### H-2 — Hardcoded Fallback SESSION_SECRET
|
||||
|
||||
**File:** `backend/server.js:31`
|
||||
|
||||
```js
|
||||
const SESSION_SECRET = process.env.SESSION_SECRET || 'default-secret-change-me';
|
||||
```
|
||||
|
||||
If the `.env` file is missing or the variable is unset, all sessions are signed with a publicly known string. An attacker who knows the secret can forge valid session cookies.
|
||||
|
||||
**Fix:** Fail hard on startup if the secret is not set:
|
||||
```js
|
||||
const SESSION_SECRET = process.env.SESSION_SECRET;
|
||||
if (!SESSION_SECRET) throw new Error('SESSION_SECRET environment variable must be set');
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### H-3 — Audit Log Parameter Mismatch — Silent Audit Trail Gaps
|
||||
|
||||
**Files:** `backend/routes/archerTickets.js:89–95, 172, 206` and `backend/routes/knowledgeBase.js:235–244, 287–296`
|
||||
|
||||
The `logAudit` helper expects an object with `entityType` and `entityId`. These callers use the wrong keys (`targetType`, `targetId`) or pass positional arguments instead of an object:
|
||||
|
||||
```js
|
||||
// archerTickets.js — wrong keys
|
||||
logAudit(db, { ..., targetType: 'archer_ticket', targetId: this.lastID, ... });
|
||||
|
||||
// knowledgeBase.js — positional (wrong pattern)
|
||||
logAudit(db, req.user.id, req.user.username, 'VIEW_KB_ARTICLE', 'knowledge_base', id, ...);
|
||||
```
|
||||
|
||||
**Impact:** All Archer ticket and Knowledge Base operations produce audit log rows with `NULL` entity type and entity ID. Security investigations and compliance reviews will show these actions occurred but not what was affected.
|
||||
|
||||
**Fix:** Align all callers to the object format expected by `auditLog.js`:
|
||||
```js
|
||||
logAudit(db, { userId, username, action, entityType, entityId, details, ipAddress });
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### H-4 — Viewers Can Write Compliance Notes
|
||||
|
||||
**Files:** `backend/routes/compliance.js:522` (also flagged by file-upload audit)
|
||||
|
||||
The POST /notes endpoint is protected by authentication but not by role:
|
||||
|
||||
```js
|
||||
router.post('/notes', async (req, res) => { // no requireRole()
|
||||
```
|
||||
|
||||
**Impact:** Any viewer can add notes to any compliance item. Notes surface in the detail panel and influence remediation decisions. False notes cannot be deleted via the API.
|
||||
|
||||
**Fix:** `requireRole('editor', 'admin')` on this route.
|
||||
|
||||
---
|
||||
|
||||
### H-5 — Sync Endpoints Accessible to All Authenticated Users
|
||||
|
||||
**Files:** `backend/routes/ivantiFindings.js:561`, `backend/routes/ivantiWorkflows.js:262`
|
||||
|
||||
POST /sync on both routers requires only authentication, not editor/admin role. Any viewer can trigger expensive Ivanti API calls repeatedly.
|
||||
|
||||
**Impact:** Viewer-role users can cause repeated large API fetches, potentially hitting Ivanti rate limits and blocking legitimate syncs for the team.
|
||||
|
||||
**Fix:** Add `requireRole('editor', 'admin')` to both POST /sync routes.
|
||||
|
||||
---
|
||||
|
||||
### H-6 — HTTP Header Injection via Unsanitized Filename in Content-Disposition
|
||||
|
||||
**File:** `backend/routes/knowledgeBase.js:258, 299`
|
||||
|
||||
The original uploaded filename (user-controlled) is written directly into the `Content-Disposition` response header:
|
||||
|
||||
```js
|
||||
res.setHeader('Content-Disposition', `inline; filename="${row.file_name}"`);
|
||||
res.setHeader('Content-Disposition', `attachment; filename="${row.file_name}"`);
|
||||
```
|
||||
|
||||
`row.file_name` stores `uploadedFile.originalname` which is not sanitized for use in HTTP headers. A filename containing `"\r\n` characters can split the response and inject arbitrary headers.
|
||||
|
||||
**Fix:**
|
||||
```js
|
||||
const safeFilename = row.file_name.replace(/["\r\n\\]/g, '');
|
||||
res.setHeader('Content-Disposition', `attachment; filename="${safeFilename}"`);
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### H-7 — Race Condition in Knowledge Base File Upload
|
||||
|
||||
**File:** `backend/routes/knowledgeBase.js:91–155`
|
||||
|
||||
The file is moved to its permanent location (line 93) before the database record is created (line 114). If the DB insert fails, the file is orphaned on disk. Two concurrent uploads with the same slug can also bypass the uniqueness check due to the async gap between the slug check query and the insert.
|
||||
|
||||
**Fix:** Keep the file in the temp directory until the DB insert succeeds, then move it:
|
||||
```js
|
||||
db.run(insertSql, [...], function(err) {
|
||||
if (err) { fs.unlinkSync(uploadedFile.path); return res.status(500)...; }
|
||||
fs.renameSync(uploadedFile.path, filePath);
|
||||
res.json({ success: true });
|
||||
});
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### H-8 — Hardcoded Default Admin Password in setup.js
|
||||
|
||||
**File:** `backend/setup.js:175`
|
||||
|
||||
```js
|
||||
const passwordHash = await bcrypt.hash('admin123', 10);
|
||||
```
|
||||
|
||||
If `setup.js` is re-run on an existing deployment (e.g. during a restore), the admin password resets to a known value. The password is also documented in the README and displayed in the login UI (C-5).
|
||||
|
||||
**Fix:** Generate a random password on first run and print it once to stdout, or require it as a CLI argument. Never hardcode credentials in source.
|
||||
|
||||
---
|
||||
|
||||
### H-9 — ReactMarkdown Renders HTML Without Sanitization
|
||||
|
||||
**File:** `frontend/src/components/KnowledgeBaseViewer.js:169–171`
|
||||
|
||||
```jsx
|
||||
<ReactMarkdown>{content}</ReactMarkdown>
|
||||
```
|
||||
|
||||
`ReactMarkdown` by default allows raw HTML in markdown (via `rehype-raw`). A knowledge base article containing `<img src=x onerror="...">` or `<script>` tags would execute JavaScript in the viewer's browser.
|
||||
|
||||
**Fix:** Add `rehype-sanitize`:
|
||||
```jsx
|
||||
import rehypeSanitize from 'rehype-sanitize';
|
||||
<ReactMarkdown rehypePlugins={[rehypeSanitize]}>{content}</ReactMarkdown>
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Medium Findings
|
||||
|
||||
---
|
||||
|
||||
### M-1 — No CSRF Token Protection on State-Changing Requests
|
||||
|
||||
**Files:** All POST / PUT / DELETE routes
|
||||
|
||||
Cookies are `SameSite: lax` which provides partial protection, but `lax` still allows top-level cross-site navigations to carry cookies. No CSRF token is validated server-side. Combined with the permissive CORS configuration, cross-site request forgery is possible against editors and admins.
|
||||
|
||||
**Fix:** Either upgrade session cookie to `SameSite: strict`, or implement a CSRF token (double-submit cookie pattern or `csurf` middleware).
|
||||
|
||||
---
|
||||
|
||||
### M-2 — CORS Allows Credentials with Explicit Origin List
|
||||
|
||||
**File:** `backend/server.js:111–114`
|
||||
|
||||
```js
|
||||
app.use(cors({ origin: CORS_ORIGINS, credentials: true }));
|
||||
```
|
||||
|
||||
`credentials: true` with explicit origins means any subdomain compromise or DNS hijacking of a listed origin could allow cross-origin authenticated requests. This is the correct pattern for this use case, but worth hardening.
|
||||
|
||||
**Fix:** Ensure `CORS_ORIGINS` is reviewed whenever the deployment changes. Consider `SameSite: strict` on cookies to reduce reliance on CORS for CSRF protection.
|
||||
|
||||
---
|
||||
|
||||
### M-3 — No Rate Limiting on NVD API Proxy
|
||||
|
||||
**File:** `backend/routes/nvdLookup.js:13`
|
||||
|
||||
Any authenticated user can trigger NVD API calls in rapid succession. NVD enforces a 5 req/30s unauthenticated limit, which can be exhausted by a single user making 5 lookups.
|
||||
|
||||
**Fix:** Add a server-side 1-hour cache keyed by CVE ID to avoid repeated external lookups, plus a per-user rate limit.
|
||||
|
||||
---
|
||||
|
||||
### M-4 — Admin Self-Demotion Check Uses Loose Equality
|
||||
|
||||
**File:** `backend/routes/users.js:118`
|
||||
|
||||
```js
|
||||
if (userId == req.user.id && role && role !== 'admin') {
|
||||
```
|
||||
|
||||
Using `==` allows type coercion. If `userId` is passed as a different type than `req.user.id`, the comparison may not match correctly.
|
||||
|
||||
**Fix:** `String(userId) === String(req.user.id)`.
|
||||
|
||||
---
|
||||
|
||||
### M-5 — Missing Hostname Format Validation
|
||||
|
||||
**File:** `backend/routes/compliance.js:451`
|
||||
|
||||
The hostname route parameter is used in SQL queries and responses. Only length is checked (>300). No format validation rejects characters outside a valid hostname range.
|
||||
|
||||
**Fix:**
|
||||
```js
|
||||
if (!/^[a-zA-Z0-9._-]+$/.test(hostname)) {
|
||||
return res.status(400).json({ error: 'Invalid hostname format' });
|
||||
}
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
### M-6 — Vendor Field Validated Before Trim
|
||||
|
||||
**File:** `backend/routes/ivantiTodoQueue.js:8, 56`
|
||||
|
||||
Vendor length is validated before `.trim()` is called. A string of 200 spaces passes validation but becomes an empty string after trimming, which then passes without a vendor value for FP/Archer items that require one.
|
||||
|
||||
**Fix:** Trim first, then validate length and presence.
|
||||
|
||||
---
|
||||
|
||||
### M-7 — Unsanitized Original Filename Stored in Compliance Temp JSON
|
||||
|
||||
**File:** `backend/routes/compliance.js:262`
|
||||
|
||||
```js
|
||||
filename: req.file.originalname, // user-controlled, unsanitized
|
||||
```
|
||||
|
||||
The original filename is stored in the temp JSON and later echoed back to the frontend. Special characters could cause log injection or unexpected display issues.
|
||||
|
||||
**Fix:** `filename: sanitizePathSegment(req.file.originalname)`.
|
||||
|
||||
---
|
||||
|
||||
### M-8 — Hardcoded Frontend Origin in CSP Header
|
||||
|
||||
**File:** `backend/routes/knowledgeBase.js:261`
|
||||
|
||||
```js
|
||||
res.setHeader('Content-Security-Policy',
|
||||
"frame-ancestors 'self' http://71.85.90.9:3000 http://localhost:3000");
|
||||
```
|
||||
|
||||
IP address is hardcoded. If the deployment IP changes, the CSP header will block inline document viewing without an obvious error and require a code change.
|
||||
|
||||
**Fix:** Use `CORS_ORIGINS` from the environment variable.
|
||||
|
||||
---
|
||||
|
||||
### M-9 — Sensitive API Error Messages Forwarded to UI
|
||||
|
||||
**Files:** `frontend/src/App.js:801, 816, 847, 886`
|
||||
|
||||
```js
|
||||
} catch (err) {
|
||||
alert(`Error: ${err.message}`);
|
||||
}
|
||||
```
|
||||
|
||||
Raw API error messages are displayed in browser alerts. If the backend leaks stack traces or query information in error responses, this information reaches the user directly.
|
||||
|
||||
**Fix:** Show generic user-facing messages; log details to the console in development only.
|
||||
|
||||
---
|
||||
|
||||
### M-10 — User-Supplied Data in window.confirm Dialogs
|
||||
|
||||
**File:** `frontend/src/App.js:806, 891`
|
||||
|
||||
```js
|
||||
if (!window.confirm(`Delete ticket ${ticket.ticket_key}?`)) return;
|
||||
```
|
||||
|
||||
A ticket with a crafted `ticket_key` value (e.g. containing newlines or misleading text) could produce a deceptive confirmation dialog used to social-engineer users.
|
||||
|
||||
**Fix:** Use a React modal component with escaped, controlled text instead of `window.confirm`.
|
||||
|
||||
---
|
||||
|
||||
## Low / Info Findings
|
||||
|
||||
---
|
||||
|
||||
### L-1 — Silent ROLLBACK on Compliance Transaction Failure
|
||||
|
||||
**File:** `backend/routes/compliance.js:167`
|
||||
|
||||
```js
|
||||
await dbRun(db, 'ROLLBACK').catch(() => {});
|
||||
```
|
||||
|
||||
If the rollback itself fails, the error is swallowed entirely. A failed rollback leaves an open transaction that can cause subsequent operations to block.
|
||||
|
||||
**Fix:** Log rollback failures even if execution continues.
|
||||
|
||||
---
|
||||
|
||||
### L-2 — Fire-and-Forget Audit Logging
|
||||
|
||||
**File:** `backend/helpers/auditLog.js:9`
|
||||
|
||||
Audit log writes fail silently. If the database is under load or unavailable, audit records are dropped with no alert.
|
||||
|
||||
**Fix:** Log audit write failures to stderr so they surface in server logs.
|
||||
|
||||
---
|
||||
|
||||
### L-3 — Async Temp File Cleanup With No Error Handling
|
||||
|
||||
**File:** `backend/routes/compliance.js:239, 247, 266, 281, 322`
|
||||
|
||||
```js
|
||||
fs.unlink(req.file.path, () => {});
|
||||
```
|
||||
|
||||
Cleanup failures accumulate silently, potentially causing disk exhaustion over time.
|
||||
|
||||
**Fix:** Log errors on unlink failure (excluding ENOENT which is expected).
|
||||
|
||||
---
|
||||
|
||||
### L-4 — IVANTI_SKIP_TLS Disables Certificate Validation
|
||||
|
||||
**File:** `backend/routes/ivantiFindings.js:385`
|
||||
|
||||
`IVANTI_SKIP_TLS=true` disables TLS verification for all Ivanti API calls, enabling man-in-the-middle attacks against the sync. It is controlled purely by environment variable with no warning.
|
||||
|
||||
**Fix:** Log a prominent warning on startup when this flag is active, and ensure it is never set in production.
|
||||
|
||||
---
|
||||
|
||||
### L-5 — console.error in Production Frontend Code
|
||||
|
||||
**Files:** `frontend/src/contexts/AuthContext.js:26`, `KnowledgeBaseViewer.js:31, 56`
|
||||
|
||||
Full error objects are logged to the browser console in production builds. In a monitored environment, these could expose internal details to anyone with DevTools open.
|
||||
|
||||
**Fix:** Guard with `if (process.env.NODE_ENV === 'development')` or use a structured logging library.
|
||||
|
||||
---
|
||||
|
||||
### L-6 — localStorage Column Config Lacks Structural Validation
|
||||
|
||||
**File:** `frontend/src/components/pages/ReportingPage.js:51–68`
|
||||
|
||||
Column order/visibility is loaded from `localStorage` and merged with defaults. If the stored data is tampered with (via XSS or DevTools), the parsed structure is used with only partial validation.
|
||||
|
||||
**Fix:** Validate each loaded item against the known `COLUMN_DEFS` whitelist before use (a `hasOwnProperty` check is already present; ensure it runs on every item before the merge).
|
||||
|
||||
---
|
||||
|
||||
## Summary Table
|
||||
|
||||
| ID | Severity | Title | File |
|
||||
|----|----------|-------|------|
|
||||
| C-1 | Critical | Missing auth on Ivanti findings endpoints | ivantiFindings.js:552 |
|
||||
| C-2 | Critical | requireRole(db) call bypasses role check in KB routes | knowledgeBase.js:43,305 |
|
||||
| C-3 | Critical | Unauthenticated finding note writes | ivantiFindings.js:639 |
|
||||
| C-4 | Critical | No brute force protection on login | auth.js:10 |
|
||||
| C-5 | Critical | Default credentials displayed in login UI | LoginForm.js:104 |
|
||||
| C-6 | Critical | Missing sandbox on PDF/document iframe | KnowledgeBaseViewer.js:195 |
|
||||
| H-1 | High | /cleanup-sessions missing role check | auth.js:223 |
|
||||
| H-2 | High | Hardcoded fallback SESSION_SECRET | server.js:31 |
|
||||
| H-3 | High | Audit log parameter mismatch — silent trail gaps | archerTickets.js, knowledgeBase.js |
|
||||
| H-4 | High | Viewers can write compliance notes | compliance.js:522 |
|
||||
| H-5 | High | Sync endpoints accessible to all authenticated users | ivantiFindings.js:561, ivantiWorkflows.js:262 |
|
||||
| H-6 | High | HTTP header injection via Content-Disposition filename | knowledgeBase.js:258,299 |
|
||||
| H-7 | High | Race condition in KB file upload | knowledgeBase.js:91 |
|
||||
| H-8 | High | Hardcoded default admin password in setup.js | setup.js:175 |
|
||||
| H-9 | High | ReactMarkdown renders HTML without sanitization | KnowledgeBaseViewer.js:169 |
|
||||
| M-1 | Medium | No CSRF token protection | All state-changing routes |
|
||||
| M-2 | Medium | CORS credentials with explicit origin list | server.js:111 |
|
||||
| M-3 | Medium | No rate limiting on NVD API proxy | nvdLookup.js:13 |
|
||||
| M-4 | Medium | Admin self-demotion check uses loose equality | users.js:118 |
|
||||
| M-5 | Medium | Missing hostname format validation | compliance.js:451 |
|
||||
| M-6 | Medium | Vendor field validated before trim | ivantiTodoQueue.js:8,56 |
|
||||
| M-7 | Medium | Unsanitized original filename in temp JSON | compliance.js:262 |
|
||||
| M-8 | Medium | Hardcoded frontend IP in CSP header | knowledgeBase.js:261 |
|
||||
| M-9 | Medium | API error messages forwarded to UI | App.js:801,816,847,886 |
|
||||
| M-10 | Medium | User data in window.confirm dialogs | App.js:806,891 |
|
||||
| L-1 | Low | Silent ROLLBACK on transaction failure | compliance.js:167 |
|
||||
| L-2 | Low | Fire-and-forget audit logging | auditLog.js:9 |
|
||||
| L-3 | Low | Async temp file cleanup with no error handling | compliance.js:239+ |
|
||||
| L-4 | Low | IVANTI_SKIP_TLS with no startup warning | ivantiFindings.js:385 |
|
||||
| L-5 | Low | console.error exposed in production frontend | AuthContext.js, KnowledgeBaseViewer.js |
|
||||
| L-6 | Low | localStorage column config lacks structural validation | ReportingPage.js:51 |
|
||||
|
||||
---
|
||||
|
||||
## Remediation Priority
|
||||
|
||||
### Immediate — fix before adding users
|
||||
|
||||
1. **C-1** — Add `requireAuth` import and router-level middleware to `ivantiFindings.js`
|
||||
2. **C-2** — Remove `db` from all `requireRole(db, ...)` calls in `knowledgeBase.js`
|
||||
3. **C-3** — Add `requireAuth(db)` to the finding note PUT route
|
||||
4. **C-4** — Add `express-rate-limit` to the login route (20 attempts / 15 min)
|
||||
5. **C-5** — Remove default credentials from `LoginForm.js`
|
||||
6. **H-2** — Hard-fail on startup if `SESSION_SECRET` is not set in env
|
||||
|
||||
### Short-term — next maintenance window
|
||||
|
||||
7. **C-6** — Add `sandbox` attribute to the KB iframe
|
||||
8. **H-3** — Fix `logAudit` call signatures in `archerTickets.js` and `knowledgeBase.js`
|
||||
9. **H-4** — Add `requireRole('editor', 'admin')` to POST /compliance/notes
|
||||
10. **H-5** — Add `requireRole('editor', 'admin')` to both POST /sync routes
|
||||
11. **H-6** — Sanitize filename for `Content-Disposition` header
|
||||
12. **H-7** — Move file after DB insert succeeds in KB upload
|
||||
13. **H-8** — Remove hardcoded password from `setup.js`; generate random on first run
|
||||
14. **H-9** — Add `rehype-sanitize` to `ReactMarkdown` usage
|
||||
|
||||
### Medium-term
|
||||
|
||||
15. **M-1** — Implement CSRF token or upgrade cookie to `SameSite: strict`
|
||||
16. **M-3** — Add server-side CVE lookup cache
|
||||
17. **M-5** — Add hostname format regex validation
|
||||
18. **M-8** — Pull frontend origin from `CORS_ORIGINS` env var for CSP header
|
||||
19. **M-9** — Replace `alert(err.message)` with user-friendly error messages
|
||||
20. Remaining medium and low findings
|
||||
|
||||
---
|
||||
|
||||
## Positive Security Observations
|
||||
|
||||
The following were explicitly verified as secure and should be preserved:
|
||||
|
||||
- **SQL injection prevention** — all queries use SQLite3 parameterized statements throughout
|
||||
- **Path traversal prevention** — `sanitizePathSegment()` and `isPathWithinUploads()` are comprehensive and consistently applied
|
||||
- **Python script execution** — `spawn('python3', [SCRIPT, filePath])` passes arguments as an array, not a shell string — no command injection possible
|
||||
- **Python scripts** — no `eval()`, `exec()`, `pickle.load()`, or shell calls in any script
|
||||
- **File size enforcement** — 10 MB limit applied via multer before route handlers execute
|
||||
- **File type allowlisting** — extension + MIME prefix validation applied at upload
|
||||
- **Static file serving** — `express.static` with `{ dotfiles: 'deny', index: false }` prevents directory listing
|
||||
- **Temp file path validation** — `isSafeTempPath()` enforces `.json` extension on compliance temp files
|
||||
- **Password hashing** — bcrypt with cost factor 10 used throughout
|
||||
|
||||
---
|
||||
|
||||
*Audit scope: static analysis only. Dynamic testing (active exploitation, fuzzing, dependency CVE scan) not performed.*
|
||||
@@ -8,11 +8,13 @@
|
||||
"@testing-library/react": "^16.3.2",
|
||||
"@testing-library/user-event": "^13.5.0",
|
||||
"lucide-react": "^0.563.0",
|
||||
"mermaid": "^11.14.0",
|
||||
"react": "^19.2.4",
|
||||
"react-dom": "^19.2.4",
|
||||
"react-markdown": "^10.1.0",
|
||||
"react-scripts": "5.0.1",
|
||||
"recharts": "^3.8.1",
|
||||
"rehype-sanitize": "^6.0.0",
|
||||
"web-vitals": "^2.1.4",
|
||||
"xlsx": "^0.18.5"
|
||||
},
|
||||
|
||||
@@ -12,6 +12,7 @@ import VulnerabilityTriagePage from './components/pages/ReportingPage';
|
||||
import KnowledgeBasePage from './components/pages/KnowledgeBasePage';
|
||||
import ExportsPage from './components/pages/ExportsPage';
|
||||
import CompliancePage from './components/pages/CompliancePage';
|
||||
import ArchiveSummaryBar from './components/pages/ArchiveSummaryBar';
|
||||
import './App.css';
|
||||
|
||||
const API_BASE = process.env.REACT_APP_API_BASE || 'http://localhost:3001/api';
|
||||
@@ -161,7 +162,7 @@ const API_HOST = process.env.REACT_APP_API_HOST || 'http://localhost:3001';
|
||||
const severityLevels = ['All Severities', 'Critical', 'High', 'Medium', 'Low'];
|
||||
|
||||
export default function App() {
|
||||
const { isAuthenticated, loading: authLoading, canWrite, isAdmin, user } = useAuth();
|
||||
const { isAuthenticated, loading: authLoading, canWrite, canDelete, canExport, isAdmin, user } = useAuth();
|
||||
const [searchQuery, setSearchQuery] = useState('');
|
||||
const [selectedVendor, setSelectedVendor] = useState('All Vendors');
|
||||
const [selectedSeverity, setSelectedSeverity] = useState('All Severities');
|
||||
@@ -233,6 +234,12 @@ export default function App() {
|
||||
const [ivantiLoading, setIvantiLoading] = useState(false);
|
||||
const [ivantiSyncing, setIvantiSyncing] = useState(false);
|
||||
|
||||
// Archive filter state
|
||||
const [archiveFilter, setArchiveFilter] = useState(null);
|
||||
const [archiveRefreshKey, setArchiveRefreshKey] = useState(0);
|
||||
const [archiveList, setArchiveList] = useState([]);
|
||||
const [archiveListLoading, setArchiveListLoading] = useState(false);
|
||||
|
||||
const toggleCVEExpand = (cveId) => {
|
||||
setExpandedCVEs(prev => ({ ...prev, [cveId]: !prev[cveId] }));
|
||||
};
|
||||
@@ -366,6 +373,22 @@ export default function App() {
|
||||
console.error('Error syncing Ivanti workflows:', err);
|
||||
} finally {
|
||||
setIvantiSyncing(false);
|
||||
setArchiveRefreshKey(k => k + 1);
|
||||
}
|
||||
};
|
||||
|
||||
const handleArchiveStateClick = (state) => {
|
||||
const newFilter = archiveFilter === state ? null : state;
|
||||
setArchiveFilter(newFilter);
|
||||
if (newFilter) {
|
||||
setArchiveListLoading(true);
|
||||
fetch(`${API_BASE}/ivanti/archive?state=${newFilter}`, { credentials: 'include' })
|
||||
.then(res => res.ok ? res.json() : Promise.reject())
|
||||
.then(data => setArchiveList(data.archives || []))
|
||||
.catch(() => setArchiveList([]))
|
||||
.finally(() => setArchiveListLoading(false));
|
||||
} else {
|
||||
setArchiveList([]);
|
||||
}
|
||||
};
|
||||
|
||||
@@ -989,6 +1012,11 @@ export default function App() {
|
||||
{currentPage === 'compliance' && <CompliancePage onNavigate={setCurrentPage} />}
|
||||
{currentPage === 'knowledge-base' && <KnowledgeBasePage />}
|
||||
{currentPage === 'exports' && <ExportsPage />}
|
||||
{currentPage === 'admin' && isAdmin() && (
|
||||
<div className="space-y-6">
|
||||
<UserManagement onClose={() => setCurrentPage('home')} />
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* User Management Modal */}
|
||||
{showUserManagement && (
|
||||
@@ -1723,7 +1751,7 @@ export default function App() {
|
||||
<span className="text-gray-500 mx-2">•</span>
|
||||
<span className="text-gray-300">{cves.length}</span> vendor entr{cves.length !== 1 ? 'ies' : 'y'}
|
||||
</p>
|
||||
{selectedDocuments.length > 0 && (
|
||||
{selectedDocuments.length > 0 && canExport() && (
|
||||
<button
|
||||
onClick={exportSelectedDocuments}
|
||||
className="intel-button intel-button-primary flex items-center gap-2"
|
||||
@@ -1810,7 +1838,7 @@ export default function App() {
|
||||
<span>Published: {vendorEntries[0].published_date}</span>
|
||||
<span className="text-intel-accent">•</span>
|
||||
<span>{vendorEntries.length} affected vendor{vendorEntries.length > 1 ? 's' : ''}</span>
|
||||
{canWrite() && vendorEntries.length >= 2 && (
|
||||
{isAdmin() && vendorEntries.length >= 2 && (
|
||||
<button
|
||||
onClick={(e) => { e.stopPropagation(); handleDeleteEntireCVE(cveId, vendorEntries.length); }}
|
||||
className="ml-2 px-3 py-1 text-xs intel-button intel-button-danger flex items-center gap-1"
|
||||
@@ -1871,7 +1899,7 @@ export default function App() {
|
||||
<Edit2 className="w-4 h-4" />
|
||||
</button>
|
||||
)}
|
||||
{canWrite() && (
|
||||
{canDelete(cve) && (
|
||||
<button
|
||||
onClick={() => handleDeleteCVEEntry(cve)}
|
||||
className="px-3 py-2 text-intel-danger hover:bg-intel-medium rounded border border-intel-danger/50 transition-all flex items-center gap-1"
|
||||
@@ -2003,9 +2031,11 @@ export default function App() {
|
||||
<button onClick={() => handleEditTicket(ticket)} className="p-1 text-gray-400 hover:text-intel-warning transition-colors">
|
||||
<Edit2 className="w-4 h-4" />
|
||||
</button>
|
||||
{canDelete(ticket) && (
|
||||
<button onClick={() => handleDeleteTicket(ticket)} className="p-1 text-gray-400 hover:text-intel-danger transition-colors">
|
||||
<Trash2 className="w-4 h-4" />
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
@@ -2129,9 +2159,11 @@ export default function App() {
|
||||
<button onClick={() => handleEditTicket(ticket)} className="text-gray-400 hover:text-intel-warning transition-colors">
|
||||
<Edit2 className="w-3 h-3" />
|
||||
</button>
|
||||
{canDelete(ticket) && (
|
||||
<button onClick={() => handleDeleteTicket(ticket)} className="text-gray-400 hover:text-intel-danger transition-colors">
|
||||
<Trash2 className="w-3 h-3" />
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
@@ -2197,14 +2229,16 @@ export default function App() {
|
||||
>
|
||||
<Filter className="w-3 h-3" />
|
||||
</button>
|
||||
{canWrite() && (<>
|
||||
{canWrite() && (
|
||||
<button onClick={() => handleEditArcherTicket(ticket)} className="text-gray-400 hover:text-purple-400 transition-colors">
|
||||
<Edit2 className="w-3 h-3" />
|
||||
</button>
|
||||
)}
|
||||
{canDelete(ticket) && (
|
||||
<button onClick={() => handleDeleteArcherTicket(ticket)} className="text-gray-400 hover:text-intel-danger transition-colors">
|
||||
<Trash2 className="w-3 h-3" />
|
||||
</button>
|
||||
</>)}
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
<div className="text-xs text-white font-mono mb-1">{ticket.cve_id}</div>
|
||||
@@ -2233,6 +2267,7 @@ export default function App() {
|
||||
<Activity className="w-5 h-5" />
|
||||
Ivanti Workflows
|
||||
</h2>
|
||||
{canWrite() && (
|
||||
<button
|
||||
onClick={syncIvantiWorkflows}
|
||||
disabled={ivantiSyncing || ivantiLoading}
|
||||
@@ -2242,6 +2277,7 @@ export default function App() {
|
||||
<RefreshCw className={`w-3 h-3 ${ivantiSyncing ? 'animate-spin' : ''}`} />
|
||||
{ivantiSyncing ? 'Syncing…' : 'Sync'}
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Last synced line */}
|
||||
@@ -2251,6 +2287,49 @@ export default function App() {
|
||||
: 'Never synced'}
|
||||
</div>
|
||||
|
||||
{/* Archive Summary Bar */}
|
||||
<ArchiveSummaryBar onStateClick={handleArchiveStateClick} activeFilter={archiveFilter} refreshKey={archiveRefreshKey} />
|
||||
|
||||
{/* Archive list — shown when a state card is clicked */}
|
||||
{archiveFilter && (
|
||||
<div style={{ marginBottom: '1rem' }}>
|
||||
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginBottom: '0.5rem' }}>
|
||||
<span style={{ fontFamily: 'monospace', fontSize: '0.75rem', color: '#94A3B8', textTransform: 'uppercase', letterSpacing: '0.05em' }}>
|
||||
{archiveFilter} findings
|
||||
</span>
|
||||
<button
|
||||
onClick={() => { setArchiveFilter(null); setArchiveList([]); }}
|
||||
style={{ background: 'none', border: 'none', color: '#94A3B8', cursor: 'pointer', fontFamily: 'monospace', fontSize: '0.7rem' }}
|
||||
>
|
||||
✕ Clear
|
||||
</button>
|
||||
</div>
|
||||
{archiveListLoading ? (
|
||||
<div style={{ textAlign: 'center', padding: '1rem', color: '#94A3B8', fontFamily: 'monospace', fontSize: '0.75rem' }}>Loading…</div>
|
||||
) : archiveList.length === 0 ? (
|
||||
<div style={{ textAlign: 'center', padding: '1rem', color: '#64748B', fontFamily: 'monospace', fontSize: '0.72rem', border: '1px dashed rgba(100, 116, 139, 0.3)', borderRadius: '0.375rem' }}>
|
||||
No {archiveFilter.toLowerCase()} findings
|
||||
</div>
|
||||
) : (
|
||||
<div style={{ maxHeight: '240px', overflowY: 'auto', display: 'flex', flexDirection: 'column', gap: '0.375rem' }}>
|
||||
{archiveList.map((a) => (
|
||||
<div key={a.id} style={{ background: 'linear-gradient(135deg, rgba(30, 41, 59, 0.85), rgba(51, 65, 85, 0.75))', border: '1px solid rgba(100, 116, 139, 0.25)', borderRadius: '0.375rem', padding: '0.5rem' }}>
|
||||
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'start', gap: '0.5rem', marginBottom: '0.25rem' }}>
|
||||
<span style={{ fontFamily: 'monospace', fontSize: '0.7rem', fontWeight: '600', color: '#E2E8F0' }}>{a.finding_title || a.finding_id}</span>
|
||||
<span style={{ fontFamily: 'monospace', fontSize: '0.6rem', padding: '0.15rem 0.35rem', borderRadius: '0.25rem', background: 'rgba(100, 116, 139, 0.2)', border: '1px solid rgba(100, 116, 139, 0.4)', color: '#94A3B8', whiteSpace: 'nowrap' }}>
|
||||
{a.last_severity?.toFixed(1) ?? '—'}
|
||||
</span>
|
||||
</div>
|
||||
<div style={{ fontFamily: 'monospace', fontSize: '0.65rem', color: '#64748B' }}>
|
||||
{a.host_name}{a.ip_address ? ` (${a.ip_address})` : ''}
|
||||
</div>
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
)}
|
||||
|
||||
{ivantiLoading ? (
|
||||
<div className="text-center py-8">
|
||||
<Loader className="w-6 h-6 text-teal-400 animate-spin mx-auto mb-2" />
|
||||
|
||||
@@ -1,7 +1,73 @@
|
||||
import React, { useState, useEffect } from 'react';
|
||||
import React, { useState, useEffect, useRef } from 'react';
|
||||
import ReactMarkdown from 'react-markdown';
|
||||
import rehypeSanitize from 'rehype-sanitize';
|
||||
import mermaid from 'mermaid';
|
||||
import { X, Download, Loader, AlertCircle, FileText, File } from 'lucide-react';
|
||||
|
||||
mermaid.initialize({
|
||||
startOnLoad: false,
|
||||
theme: 'dark',
|
||||
darkMode: true,
|
||||
themeVariables: {
|
||||
background: '#0f172a',
|
||||
primaryColor: '#1e3a5f',
|
||||
primaryTextColor: '#e2e8f0',
|
||||
primaryBorderColor: '#0ea5e9',
|
||||
lineColor: '#475569',
|
||||
secondaryColor: '#1a2e1a',
|
||||
tertiaryColor: '#2d1f14',
|
||||
edgeLabelBackground: '#1e293b',
|
||||
clusterBkg: '#1e293b',
|
||||
titleColor: '#e2e8f0',
|
||||
fontFamily: 'monospace'
|
||||
}
|
||||
});
|
||||
|
||||
let mermaidCounter = 0;
|
||||
|
||||
function MermaidDiagram({ code }) {
|
||||
const ref = useRef(null);
|
||||
const [svgError, setSvgError] = useState('');
|
||||
|
||||
useEffect(() => {
|
||||
let cancelled = false;
|
||||
const id = `mermaid-kb-${++mermaidCounter}`;
|
||||
mermaid.render(id, code)
|
||||
.then(({ svg }) => {
|
||||
if (!cancelled && ref.current) {
|
||||
ref.current.innerHTML = svg;
|
||||
// Make SVG responsive
|
||||
const svgEl = ref.current.querySelector('svg');
|
||||
if (svgEl) {
|
||||
svgEl.removeAttribute('width');
|
||||
svgEl.removeAttribute('height');
|
||||
svgEl.style.width = '100%';
|
||||
svgEl.style.maxWidth = '100%';
|
||||
}
|
||||
}
|
||||
})
|
||||
.catch((err) => {
|
||||
if (!cancelled) setSvgError(err.message || 'Failed to render diagram');
|
||||
});
|
||||
return () => { cancelled = true; };
|
||||
}, [code]);
|
||||
|
||||
if (svgError) {
|
||||
return (
|
||||
<pre style={{ color: '#EF4444', fontSize: '0.75rem', padding: '0.75rem', background: 'rgba(239,68,68,0.1)', borderRadius: '0.375rem', overflowX: 'auto' }}>
|
||||
Mermaid render error: {svgError}
|
||||
</pre>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<div
|
||||
ref={ref}
|
||||
style={{ background: 'rgba(15,23,42,0.6)', border: '1px solid rgba(14,165,233,0.2)', borderRadius: '0.5rem', padding: '1rem', margin: '1rem 0', overflowX: 'auto' }}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
const API_BASE = process.env.REACT_APP_API_BASE || 'http://localhost:3001/api';
|
||||
|
||||
export default function KnowledgeBaseViewer({ article, onClose }) {
|
||||
@@ -167,7 +233,27 @@ export default function KnowledgeBaseViewer({ article, onClose }) {
|
||||
{/* Markdown Rendering */}
|
||||
{isMarkdown && (
|
||||
<div className="markdown-content">
|
||||
<ReactMarkdown>{content}</ReactMarkdown>
|
||||
<ReactMarkdown
|
||||
rehypePlugins={[rehypeSanitize]}
|
||||
components={{
|
||||
code({ inline, className, children }) {
|
||||
const lang = /language-(\w+)/.exec(className || '')?.[1];
|
||||
if (!inline && lang === 'mermaid') {
|
||||
return <MermaidDiagram code={String(children).replace(/\n$/, '')} />;
|
||||
}
|
||||
return (
|
||||
<code
|
||||
className={className}
|
||||
style={inline ? { background: 'rgba(14,165,233,0.15)', padding: '0.1rem 0.3rem', borderRadius: '0.25rem', fontFamily: 'monospace', fontSize: '0.85em' } : {}}
|
||||
>
|
||||
{children}
|
||||
</code>
|
||||
);
|
||||
}
|
||||
}}
|
||||
>
|
||||
{content}
|
||||
</ReactMarkdown>
|
||||
</div>
|
||||
)}
|
||||
|
||||
@@ -193,6 +279,7 @@ export default function KnowledgeBaseViewer({ article, onClose }) {
|
||||
{isPDF && (
|
||||
<div className="w-full" style={{ height: '700px' }}>
|
||||
<iframe
|
||||
sandbox="allow-same-origin"
|
||||
src={`${API_BASE}/knowledge-base/${article.id}/content`}
|
||||
title={article.title}
|
||||
className="w-full h-full rounded"
|
||||
|
||||
@@ -98,12 +98,6 @@ export default function LoginForm() {
|
||||
)}
|
||||
</button>
|
||||
</form>
|
||||
|
||||
<div className="mt-6 pt-6 border-t border-intel-grid">
|
||||
<p className="text-sm text-gray-500 text-center font-mono">
|
||||
Default: <span className="text-intel-accent">admin</span> / <span className="text-intel-accent">admin123</span>
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import React from 'react';
|
||||
import { X, Home, BarChart2, BookOpen, Download, ShieldCheck } from 'lucide-react';
|
||||
import { X, Home, BarChart2, BookOpen, Download, ShieldCheck, Settings } from 'lucide-react';
|
||||
import { useAuth } from '../contexts/AuthContext';
|
||||
|
||||
const NAV_ITEMS = [
|
||||
{ id: 'home', label: 'Home', icon: Home, color: '#0EA5E9', description: 'Main dashboard' },
|
||||
@@ -9,7 +10,11 @@ const NAV_ITEMS = [
|
||||
{ id: 'exports', label: 'Exports', icon: Download, color: '#8B5CF6', description: 'Export data & reports' },
|
||||
];
|
||||
|
||||
const ADMIN_ITEM = { id: 'admin', label: 'Admin Panel', icon: Settings, color: '#EF4444', description: 'User management & audit' };
|
||||
|
||||
export default function NavDrawer({ isOpen, onClose, currentPage, onNavigate }) {
|
||||
const { isAdmin } = useAuth();
|
||||
|
||||
if (!isOpen) return null;
|
||||
|
||||
return (
|
||||
@@ -110,6 +115,60 @@ export default function NavDrawer({ isOpen, onClose, currentPage, onNavigate })
|
||||
</button>
|
||||
);
|
||||
})}
|
||||
|
||||
{/* Admin panel link — visible only to Admin group */}
|
||||
{isAdmin() && (() => {
|
||||
const { id, label, icon: Icon, color, description } = ADMIN_ITEM;
|
||||
const active = currentPage === id;
|
||||
return (
|
||||
<button
|
||||
key={id}
|
||||
onClick={() => { onNavigate(id); onClose(); }}
|
||||
style={{
|
||||
display: 'flex', alignItems: 'center', gap: '0.875rem',
|
||||
padding: '0.75rem 0.875rem',
|
||||
borderRadius: '0.5rem',
|
||||
border: active ? `1px solid ${color}50` : '1px solid transparent',
|
||||
background: active ? `${color}18` : 'transparent',
|
||||
cursor: 'pointer', textAlign: 'left', width: '100%',
|
||||
marginTop: '0.5rem',
|
||||
borderTop: '1px solid rgba(255, 255, 255, 0.05)',
|
||||
paddingTop: '1rem',
|
||||
transition: 'background 0.15s, border-color 0.15s'
|
||||
}}
|
||||
onMouseEnter={e => { if (!active) e.currentTarget.style.background = 'rgba(255,255,255,0.04)'; }}
|
||||
onMouseLeave={e => { if (!active) e.currentTarget.style.background = 'transparent'; }}
|
||||
>
|
||||
<div style={{
|
||||
width: '36px', height: '36px', flexShrink: 0,
|
||||
borderRadius: '0.375rem',
|
||||
background: `${color}18`,
|
||||
border: `1px solid ${color}40`,
|
||||
display: 'flex', alignItems: 'center', justifyContent: 'center'
|
||||
}}>
|
||||
<Icon style={{ width: '17px', height: '17px', color }} />
|
||||
</div>
|
||||
<div style={{ flex: 1, minWidth: 0 }}>
|
||||
<div style={{
|
||||
fontFamily: 'monospace', fontSize: '0.8rem', fontWeight: '600',
|
||||
color: active ? color : '#CBD5E1',
|
||||
textTransform: 'uppercase', letterSpacing: '0.06em'
|
||||
}}>
|
||||
{label}
|
||||
</div>
|
||||
<div style={{ fontSize: '0.68rem', color: '#475569', marginTop: '1px' }}>
|
||||
{description}
|
||||
</div>
|
||||
</div>
|
||||
{active && (
|
||||
<div style={{
|
||||
width: '6px', height: '6px', borderRadius: '50%',
|
||||
background: color, boxShadow: `0 0 8px ${color}`, flexShrink: 0
|
||||
}} />
|
||||
)}
|
||||
</button>
|
||||
);
|
||||
})()}
|
||||
</nav>
|
||||
|
||||
{/* Footer */}
|
||||
|
||||
@@ -4,6 +4,22 @@ import { useAuth } from '../contexts/AuthContext';
|
||||
|
||||
const API_BASE = process.env.REACT_APP_API_BASE || 'http://localhost:3001/api';
|
||||
|
||||
const VALID_GROUPS = ['Admin', 'Standard_User', 'Leadership', 'Read_Only'];
|
||||
|
||||
const GROUP_LABELS = {
|
||||
Admin: 'Admin (full access)',
|
||||
Standard_User: 'Standard User (create, edit, limited delete)',
|
||||
Leadership: 'Leadership (read-only + exports)',
|
||||
Read_Only: 'Read Only (view only)'
|
||||
};
|
||||
|
||||
const GROUP_BADGE_STYLES = {
|
||||
Admin: { backgroundColor: '#FEE2E2', color: '#991B1B' },
|
||||
Standard_User: { backgroundColor: '#DBEAFE', color: '#1E40AF' },
|
||||
Leadership: { backgroundColor: '#F3E8FF', color: '#6B21A8' },
|
||||
Read_Only: { backgroundColor: '#F3F4F6', color: '#374151' }
|
||||
};
|
||||
|
||||
export default function UserManagement({ onClose }) {
|
||||
const { user: currentUser } = useAuth();
|
||||
const [users, setUsers] = useState([]);
|
||||
@@ -15,7 +31,7 @@ export default function UserManagement({ onClose }) {
|
||||
username: '',
|
||||
email: '',
|
||||
password: '',
|
||||
role: 'viewer'
|
||||
group: 'Read_Only'
|
||||
});
|
||||
const [formError, setFormError] = useState('');
|
||||
const [formSuccess, setFormSuccess] = useState('');
|
||||
@@ -39,11 +55,29 @@ export default function UserManagement({ onClose }) {
|
||||
}
|
||||
};
|
||||
|
||||
const confirmGroupChange = (targetUser, newGroup) => {
|
||||
let message = `Are you sure you want to change ${targetUser.username}'s group from ${targetUser.group} to ${newGroup}?`;
|
||||
|
||||
// Extra warning when downgrading an Admin user
|
||||
if (targetUser.group === 'Admin' && newGroup !== 'Admin') {
|
||||
message += `\n\n⚠️ WARNING: You are removing Admin privileges from ${targetUser.username}. They will lose full system access.`;
|
||||
}
|
||||
|
||||
return window.confirm(message);
|
||||
};
|
||||
|
||||
const handleSubmit = async (e) => {
|
||||
e.preventDefault();
|
||||
setFormError('');
|
||||
setFormSuccess('');
|
||||
|
||||
// If editing and group changed, show confirmation dialog
|
||||
if (editingUser && formData.group !== editingUser.group) {
|
||||
if (!confirmGroupChange(editingUser, formData.group)) {
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
try {
|
||||
const url = editingUser
|
||||
? `${API_BASE}/users/${editingUser.id}`
|
||||
@@ -75,7 +109,7 @@ export default function UserManagement({ onClose }) {
|
||||
setTimeout(() => {
|
||||
setShowAddUser(false);
|
||||
setEditingUser(null);
|
||||
setFormData({ username: '', email: '', password: '', role: 'viewer' });
|
||||
setFormData({ username: '', email: '', password: '', group: 'Read_Only' });
|
||||
setFormSuccess('');
|
||||
}, 1500);
|
||||
} catch (err) {
|
||||
@@ -89,7 +123,7 @@ export default function UserManagement({ onClose }) {
|
||||
username: user.username,
|
||||
email: user.email,
|
||||
password: '',
|
||||
role: user.role
|
||||
group: user.group
|
||||
});
|
||||
setShowAddUser(true);
|
||||
setFormError('');
|
||||
@@ -140,15 +174,10 @@ export default function UserManagement({ onClose }) {
|
||||
}
|
||||
};
|
||||
|
||||
const getRoleBadgeColor = (role) => {
|
||||
switch (role) {
|
||||
case 'admin':
|
||||
return 'bg-red-100 text-red-800';
|
||||
case 'editor':
|
||||
return 'bg-blue-100 text-blue-800';
|
||||
default:
|
||||
return 'bg-gray-100 text-gray-800';
|
||||
}
|
||||
// Check if group dropdown should be disabled for self-demotion prevention
|
||||
const isGroupDropdownDisabled = (targetUser) => {
|
||||
if (!targetUser || !currentUser) return false;
|
||||
return targetUser.id === currentUser.id && currentUser.group === 'Admin';
|
||||
};
|
||||
|
||||
return (
|
||||
@@ -173,7 +202,7 @@ export default function UserManagement({ onClose }) {
|
||||
onClick={() => {
|
||||
setShowAddUser(true);
|
||||
setEditingUser(null);
|
||||
setFormData({ username: '', email: '', password: '', role: 'viewer' });
|
||||
setFormData({ username: '', email: '', password: '', group: 'Read_Only' });
|
||||
setFormError('');
|
||||
setFormSuccess('');
|
||||
}}
|
||||
@@ -253,19 +282,24 @@ export default function UserManagement({ onClose }) {
|
||||
|
||||
<div>
|
||||
<label className="block text-sm font-medium text-gray-700 mb-1">
|
||||
Role *
|
||||
Group *
|
||||
</label>
|
||||
<div className="relative">
|
||||
<Shield className="w-5 h-5 text-gray-400 absolute left-3 top-1/2 transform -translate-y-1/2" />
|
||||
<select
|
||||
value={formData.role}
|
||||
onChange={(e) => setFormData({ ...formData, role: e.target.value })}
|
||||
className="w-full pl-10 pr-4 py-2 border border-gray-300 rounded-lg focus:ring-2 focus:ring-[#0476D9] focus:border-transparent"
|
||||
value={formData.group}
|
||||
onChange={(e) => setFormData({ ...formData, group: e.target.value })}
|
||||
disabled={isGroupDropdownDisabled(editingUser)}
|
||||
className="w-full pl-10 pr-4 py-2 border border-gray-300 rounded-lg focus:ring-2 focus:ring-[#0476D9] focus:border-transparent disabled:opacity-50 disabled:cursor-not-allowed"
|
||||
title={isGroupDropdownDisabled(editingUser) ? 'Cannot change your own Admin group' : ''}
|
||||
>
|
||||
<option value="viewer">Viewer (read-only)</option>
|
||||
<option value="editor">Editor (can add CVEs, upload docs)</option>
|
||||
<option value="admin">Admin (full access)</option>
|
||||
{VALID_GROUPS.map((g) => (
|
||||
<option key={g} value={g}>{GROUP_LABELS[g]}</option>
|
||||
))}
|
||||
</select>
|
||||
{isGroupDropdownDisabled(editingUser) && (
|
||||
<p className="text-xs text-amber-600 mt-1">You cannot change your own Admin group.</p>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
@@ -308,7 +342,7 @@ export default function UserManagement({ onClose }) {
|
||||
<thead>
|
||||
<tr className="border-b border-gray-200">
|
||||
<th className="text-left py-3 px-4 text-sm font-medium text-gray-700">User</th>
|
||||
<th className="text-left py-3 px-4 text-sm font-medium text-gray-700">Role</th>
|
||||
<th className="text-left py-3 px-4 text-sm font-medium text-gray-700">Group</th>
|
||||
<th className="text-left py-3 px-4 text-sm font-medium text-gray-700">Status</th>
|
||||
<th className="text-left py-3 px-4 text-sm font-medium text-gray-700">Last Login</th>
|
||||
<th className="text-right py-3 px-4 text-sm font-medium text-gray-700">Actions</th>
|
||||
@@ -324,8 +358,17 @@ export default function UserManagement({ onClose }) {
|
||||
</div>
|
||||
</td>
|
||||
<td className="py-3 px-4">
|
||||
<span className={`px-2 py-1 rounded text-xs font-medium ${getRoleBadgeColor(user.role)}`}>
|
||||
{user.role.charAt(0).toUpperCase() + user.role.slice(1)}
|
||||
<span
|
||||
style={{
|
||||
...GROUP_BADGE_STYLES[user.group] || GROUP_BADGE_STYLES.Read_Only,
|
||||
padding: '2px 8px',
|
||||
borderRadius: '4px',
|
||||
fontSize: '12px',
|
||||
fontWeight: '500',
|
||||
display: 'inline-block'
|
||||
}}
|
||||
>
|
||||
{user.group ? user.group.replace('_', ' ') : 'Read Only'}
|
||||
</span>
|
||||
</td>
|
||||
<td className="py-3 px-4">
|
||||
|
||||
@@ -19,17 +19,26 @@ export default function UserMenu({ onManageUsers, onAuditLog }) {
|
||||
return () => document.removeEventListener('mousedown', handleClickOutside);
|
||||
}, []);
|
||||
|
||||
const getRoleBadgeColor = (role) => {
|
||||
switch (role) {
|
||||
case 'admin':
|
||||
const getGroupBadgeColor = (group) => {
|
||||
switch (group) {
|
||||
case 'Admin':
|
||||
return 'bg-red-100 text-red-800';
|
||||
case 'editor':
|
||||
case 'Standard_User':
|
||||
return 'bg-blue-100 text-blue-800';
|
||||
case 'Leadership':
|
||||
return 'bg-purple-100 text-purple-800';
|
||||
case 'Read_Only':
|
||||
return 'bg-gray-100 text-gray-800';
|
||||
default:
|
||||
return 'bg-gray-100 text-gray-800';
|
||||
}
|
||||
};
|
||||
|
||||
const formatGroupName = (group) => {
|
||||
if (!group) return '';
|
||||
return group.replace(/_/g, ' ');
|
||||
};
|
||||
|
||||
const handleLogout = async () => {
|
||||
setIsOpen(false);
|
||||
await logout();
|
||||
@@ -62,7 +71,7 @@ export default function UserMenu({ onManageUsers, onAuditLog }) {
|
||||
</div>
|
||||
<div className="text-left hidden sm:block">
|
||||
<p className="text-sm font-medium text-gray-900">{user.username}</p>
|
||||
<p className="text-xs text-gray-500 capitalize">{user.role}</p>
|
||||
<p className="text-xs text-gray-500">{formatGroupName(user.group)}</p>
|
||||
</div>
|
||||
<ChevronDown className={`w-4 h-4 text-gray-500 transition-transform ${isOpen ? 'rotate-180' : ''}`} />
|
||||
</button>
|
||||
@@ -72,8 +81,8 @@ export default function UserMenu({ onManageUsers, onAuditLog }) {
|
||||
<div className="px-4 py-3 border-b border-gray-100">
|
||||
<p className="text-sm font-medium text-gray-900">{user.username}</p>
|
||||
<p className="text-sm text-gray-500">{user.email}</p>
|
||||
<span className={`inline-block mt-2 px-2 py-1 rounded text-xs font-medium ${getRoleBadgeColor(user.role)}`}>
|
||||
{user.role.charAt(0).toUpperCase() + user.role.slice(1)}
|
||||
<span className={`inline-block mt-2 px-2 py-1 rounded text-xs font-medium ${getGroupBadgeColor(user.group)}`}>
|
||||
{formatGroupName(user.group)}
|
||||
</span>
|
||||
</div>
|
||||
|
||||
|
||||
205
frontend/src/components/pages/ArchiveSummaryBar.js
Normal file
205
frontend/src/components/pages/ArchiveSummaryBar.js
Normal file
@@ -0,0 +1,205 @@
|
||||
// ArchiveSummaryBar.js
|
||||
// Displays four stat cards for archive lifecycle states: ACTIVE, ARCHIVED, RETURNED, CLOSED.
|
||||
// Fetches counts from /api/ivanti/archive/stats on mount.
|
||||
|
||||
import React, { useState, useEffect } from 'react';
|
||||
import { Activity, Archive, RotateCcw, XCircle, Loader } from 'lucide-react';
|
||||
|
||||
const API_BASE = process.env.REACT_APP_API_BASE || 'http://localhost:3001/api';
|
||||
|
||||
const STATE_CONFIG = [
|
||||
{
|
||||
key: 'ACTIVE',
|
||||
label: 'Active',
|
||||
color: '#0EA5E9',
|
||||
Icon: Activity,
|
||||
},
|
||||
{
|
||||
key: 'ARCHIVED',
|
||||
label: 'Archived',
|
||||
color: '#F59E0B',
|
||||
Icon: Archive,
|
||||
},
|
||||
{
|
||||
key: 'RETURNED',
|
||||
label: 'Returned',
|
||||
color: '#10B981',
|
||||
Icon: RotateCcw,
|
||||
},
|
||||
{
|
||||
key: 'CLOSED',
|
||||
label: 'Closed',
|
||||
color: '#EF4444',
|
||||
Icon: XCircle,
|
||||
},
|
||||
];
|
||||
|
||||
function StatCard({ stateKey, label, color, Icon, count, active, onClick }) {
|
||||
const [hovered, setHovered] = useState(false);
|
||||
|
||||
const isHighlighted = active || hovered;
|
||||
|
||||
const cardStyle = {
|
||||
flex: '1 1 0',
|
||||
minWidth: '140px',
|
||||
background: 'linear-gradient(135deg, rgba(30, 41, 59, 0.95), rgba(51, 65, 85, 0.9))',
|
||||
border: `2px solid ${isHighlighted ? color : `rgba(${hexToRgb(color)}, 0.3)`}`,
|
||||
borderRadius: '0.5rem',
|
||||
padding: '1rem',
|
||||
cursor: 'pointer',
|
||||
transition: 'all 0.3s cubic-bezier(0.4, 0, 0.2, 1)',
|
||||
transform: isHighlighted ? 'translateY(-2px)' : 'translateY(0)',
|
||||
boxShadow: isHighlighted
|
||||
? `0 4px 16px rgba(0, 0, 0, 0.5), 0 0 20px rgba(${hexToRgb(color)}, 0.25)`
|
||||
: '0 4px 16px rgba(0, 0, 0, 0.5)',
|
||||
position: 'relative',
|
||||
overflow: 'hidden',
|
||||
};
|
||||
|
||||
const accentLineStyle = {
|
||||
position: 'absolute',
|
||||
top: 0,
|
||||
left: 0,
|
||||
right: 0,
|
||||
height: '2px',
|
||||
background: `linear-gradient(90deg, transparent, ${color}, transparent)`,
|
||||
boxShadow: `0 0 8px ${color}`,
|
||||
};
|
||||
|
||||
return (
|
||||
<div
|
||||
style={cardStyle}
|
||||
onClick={() => onClick(stateKey)}
|
||||
onMouseEnter={() => setHovered(true)}
|
||||
onMouseLeave={() => setHovered(false)}
|
||||
role="button"
|
||||
tabIndex={0}
|
||||
onKeyDown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); onClick(stateKey); } }}
|
||||
aria-label={`${label}: ${count} findings. ${active ? 'Currently filtered.' : 'Click to filter.'}`}
|
||||
>
|
||||
<div style={accentLineStyle} />
|
||||
<div style={{ display: 'flex', alignItems: 'center', gap: '0.5rem', marginBottom: '0.625rem' }}>
|
||||
<Icon
|
||||
style={{
|
||||
width: '16px',
|
||||
height: '16px',
|
||||
color: color,
|
||||
filter: isHighlighted ? `drop-shadow(0 0 4px ${color})` : 'none',
|
||||
}}
|
||||
/>
|
||||
<span style={{
|
||||
fontFamily: "'JetBrains Mono', 'Fira Code', monospace",
|
||||
fontSize: '0.7rem',
|
||||
fontWeight: '600',
|
||||
color: color,
|
||||
textTransform: 'uppercase',
|
||||
letterSpacing: '0.08em',
|
||||
textShadow: isHighlighted ? `0 0 8px rgba(${hexToRgb(color)}, 0.5)` : 'none',
|
||||
}}>
|
||||
{label}
|
||||
</span>
|
||||
</div>
|
||||
<div style={{
|
||||
fontFamily: "'JetBrains Mono', 'Fira Code', monospace",
|
||||
fontSize: '1.75rem',
|
||||
fontWeight: '700',
|
||||
color: '#F8FAFC',
|
||||
lineHeight: 1,
|
||||
textShadow: `0 0 16px rgba(${hexToRgb(color)}, 0.3)`,
|
||||
}}>
|
||||
{count != null ? count : '—'}
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// Convert hex color to r, g, b string for use in rgba()
|
||||
function hexToRgb(hex) {
|
||||
const r = parseInt(hex.slice(1, 3), 16);
|
||||
const g = parseInt(hex.slice(3, 5), 16);
|
||||
const b = parseInt(hex.slice(5, 7), 16);
|
||||
return `${r}, ${g}, ${b}`;
|
||||
}
|
||||
|
||||
export default function ArchiveSummaryBar({ onStateClick, activeFilter, refreshKey }) {
|
||||
const [stats, setStats] = useState(null);
|
||||
const [loading, setLoading] = useState(true);
|
||||
const [error, setError] = useState(false);
|
||||
|
||||
useEffect(() => {
|
||||
let cancelled = false;
|
||||
const load = async () => {
|
||||
setLoading(true);
|
||||
setError(false);
|
||||
try {
|
||||
const res = await fetch(`${API_BASE}/ivanti/archive/stats`, { credentials: 'include' });
|
||||
if (res.ok && !cancelled) {
|
||||
const data = await res.json();
|
||||
setStats(data);
|
||||
} else if (!cancelled) {
|
||||
setError(true);
|
||||
}
|
||||
} catch {
|
||||
if (!cancelled) setError(true);
|
||||
} finally {
|
||||
if (!cancelled) setLoading(false);
|
||||
}
|
||||
};
|
||||
load();
|
||||
|
||||
// Re-fetch every 60s so stats stay reasonably fresh after syncs
|
||||
const interval = setInterval(load, 60000);
|
||||
return () => { cancelled = true; clearInterval(interval); };
|
||||
}, [refreshKey]);
|
||||
|
||||
if (loading) {
|
||||
return (
|
||||
<div style={{
|
||||
display: 'flex', alignItems: 'center', justifyContent: 'center',
|
||||
gap: '0.5rem', padding: '1.25rem',
|
||||
color: '#94A3B8', fontFamily: 'monospace', fontSize: '0.75rem',
|
||||
}}>
|
||||
<Loader style={{ width: '14px', height: '14px', animation: 'spin 1s linear infinite' }} />
|
||||
Loading archive stats…
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
if (error) {
|
||||
return (
|
||||
<div style={{
|
||||
padding: '1rem', textAlign: 'center',
|
||||
color: '#94A3B8', fontFamily: 'monospace', fontSize: '0.72rem',
|
||||
border: '1px dashed rgba(239, 68, 68, 0.2)', borderRadius: '0.375rem',
|
||||
}}>
|
||||
Unable to load archive statistics
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const handleClick = (state) => {
|
||||
if (onStateClick) onStateClick(state);
|
||||
};
|
||||
|
||||
return (
|
||||
<div style={{
|
||||
display: 'flex',
|
||||
gap: '0.75rem',
|
||||
marginBottom: '1.25rem',
|
||||
flexWrap: 'wrap',
|
||||
}}>
|
||||
{STATE_CONFIG.map(({ key, label, color, Icon }) => (
|
||||
<StatCard
|
||||
key={key}
|
||||
stateKey={key}
|
||||
label={label}
|
||||
color={color}
|
||||
Icon={Icon}
|
||||
count={stats?.[key] ?? 0}
|
||||
active={activeFilter === key}
|
||||
onClick={handleClick}
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -1,6 +1,7 @@
|
||||
import React, { useState, useCallback } from 'react';
|
||||
import * as XLSX from 'xlsx';
|
||||
import { Download, Loader, AlertCircle, BarChart2, FileText, Shield, Tag, CheckCircle, X } from 'lucide-react';
|
||||
import { useAuth } from '../../contexts/AuthContext';
|
||||
|
||||
const API_BASE = process.env.REACT_APP_API_BASE || 'http://localhost:3001/api';
|
||||
const EXC_PATTERN = /EXC-\d+/i;
|
||||
@@ -217,6 +218,7 @@ function Toggle({ label, checked, onChange, color, colorRgb }) {
|
||||
// Main page
|
||||
// ---------------------------------------------------------------------------
|
||||
export default function ExportsPage() {
|
||||
const { canExport } = useAuth();
|
||||
const [loading, setLoading] = useState(null);
|
||||
const [error, setError] = useState(null);
|
||||
const [cveStatus, setCveStatus] = useState('');
|
||||
@@ -333,6 +335,15 @@ export default function ExportsPage() {
|
||||
|
||||
// ---- Render ----
|
||||
|
||||
if (!canExport()) {
|
||||
return (
|
||||
<div style={{ textAlign: 'center', padding: '4rem 1rem', color: '#94A3B8' }}>
|
||||
<Shield style={{ width: '48px', height: '48px', margin: '0 auto 1rem', opacity: 0.5 }} />
|
||||
<p style={{ fontFamily: 'monospace', fontSize: '0.9rem' }}>You do not have permission to export data.</p>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<div style={{ padding: '1.5rem', display: 'flex', flexDirection: 'column', gap: '1.5rem' }}>
|
||||
|
||||
|
||||
@@ -72,16 +72,26 @@ export function AuthProvider({ children }) {
|
||||
setUser(null);
|
||||
};
|
||||
|
||||
// Check if user has a specific role
|
||||
const hasRole = (...roles) => {
|
||||
return user && roles.includes(user.role);
|
||||
// Check if user belongs to one of the specified groups
|
||||
const isInGroup = (...groups) => user && groups.includes(user.group);
|
||||
|
||||
// Check if user can perform write operations (Admin or Standard_User)
|
||||
const canWrite = () => isInGroup('Admin', 'Standard_User');
|
||||
|
||||
// Check if user can delete a resource
|
||||
// Admin: always true; Standard_User: only if they own the resource; others: false
|
||||
const canDelete = (resource) => {
|
||||
if (!user) return false;
|
||||
if (isInGroup('Admin')) return true;
|
||||
if (!isInGroup('Standard_User')) return false;
|
||||
return resource?.created_by === user.id;
|
||||
};
|
||||
|
||||
// Check if user can perform write operations (editor or admin)
|
||||
const canWrite = () => hasRole('editor', 'admin');
|
||||
// Check if user can export data
|
||||
const canExport = () => isInGroup('Admin', 'Standard_User', 'Leadership');
|
||||
|
||||
// Check if user is admin
|
||||
const isAdmin = () => hasRole('admin');
|
||||
const isAdmin = () => isInGroup('Admin');
|
||||
|
||||
const value = {
|
||||
user,
|
||||
@@ -90,8 +100,10 @@ export function AuthProvider({ children }) {
|
||||
login,
|
||||
logout,
|
||||
checkAuth,
|
||||
hasRole,
|
||||
isInGroup,
|
||||
canWrite,
|
||||
canDelete,
|
||||
canExport,
|
||||
isAdmin,
|
||||
isAuthenticated: !!user
|
||||
};
|
||||
|
||||
@@ -15,6 +15,7 @@
|
||||
"cors": "^2.8.6",
|
||||
"dotenv": "^16.6.1",
|
||||
"express": "^5.2.1",
|
||||
"express-rate-limit": "^7.5.0",
|
||||
"multer": "^2.0.2",
|
||||
"sqlite3": "^5.1.7"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user